refactor(network): convert .crate downloads to use http_async#16902
Merged
weihanglo merged 4 commits intorust-lang:masterfrom Apr 20, 2026
Merged
refactor(network): convert .crate downloads to use http_async#16902weihanglo merged 4 commits intorust-lang:masterfrom
weihanglo merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-directory-source
arlosi
force-pushed
the
async/pkgset
branch
2 times, most recently
from
9f8d227 to
cbbd5c4
Compare
weihanglo
reviewed
Apr 17, 2026
Contributor
Author
|
Split off part of this change into #16903. Will wait until that one is in, then rebase this one. |
This comment has been minimized.
This comment has been minimized.
Makes the two crate downloading methods async
Removes the existing Multi-based interface to use the http_async abstraction for downloading crates.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
weihanglo
reviewed
Apr 20, 2026
| .get(&id) | ||
| .ok_or_else(|| internal(format!("couldn't find `{}` in package set", id)))?; | ||
| if let Some(pkg) = slot.get() { | ||
| return CargoResult::Ok(pkg); |
Member
There was a problem hiding this comment.
nits, and ditto in this file
Suggested change
| return CargoResult::Ok(pkg); | |
| return Ok(pkg); |
| /// Returns `None` if the package is queued up for download and will | ||
| /// eventually be returned from `wait_for_download`. Returns `Some(pkg)` if | ||
| /// the package is ready and doesn't need to be downloaded. | ||
| #[tracing::instrument(skip_all)] |
Member
There was a problem hiding this comment.
We lose this instrument. Do we have alternative?
(This is not a blocker)
weihanglo
approved these changes
Apr 20, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 21, 2026
Update cargo submodule 9 commits in 7ecf0285ebb408d596e4a8ac76a0980d8edb7005..06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae 2026-04-18 15:34:11 +0000 to 2026-04-21 15:33:56 +0000 - test(git): add regression test for full-hash GitHub fast path (rust-lang/cargo#16919) - fix(help): add `.1` extension to man page temp file (rust-lang/cargo#16917) - Fix flaky test: sparse_blocking_count (rust-lang/cargo#16916) - Fix flaky test compile_offline_while_transitive_dep_not_cached (rust-lang/cargo#16915) - Fix test fetch_all_platform_dependencies_when_no_target_is_given (rust-lang/cargo#16914) - chore(ci): Use `actions/deploy-pages` for Cargo Contributor Guide deployment (rust-lang/cargo#16876) - Convert GitHub fast path to use http_async (rust-lang/cargo#16912) - refactor(network): convert .crate downloads to use http_async (rust-lang/cargo#16902) - fix(tests): flaky test local_poll_adapter deferred_success (rust-lang/cargo#16909) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
downloadandfinish_downloadmethodsasync. It may be possible to do a future refactor PR that combines these two methods together, since they no longer need to be separated to get parallel downloads. This could be a nice future simplification.curl::Multifor downloading crates in parallel, and replace it withhttp_async..unordered()to several test file references. The async downloader is less deterministic in the order that it performs downloads, which would otherwise make the tests flaky.cc #16845
How to test and review this PR?
Commit by commit. All commits pass tests.
r? @weihanglo