Fix test fetch_all_platform_dependencies_when_no_target_is_given

[ehuss]

This test was randomly failing because the order that cargo prints the completion of d1 and d2 is not deterministic.

I suspect this is a result of
#16898 which can cause the parallel fetches to finish in different orders.

This is fixed with .unordered() because the order these are printed isn't important.

[rustbot]

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @ehuss, @epage, @weihanglo
• @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
• Random selection from epage, weihanglo

[arlosi]

Thanks!

View changes since this review

[weihanglo]

---- expected: tests/testsuite/offline.rs:362:27
++++ actual:   stderr
Error: 1      - [ERROR] failed to download `baz v1.0.0`
        1 + [ERROR] failed to download `bar v0.1.0`
   2    2 | 
   3    3 | Caused by:
   4    4 |   attempting to make an HTTP request, but --offline was specified

This also need to redact. @arlosi or anyone still online, mind updating it?

[ehuss]

I'm going to put this back in the queue. I think @arlosi is working on a fix for the other test.
I was trying to kick off the github-pages job with this PR to ensure that it is working correctly after the deploy changed.

[arlosi]

I opened #16915 to fix the other the offline one. Let's try to get both through the flakiness separately.

[ehuss]

@arlosi Looks like another one?

---- registry::sparse_blocking_count stdout ----
running `/Users/runner/work/cargo/cargo/target/debug/cargo check`
/Users/runner/work/cargo/cargo/target/tmp/cit/testsuite/registry/sparse_blocking_count/dl/bar/0.0.1/download
/Users/runner/work/cargo/cargo/target/tmp/cit/testsuite/registry/sparse_blocking_count/dl/dep1/0.0.1/download
/Users/runner/work/cargo/cargo/target/tmp/cit/testsuite/registry/sparse_blocking_count/dl/dep2/0.0.1/download

thread 'registry::sparse_blocking_count' (293748) panicked at tests/testsuite/registry.rs:3603:7:

---- expected: tests/testsuite/registry.rs:3575:27
++++ actual:   stderr
   1    1 | [UPDATING] `dummy-registry` index
   2    2 |    [..] DEBUG network::fetch: url="[..]/index/config.json"
   3    3 |    [..] DEBUG network::fetch: url="[..]/index/3/b/bar"
   4    4 | [WARNING] spurious network error (3 tries remaining): failed to get successful HTTP response from `[..]/index/3/b/bar` ([..]), got 500
   5    5 | body:
   6    6 | internal server error
   7    7 |    [..] DEBUG network::fetch: url="[..]/index/3/b/bar"
   8    8 |    [..] DEBUG cargo::core::resolver::restarting: pending=1
   9    9 |    [..] DEBUG network::fetch: url="[..]/index/de/p1/dep1"
  10   10 |    [..] DEBUG network::fetch: url="[..]/index/de/p2/dep2"
  11      -    [..] DEBUG cargo::core::resolver::restarting: pending=2
       11 +    0.082508708s DEBUG cargo::core::resolver::restarting: pending=1
  12   12 |    [..] DEBUG cargo::core::resolver::restarting: pending=0
  13   13 | [LOCKING] 3 packages to latest compatible versions
  14   14 |    [..] DEBUG cargo::core::resolver::restarting: pending=0
  15   15 | [DOWNLOADING] crates ...
  16   16 |    [..] DEBUG network::fetch: url="http://[..]/dl/bar/0.0.1/download"
          ⋮
  22   22 | [CHECKING] [..] v0.0.1
error: test failed, to rerun pass `-p cargo --test testsuite`
  23   23 | [CHECKING] [..] v0.0.1
  24   24 | [CHECKING] [..] v0.0.1
  25   25 | [CHECKING] foo v0.0.1 ([ROOT]/foo)
  26   26 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

[arlosi]

Looks like another one?

Opened #16916 to fix.