test(git): add regression test for full-hash GitHub fast path#16919
Merged
weihanglo merged 1 commit intorust-lang:masterfrom Apr 21, 2026
Merged
Conversation
rustbot
added
A-git
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Apr 21, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 21, 2026
Update cargo submodule 9 commits in 7ecf0285ebb408d596e4a8ac76a0980d8edb7005..06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae 2026-04-18 15:34:11 +0000 to 2026-04-21 15:33:56 +0000 - test(git): add regression test for full-hash GitHub fast path (rust-lang/cargo#16919) - fix(help): add `.1` extension to man page temp file (rust-lang/cargo#16917) - Fix flaky test: sparse_blocking_count (rust-lang/cargo#16916) - Fix flaky test compile_offline_while_transitive_dep_not_cached (rust-lang/cargo#16915) - Fix test fetch_all_platform_dependencies_when_no_target_is_given (rust-lang/cargo#16914) - chore(ci): Use `actions/deploy-pages` for Cargo Contributor Guide deployment (rust-lang/cargo#16876) - Convert GitHub fast path to use http_async (rust-lang/cargo#16912) - refactor(network): convert .crate downloads to use http_async (rust-lang/cargo#16902) - fix(tests): flaky test local_poll_adapter deferred_success (rust-lang/cargo#16909) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Follow-up coverage for #13946, which fixed #13555
That fix restored the early return in
github_fast_pathfor full commit hashes, but it did not add a direct test for this path. If this guard gets removed in a later refactor, CI would not catch it very directly.I first looked at adding this in the testsuite, but the existing GitHub fast-path coverage uses the public network, and the GitHub API URL is built directly in the code. So i went with a small unit test for the early-return path instead.
How to test and review this PR?
cargo +1.95 test --lib github_fast_path_full_hash_returns_needs_fetch cargo +1.95 fmt --check --all