Fix eslint warnings and add eslint check in CI #2554
Conversation
GuillaumeGomez
force-pushed
the
eslint
branch
2 times, most recently
from
a87b0c6 to
7f4f189
Compare
|
Rebased and fixed merge conflict. |
There was a problem hiding this comment.
Can you add documentation to https://github.com/rust-lang/mdBook/blob/master/CONTRIBUTING.md with links to what this is, how to install it, and some information on how to run and use it?
| @@ -64,7 +64,6 @@ pub fn create_files( | |||
| } | |||
|
|
|||
| if search_config.copy_js { | |||
| static_files.add_builtin("searchindex.json", index.as_bytes()); | |||
There was a problem hiding this comment.
Oh, I see it's from another PR.
There was a problem hiding this comment.
Yep! From #2552 to be more exact.
.eslintrc.json
Outdated
There was a problem hiding this comment.
Can you say how all the rules for this were created? Why are the styles different from the defaults?
There was a problem hiding this comment.
It's the rules we use in rustdoc. "defaults" change from time to time, so with this set of rule, at least it's fixed.
tests/gui/runner.rs
Outdated
| if let Some(version) = line.strip_prefix("BROWSER_UI_TEST_VERSION:") { | ||
| return version.trim().replace('\'', ""); | ||
| let content = read_to_string("package.json").expect("failed to read `package.json`"); | ||
| let json = json::parse(&content).expect("invalid JSON"); |
There was a problem hiding this comment.
Can this use serde_json since it is already in the dependency tree?
Sure! |
|
Applied suggestions. |
|
Rebased. |
First commit comes from #2552.
This PR fixed all eslint warnings and added it as a check in the CI. That is a first step in improving the JS quality.
cc @notriddle