Skip to content

Avoid using the same file twice in SUMMARY.md #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Avoid using the same file twice in SUMMARY.md #2613

merged 1 commit into from
Mar 31, 2025

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Mar 22, 2025 •
edited by ehuss
Loading

Fixes #2612

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Mar 22, 2025
ehuss
ehuss approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Mar 31, 2025
Merged via the queue into rust-lang:master with commit 7a1977a Mar 31, 2025
12 checks passed
@szabgab szabgab deleted the avoid-duplicate-entries branch April 1, 2025 04:55
@smilingpoplar
Copy link

I need to have duplicate files in SUMMARY.md. Can we make it an option?

@szabgab
Copy link
Contributor Author

szabgab commented Apr 3, 2025

@smilingpoplar Could you please comment on #2634 explaining your use-case for duplicate files?

@smilingpoplar
Copy link

@smilingpoplar Could you please comment on #2634 explaining your use-case for duplicate files?

#2634 (comment)

@nunotexbsd nunotexbsd mentioned this pull request Apr 7, 2025
Closed
@Hoffenbar
Copy link

I need an option to allow duplicate names, too. Additionaly, I'm not referencing the same file twice, only same named files but in different locations. Nevertheless, this error is generated:

2025-04-11 16:25:37 [ERROR] (mdbook::utils): Error: Summary parsing failed for file="d:\\data\\mdbook\\book1-src\\src\\SUMMARY.md"
2025-04-11 16:25:37 [ERROR] (mdbook::utils): 	Caused By: Duplicate file in SUMMARY.md: "dummy.md"

Switching back to 0.4.47 meanwhile. This changes breaks compatibility with existing source trees!

@szabgab
Copy link
Contributor Author

szabgab commented Apr 11, 2025

@Hoffenbar
I don't understand what do you mean by "only the same named files".
Could you please explain it and your use-case for having the same name twice on the issue that was opened for this: #2634

@ehuss ehuss mentioned this pull request Apr 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject duplicate entries in SUMMARY.md
5 participants
@szabgab @smilingpoplar @Hoffenbar @ehuss @rustbot