Skip to content

sidebar: use the same resize grip as rustdoc and playground #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

notriddle
Copy link
Contributor

Follow up #2209 and rust-lang/rust#139562

Since rustdoc and the playground both use similar resizing indicators, it only makes sense that mdbook should, too.

Before:

image

After:

image

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label May 9, 2025
@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks! Gonna let @ehuss merge.

@ehuss
Copy link
Contributor

ehuss commented May 10, 2025

Can you say where this shows up in rustdoc? I don't see any resizing indicators on any of the doc pages.

Not really a blocker, but just FYI it renders a little awkwardly in Safari. Compare:

Firefox Chrome Safari
image image image

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue May 10, 2025
Merged via the queue into rust-lang:master with commit a8aee21 May 10, 2025
14 checks passed
@GuillaumeGomez
Copy link
Member

Can you say where this shows up in rustdoc?

You can see a screenshot in rust-lang/rust#139562. It's really recent so you'll need to wait for nightly docs to be rebuilt but you should be able to see it in https://doc.rust-lang.org/nightly/std/.

@notriddle notriddle deleted the knurling branch May 11, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants