c-variadic: gate `va_arg` on `c_variadic_experimental_arch` by folkertdev · Pull Request #156043 · rust-lang/rust

folkertdev · 2026-05-01T11:21:50Z

tracking issue: #44930

Just gating ... is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it.

r? joshtriplett

rustbot · 2026-05-01T11:21:55Z

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

joshtriplett · 2026-05-03T18:41:10Z

@bors r+ rollup

rust-bors · 2026-05-03T18:41:13Z

📌 Commit ddf2233 has been approved by joshtriplett

It is now in the queue for this repository.

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

…uwer Rollup of 2 pull requests Successful merges: - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156044 (Move tests array slice vec)

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

Rollup of 2 pull requests Successful merges: - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156044 (Move tests array slice vec)

rust-bors · 2026-05-04T02:58:13Z

⌛ Testing commit ddf2233 with merge a2b9f4a...

Workflow: https://github.com/rust-lang/rust/actions/runs/25298805233

…shtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: #44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

jhpratt · 2026-05-04T03:00:18Z

@bors r-

#156126 (comment)

rust-bors · 2026-05-04T03:00:25Z

This pull request was unapproved.

This PR was contained in the following rollups:

Rollup of 2 pull requests #156117 was unapproved
Rollup of 2 pull requests #156126 was unapproved

Auto build was cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25298805233

View changes since this unapproval

Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it.

folkertdev · 2026-05-04T08:03:40Z

@bors try jobs=x86_64-gnu-nopt

c-variadic: gate `va_arg` on `c_variadic_experimental_arch` try-job: x86_64-gnu-nopt

rust-bors · 2026-05-04T10:23:38Z

☀️ Try build successful (CI)
Build commit: 994c997 (994c997a8242f08e8954179889a6483edb85942a, parent: a51f3a89b2fffc6ce38f484d7cbf9dc25b0fe791)

folkertdev · 2026-05-04T10:24:48Z

@bors r=joshtriplett

rust-bors · 2026-05-04T10:24:51Z

📌 Commit 8e0ebb9 has been approved by joshtriplett

It is now in the queue for this repository.

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

Rollup of 6 pull requests Successful merges: - #155543 (docs(unstable-book): Document const generics features) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails)

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

…uwer Rollup of 10 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #155543 (docs(unstable-book): Document const generics features) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id)

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

…uwer Rollup of 10 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id)

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

…uwer Rollup of 12 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156103 (Fix E0040 suggestion for explicit `Drop::drop` UFCS calls) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id) - #156152 (Update books)

…-test, r=joshtriplett c-variadic: gate `va_arg` on `c_variadic_experimental_arch` tracking issue: rust-lang#44930 Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it. r? joshtriplett

Rollup of 16 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156087 (Improve `&pin` reference-pattern suggestions) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156103 (Fix E0040 suggestion for explicit `Drop::drop` UFCS calls) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156122 (Add a `doc_cfg` regression test to ensure foreign types impls are working as expected) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id) - #156152 (Update books) - #156154 (tests: mark import UI tests as check-pass) - #156162 (Update `browser-ui-test` version to `0.23.5`)

folkertdev added the F-c_variadic `#![feature(c_variadic)]` label May 1, 2026

rustbot assigned joshtriplett May 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2026

JonathanBrouwer mentioned this pull request May 3, 2026

Rollup of 2 pull requests #156117

Closed

jhpratt mentioned this pull request May 3, 2026

Rollup of 2 pull requests #156126

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2026

c-variadic: gate va_arg on c_variadic_experimental_arch

8e0ebb9

Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it.

folkertdev force-pushed the c-variadic-avr-assembly-test branch from ddf2233 to 8e0ebb9 Compare May 4, 2026 08:03

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 4, 2026

Auto merge of #156043 - folkertdev:c-variadic-avr-assembly-test, r=<try>

994c997

c-variadic: gate `va_arg` on `c_variadic_experimental_arch` try-job: x86_64-gnu-nopt

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026

jhpratt mentioned this pull request May 4, 2026

Rollup of 6 pull requests #156140

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 9 pull requests #156149

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 10 pull requests #156150

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 10 pull requests #156153

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 12 pull requests #156158

Open

GuillaumeGomez mentioned this pull request May 5, 2026

Rollup of 16 pull requests #156166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

c-variadic: gate `va_arg` on `c_variadic_experimental_arch`#156043

c-variadic: gate `va_arg` on `c_variadic_experimental_arch`#156043
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:c-variadic-avr-assembly-test

folkertdev commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

joshtriplett commented May 3, 2026

Uh oh!

rust-bors Bot commented May 3, 2026

Uh oh!

rust-bors Bot commented May 4, 2026 •

edited

Loading

Uh oh!

jhpratt commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

folkertdev commented May 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 4, 2026

Uh oh!

folkertdev commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

folkertdev commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

joshtriplett commented May 3, 2026

Uh oh!

rust-bors Bot commented May 3, 2026

Uh oh!

rust-bors Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

folkertdev commented May 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 4, 2026

Uh oh!

folkertdev commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rust-bors Bot commented May 4, 2026 •

edited

Loading