Remove most uses of def_id_to_node_id by oli-obk · Pull Request #156135 · rust-lang/rust

oli-obk · 2026-05-04T08:50:25Z

Especially those happening during normal resolving, where we are actually looking at current parent scopes. It allows follow-up refactorings to not have a way to go from NodeId to DefId until macro expansion is done

r? @petrochenkov

oli-obk · 2026-05-04T08:50:33Z

@bors try @rust-timer queue

Remove most uses of def_id_to_node_id

rust-bors · 2026-05-04T10:59:09Z

☀️ Try build successful (CI)
Build commit: 51692aa (51692aa38a8b5a72d6a8e19b51ceb5d29ce10eb0, parent: a51f3a89b2fffc6ce38f484d7cbf9dc25b0fe791)

rust-timer · 2026-05-04T12:27:01Z

Finished benchmarking commit (51692aa): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.0%, 0.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	5
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.0%, -0.5%]	5
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.9%, 3.9%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-5.4%, -0.5%]	8
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 501.019s -> 495.055s (-1.19%)
Artifact size: 396.46 MiB -> 394.41 MiB (-0.52%)

Especially those happening during normal resolving, where we are actually looking at current parent scopes

oli-obk · 2026-05-04T15:44:42Z

perf looks like noise. Coercions incr-unchanged + opt shouldn't be the only regression, the other coercions perf tests don't show the change and the entire benchmark has been going up and down recently by those 0.5%

oli-obk · 2026-05-04T15:45:17Z

@bors rollup

petrochenkov · 2026-05-04T15:54:45Z

@bors r+

rust-bors · 2026-05-04T15:54:49Z

📌 Commit fd701b7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…n, r=petrochenkov Remove most uses of def_id_to_node_id Especially those happening during normal resolving, where we are actually looking at current parent scopes. It allows follow-up refactorings to not have a way to go from `NodeId` to `DefId` until macro expansion is done r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`) - #155543 (docs(unstable-book): Document const generics features) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id)

@petrochenkov

…n, r=petrochenkov Remove most uses of def_id_to_node_id Especially those happening during normal resolving, where we are actually looking at current parent scopes. It allows follow-up refactorings to not have a way to go from `NodeId` to `DefId` until macro expansion is done r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id)

@petrochenkov

…n, r=petrochenkov Remove most uses of def_id_to_node_id Especially those happening during normal resolving, where we are actually looking at current parent scopes. It allows follow-up refactorings to not have a way to go from `NodeId` to `DefId` until macro expansion is done r? @petrochenkov

…uwer Rollup of 12 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156103 (Fix E0040 suggestion for explicit `Drop::drop` UFCS calls) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id) - #156152 (Update books)

@petrochenkov

…n, r=petrochenkov Remove most uses of def_id_to_node_id Especially those happening during normal resolving, where we are actually looking at current parent scopes. It allows follow-up refactorings to not have a way to go from `NodeId` to `DefId` until macro expansion is done r? @petrochenkov

Rollup of 16 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156087 (Improve `&pin` reference-pattern suggestions) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156103 (Fix E0040 suggestion for explicit `Drop::drop` UFCS calls) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156122 (Add a `doc_cfg` regression test to ensure foreign types impls are working as expected) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id) - #156152 (Update books) - #156154 (tests: mark import UI tests as check-pass) - #156162 (Update `browser-ui-test` version to `0.23.5`)

rustbot assigned petrochenkov May 4, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 4, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2026

rust-bors Bot pushed a commit that referenced this pull request May 4, 2026

Auto merge of #156135 - oli-obk:def_id_to_node_id_reduction, r=<try>

51692aa

Remove most uses of def_id_to_node_id

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 4, 2026

oli-obk added 2 commits May 4, 2026 17:40

Add NodeId to ModuleKind

71177d1

Remove most uses of def_id_to_node_id

fd701b7

Especially those happening during normal resolving, where we are actually looking at current parent scopes

oli-obk force-pushed the def_id_to_node_id_reduction branch from 0d0bc06 to fd701b7 Compare May 4, 2026 15:41

oli-obk marked this pull request as ready for review May 4, 2026 15:44

oli-obk added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 10 pull requests #156150

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 10 pull requests #156153

Closed

JonathanBrouwer mentioned this pull request May 4, 2026

Rollup of 12 pull requests #156158

Open

GuillaumeGomez mentioned this pull request May 5, 2026

Rollup of 16 pull requests #156166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove most uses of def_id_to_node_id#156135

Remove most uses of def_id_to_node_id#156135
oli-obk wants to merge 2 commits intorust-lang:mainfrom
oli-obk:def_id_to_node_id_reduction

oli-obk commented May 4, 2026

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 4, 2026

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

petrochenkov commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

oli-obk commented May 4, 2026

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 4, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

oli-obk commented May 4, 2026

Uh oh!

petrochenkov commented May 4, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants