Add a doc_cfg regression test to ensure foreign types impls are working as expected#156122
Open
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Open
Add a doc_cfg regression test to ensure foreign types impls are working as expected#156122GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
doc_cfg regression test to ensure foreign types impls are working as expected#156122GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Conversation
…king as expected
rustbot
added
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
Oh a flaky. It's been a long time. ^^' |
Urgau
approved these changes
May 4, 2026
Urgau
added
S-waiting-on-author
Member
Author
|
@bors r=Urgau rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 5, 2026
Add a `doc_cfg` regression test to ensure foreign types impls are working as expected Fixes rust-lang#150268. This is the last case mentioned in the issue that wasn't tested. With this, the issue can be closed. r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
May 5, 2026
Rollup of 16 pull requests Successful merges: - #155848 ([doc]: Revert `core::io::ErrorKind` doc changes) - #155855 (Remove unnecessary `get_unchecked`) - #155543 (docs(unstable-book): Document const generics features) - #155962 (`rustc`: `target_features`: allow for `cfg`-only stable `target_features`) - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`) - #156082 (Move tests associated types) - #156087 (Improve `&pin` reference-pattern suggestions) - #156092 (Clean up `TyCtxt::needs_crate_hash` usage and rename it to `needs_hir_hash`.) - #156103 (Fix E0040 suggestion for explicit `Drop::drop` UFCS calls) - #156104 (Relax `T: Sized` bound on `try_as_dyn` / `try_as_dyn_mut`) - #156122 (Add a `doc_cfg` regression test to ensure foreign types impls are working as expected) - #156128 (.mailmap: prefer matching just based on commit emails) - #156135 (Remove most uses of def_id_to_node_id) - #156152 (Update books) - #156154 (tests: mark import UI tests as check-pass) - #156162 (Update `browser-ui-test` version to `0.23.5`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150268.
This is the last case mentioned in the issue that wasn't tested. With this, the issue can be closed.
r? @Urgau