Skip to content

disable CRLF conversion, rather than forcing to LF #9420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

disable CRLF conversion, rather than forcing to LF #9420

wants to merge 1 commit into from

Conversation

thestinger
Copy link
Contributor

at the moment, the EOL is being set to LF on binary files too

at the moment, the EOL is being set to LF on binary files too
@thestinger
Copy link
Contributor Author

This workaround was added to stop git from changing the EOL to CRLF on Windows because it breaks the build.

However, it was done by setting it on the * glob rather than just text files which is mangling the ico file in the repository. A saner way to deal with this is disabling git's CRLF conversion.

@thestinger
Copy link
Contributor Author

Meh, again this isn't really the proper solution....

@thestinger thestinger closed this Sep 23, 2013
@thestinger thestinger deleted the eol branch September 23, 2013 05:37
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 9, 2022
Suggest `unwrap_or_default` when closure returns `"".to_string`

Closes rust-lang/rust-clippy#9420

changelog: [`unwrap_or_else_default`]: suggest `unwrap_or_default()` instead of `unwrap_or_else` with a closure that returns an empty `to_string`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant