Skip to content

Conversation

@quentinblampey
Copy link
Contributor

@quentinblampey quentinblampey commented Mar 24, 2025

PR related to the following issues:

@quentinblampey
Copy link
Contributor Author

I revert the fix for the coordinate system, since @LucaMarconato you already fixed it in #303

I'll also close the corresponding issue I opened earlier. So, there is only the "separate kwargs" issue remaining

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.75%. Comparing base (fe474c6) to head (7c19850).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/visium_hd.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fe474c6) and HEAD (7c19850). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fe474c6) HEAD (7c19850)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #294       +/-   ##
===========================================
- Coverage   49.53%   38.75%   -10.78%     
===========================================
  Files          26       26               
  Lines        2709     2709               
===========================================
- Hits         1342     1050      -292     
- Misses       1367     1659      +292     
Files with missing lines Coverage Δ
src/spatialdata_io/readers/visium_hd.py 16.66% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato merged commit 19b6cbf into scverse:main May 5, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants