Add RemRam v1 board variant #287

hasenbanck · 2018-07-27T16:19:40Z

RemRam is an open-source 3D printing controller.

https://github.com/hasenbanck/remram

RemRam is an open-source 3D printing controller. It's source files can be found at [1]. [1] https://github.com/hasenbanck/remram

fpistm · 2018-07-27T16:46:29Z

Thanks @hasenbanck .

hasenbanck · 2018-07-29T05:49:24Z

Don't merge yet. I might need to change timer configuration / IWDG. Will report back when I'm 100% sure.

fpistm

First review.
It seems your a not on top of the master. You should rebase on master.

fpistm · 2018-07-29T08:17:06Z

variants/REMRAM_V1/variant.h

+    PC3, // D68 - FAN_SPEED2
+
+    // Duplicated pins in order to be aligned with PinMap_ADC
+    PC0_2, //D69/A0 - THERM_1


You don't need to duplicate the pins as they are grouped

fpistm · 2018-07-29T08:17:23Z

variants/REMRAM_V1/variant.cpp

+      PA_4, // D67 - FAN_SPEED1
+      PC_3, // D68 - FAN_SPEED2
+
+      // Duplicated pins in order to be aligned with PinMap_ADC


You don't need to duplicate the pins as they are grouped

fpistm · 2018-07-29T08:18:34Z

variants/REMRAM_V1/stm32f7xx_hal_conf.h

+/* #define HAL_SPDIFRX_MODULE_ENABLED   */
+#define HAL_SPI_MODULE_ENABLED
+#define HAL_TIM_MODULE_ENABLED
+#define HAL_UART_MODULE_ENABLED


You could comment it, it is defined by default by platform.txt. Define it raised a warning about redefinition

Commenting UART out would break building in Eclipse / Sloeber. I guess it would be better to life with a warning.

After fixing the Serial stuff in the board.txt the build works without defining the UART here. I will comment it out then.

fpistm · 2018-07-29T08:21:06Z

variants/REMRAM_V1/variant.h

+// PIN definition
+#define NUM_DIGITAL_PINS 74
+#define NUM_ANALOG_INPUTS 5
+#define NUM_ANALOG_FIRST 69


So first is 64 or PC0

fpistm · 2018-07-29T08:21:51Z

variants/REMRAM_V1/variant.h

+#define PWM_MAX_DUTY_CYCLE      255
+
+// On-board LED pin number
+#define LED_YELLOW 21


Preferred use the pin name PD0

fpistm · 2018-07-29T08:23:33Z

boards.txt

@@ -725,3 +772,31 @@ Maple.menu.opt.o3lto.build.flags.ldspecs=-flto
 Maple.menu.opt.ogstd=Debug (-g)
 Maple.menu.opt.ogstd.build.flags.optimize=-g -Og
 Maple.menu.opt.ogstd.build.flags.ldspecs=
+
+RemRam.menu.opt.osstd=Smallest (-Os default)
+RemRam.menu.opt.osstd.build.flags.optimize=-Os


Remove those 2 lines, they are useless as this is the default in platform.txt

RemRam.menu.opt.osstd.build.flags.optimize=-Os RemRam.menu.opt.osstd.build.flags.ldspecs=

You're sure about that? Using Eclipse / Sloeber won't show me the "-Os" Option without LTO if I remove those two lines.

Ah okay, I got confused with the line numbering. Now I understand.

fpistm · 2018-07-29T08:24:46Z

boards.txt

@@ -532,6 +571,14 @@ Maple.menu.xserial.none.build.xSerial=-DHAL_UART_MODULE_ENABLED -DHWSERIAL_NONE
 Maple.menu.xserial.disabled=Disabled (No Serial)
 Maple.menu.xserial.disabled.build.xSerial=

+RemRam.menu.xserial.generic=Generic Serial


It seems your a not on the latest core.
You should rebase those menu has been review on 1.3.0.

fpistm · 2018-07-29T08:31:08Z

What about IWDG? I'm currently review the IWDG library #234

hasenbanck · 2018-07-29T11:19:27Z

I'm pretty sure that this PR is rebased to current master. I tripple checked the parent of my last commit. Odd.

Will fix the issues you marked.

I will push aside the IWDG until you merged #234 and I have more time to test.

* Removed not needed pin mapping * Use new serial menu items * Removed unneeded UART declaration * Removed unneeded optimization * Use PIN name instead of PIN number

hasenbanck · 2018-07-29T12:02:10Z

variants/REMRAM_V1/variant.h

-    PC15, // D54 - BTN_EN1
-    PC14, // D55 - BTN_EN2
+    PC14, // D54 - BTN_EN1
+    PC15, // D55 - BTN_EN2


fpistm · 2018-07-29T13:00:57Z

Right you are on top. I've asked this as I saw the old Serial Menu.
I've pull this PR and it is ok.
I will try to add the IWDG this week.

hasenbanck · 2018-07-29T13:12:02Z

Thank you very much.

It seems that somehow the old generated file lacked the heap definition. I re-created the script with the newest version of Cube MX and the newest F7 driver package.

fpistm · 2018-07-31T18:51:57Z

FYI, I've reviewed IWDG, based on the PR, I will push an updated version generic for all STM32 series.

hasenbanck · 2018-07-31T19:04:34Z

Good to know. I'm currently reviewing the whole design, since I'm chasing a weird data corruption bug when I'm reading SD over SPI. That's why I saw the missing heap definition.

fpistm · 2018-07-31T19:31:43Z

Ok let me know when you will confident to this variant as I can't test it due to lack of board to test.

hasenbanck · 2018-08-02T05:02:45Z

I'm pretty sure now that this variant doesn't need a hardware rework anymore. It's ready for merge.

fpistm · 2018-08-03T15:12:27Z

Hi @hasenbanck,
I've made the PR for IWDG. See #292
Any comment are welcome. ;)

hasenbanck · 2018-08-03T15:35:52Z

@fpistm I hope to be able to get my controller board fully operational in my printer this weekend. Hopefully I can give you feedback about the IWDG in action then.

The two external PWM pins for the servos got mixed up. This commits restores the correct order.

hasenbanck · 2018-08-05T18:42:06Z

While testing the bugged Marlin code for servo handling, I realized that I also mixed up two pin assignments in the variant definition. The last commit fixes this issue.

fpistm · 2018-09-20T08:29:18Z

Hi @hasenbanck
Just one question is it any reason to not enable the HAL_RTC_MODULE_ENABLED for the remram?

hasenbanck · 2018-09-20T09:04:03Z

It's not needed for my primary build target, the Marlin firmware. Marlin doesn't use any RTC functionality.

fpistm · 2018-09-20T09:10:28Z

Did you see any drawback if I enable it per default?
Even if enabled while the STM32RTC.h is not include the binary will not embed it.

hasenbanck · 2018-09-20T09:11:43Z

Yeah, there shouldn't be any drawbacks in enabling it by default. You can do that if you want to stay consistent with the other boards.

Add RemRam v1 board variant RemRam is an open-source 3D printing controller. It's source files can be found at [1]. [1] https://github.com/hasenbanck/remram Signed-off-by: Nils Hasenbanck <[email protected]>

Add RemRam v1 board variant

d986103

RemRam is an open-source 3D printing controller. It's source files can be found at [1]. [1] https://github.com/hasenbanck/remram

fpistm self-requested a review July 27, 2018 16:45

fpistm added the new variant Add support of new bard label Jul 27, 2018

hasenbanck mentioned this pull request Jul 27, 2018

Upstream the RemRam board variant for Arduino_Core_STM32 hasenbanck/remram#3

Closed

fpistm requested changes Jul 29, 2018

View reviewed changes

Fix requested changes for PR

6dde2d2

* Removed not needed pin mapping * Use new serial menu items * Removed unneeded UART declaration * Removed unneeded optimization * Use PIN name instead of PIN number

hasenbanck commented Jul 29, 2018

View reviewed changes

Fix ldscript.ld for RemRam v1

ad979e7

It seems that somehow the old generated file lacked the heap definition. I re-created the script with the newest version of Cube MX and the newest F7 driver package.

fpistm approved these changes Jul 31, 2018

View reviewed changes

Fix switched EXT_PWM pins

10f3a74

The two external PWM pins for the servos got mixed up. This commits restores the correct order.

hasenbanck mentioned this pull request Aug 8, 2018

Ask NUCLEO-F767ZI #295

Closed

This was referenced Sep 7, 2018

The Marlin 2.0 32-bit thread MarlinFirmware/Marlin#7076

Closed

[2.0.x] STM32F7 HAL using the official STM32 Arduino Core MarlinFirmware/Marlin#11750

Merged

fpistm merged commit c5563f3 into stm32duino:master Sep 14, 2018

hasenbanck deleted the remram-variant branch October 1, 2018 09:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RemRam v1 board variant #287

Add RemRam v1 board variant #287

hasenbanck commented Jul 27, 2018

fpistm commented Jul 27, 2018

hasenbanck commented Jul 29, 2018

fpistm left a comment

fpistm Jul 29, 2018

fpistm Jul 29, 2018

fpistm Jul 29, 2018

hasenbanck Jul 29, 2018

hasenbanck Jul 29, 2018

fpistm Jul 29, 2018

fpistm Jul 29, 2018

fpistm Jul 29, 2018

hasenbanck Jul 29, 2018

hasenbanck Jul 29, 2018

fpistm Jul 29, 2018

fpistm commented Jul 29, 2018

hasenbanck commented Jul 29, 2018

hasenbanck Jul 29, 2018

fpistm commented Jul 29, 2018

hasenbanck commented Jul 29, 2018

fpistm commented Jul 31, 2018

hasenbanck commented Jul 31, 2018

fpistm commented Jul 31, 2018

hasenbanck commented Aug 2, 2018

fpistm commented Aug 3, 2018

hasenbanck commented Aug 3, 2018

hasenbanck commented Aug 5, 2018

fpistm commented Sep 20, 2018

hasenbanck commented Sep 20, 2018

fpistm commented Sep 20, 2018

hasenbanck commented Sep 20, 2018

Add RemRam v1 board variant #287

Add RemRam v1 board variant #287

Conversation

hasenbanck commented Jul 27, 2018

fpistm commented Jul 27, 2018

hasenbanck commented Jul 29, 2018

fpistm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpistm commented Jul 29, 2018

hasenbanck commented Jul 29, 2018

Choose a reason for hiding this comment

fpistm commented Jul 29, 2018

hasenbanck commented Jul 29, 2018

fpistm commented Jul 31, 2018

hasenbanck commented Jul 31, 2018

fpistm commented Jul 31, 2018

hasenbanck commented Aug 2, 2018

fpistm commented Aug 3, 2018

hasenbanck commented Aug 3, 2018

hasenbanck commented Aug 5, 2018

fpistm commented Sep 20, 2018

hasenbanck commented Sep 20, 2018

fpistm commented Sep 20, 2018

hasenbanck commented Sep 20, 2018