Skip to content

Add missing german tanslations #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add missing german tanslations #526

wants to merge 3 commits into from

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Apr 8, 2017

Some missing translations.

Do you have any kind of translation policies and/or online translation tools currently enabled for this project? (e.g. Transifex, Crowdin, etc.)

@javiereguiluz
Copy link
Member

Thanks for contributing these translations. I'll wait for the review of our German-speaking friends. About your question: we don't have any policy about this or use any of the tools you mentioned. Thanks!

</trans-unit>
<trans-unit id="rss.title">
<source>rss.title</source>
<target>Symfony Demo blog</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blog

</trans-unit>
<trans-unit id="rss.description">
<source>rss.description</source>
<target>Die neusten Posts die auf dem Symfony Demo Blog veröffentlicht wurden</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die neuesten Posts, die auf dem Symfony Blog veröffentlicht wurden.

@elkuku
Copy link
Contributor Author

elkuku commented Apr 8, 2017

Fixed 😉

@elkuku
Copy link
Contributor Author

elkuku commented Apr 8, 2017

The security check is failing on my language file changes - I love Travis 👅

@elkuku
Copy link
Contributor Author

elkuku commented Apr 11, 2017

While playing wit #531 I discovered more missing strings... @xabbuh would you mind to re-check? 😉

</trans-unit>
<trans-unit id="http_error.description">
<source>http_error.description</source>
<target>Ein unbekannter Fehler (HTTP %status_code%) ist aufgetreten wegen dem ihre Anfrage nicht ausgeführt werden konnte.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword this:

Ein unbekannter Fehler (HTTP %status_code%) ist aufgetreten. Ihre Anfrage konnte deswegen nicht ausgeführt werden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, it looks like everywhere else we used "du" instead of "Sie".

</trans-unit>
<trans-unit id="http_error_404.suggestion">
<source>http_error_404.suggestion</source>
<target>Überprüfen Sie Rechtschreibfehler in der URL or <a href="%url%">gehen sie zurück zur Homepage</a>.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or -> oder

</trans-unit>
<trans-unit id="http_error_500.suggestion">
<source>http_error_500.suggestion</source>
<target>Versuchen sie diese Seite in einigen Minuten erneut zu laden or <a href="%url%">gehen sie zurück zur Homepage</a>.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or -> oder

</trans-unit>
<trans-unit id="notification.comment_created.description">
<source>notification.comment_created.description</source>
<target>Ihr Beitrag "%title%" hat einen Kommentar erhalten. Sie können den Kommentar lesen venn sie <a href="%link%">diesem Link</a> folgen.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] lesen, wenn [...]

@elkuku
Copy link
Contributor Author

elkuku commented Apr 12, 2017

Fixed, Thanks!

I also changed everything to "informal".

BTW: @xabbuh do you think #531 makes any sense? How do you check for missing translations? Don't you think using an online translation service (Transifex, Crowdin, etc.) would help?

Thanks again 😉

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

Thank you @elkuku.

@elkuku elkuku deleted the translations branch April 16, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants