Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9945

What problem does this PR solve?

Issue Number: Close #9942

What is changed and how does it work?

Due to adding store label in #9898, we need to delete the related metrics on store deleting, otherwise it will retain forever.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. scale-in one tikv
  2. pd-ctl store remove-tombstone
img_v3_02s6_fb7a775b-307a-4faf-b493-4184098f657g

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 6, 2025
@ti-chi-bot
Copy link
Member Author

@okJiang This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2025
@okJiang okJiang force-pushed the cherry-pick-9945-to-release-8.5 branch from d21520e to 7631881 Compare December 12, 2025 03:38
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.80%. Comparing base (a91c005) to head (85be862).
⚠️ Report is 8 commits behind head on release-8.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-8.5   #10009   +/-   ##
============================================
  Coverage        77.79%   77.80%           
============================================
  Files              469      471    +2     
  Lines            63361    63459   +98     
============================================
+ Hits             49294    49376   +82     
- Misses           10435    10447   +12     
- Partials          3632     3636    +4     
Flag Coverage Δ
unittests 77.80% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 12, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 01:45:09.460724413 +0000 UTC m=+1437454.274501975: ☑️ agreed by bufferflies.
  • 2025-12-15 02:15:07.516429087 +0000 UTC m=+1439252.330206660: ☑️ agreed by okJiang.

@okJiang okJiang force-pushed the cherry-pick-9945-to-release-8.5 branch from 7631881 to 85be862 Compare December 15, 2025 03:25
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2025
@okJiang
Copy link
Member

okJiang commented Dec 15, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2025
@ti-chi-bot ti-chi-bot bot merged commit 6801645 into tikv:release-8.5 Dec 15, 2025
27 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-9945-to-release-8.5 branch December 15, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants