-
Notifications
You must be signed in to change notification settings - Fork 753
statistics: delete cluster status metrics on store deletion (#9945) #10009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: delete cluster status metrics on store deletion (#9945) #10009
Conversation
|
@okJiang This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
d21520e to
7631881
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #10009 +/- ##
============================================
Coverage 77.79% 77.80%
============================================
Files 469 471 +2
Lines 63361 63459 +98
============================================
+ Hits 49294 49376 +82
- Misses 10435 10447 +12
- Partials 3632 3636 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close tikv#9942 Signed-off-by: okjiang <819421878@qq.com>
7631881 to
85be862
Compare
|
/unhold |
This is an automated cherry-pick of #9945
What problem does this PR solve?
Issue Number: Close #9942
What is changed and how does it work?
Due to adding
storelabel in #9898, we need to delete the related metrics on store deleting, otherwise it will retain forever.Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note