statistics: Add 'store' label to metric pd_cluster_status. #9898

SerjKol80 · 2025-10-31T19:05:34Z

What problem does this PR solve?

Issue Number: Close #9855

What is changed and how does it work?

Add 'store' label to metric pd_cluster_status.

Check List

Tests

Unit test

Code changes

Metrics only

Side effects

metric pd_cluster_status now needs to be aggregated in metic system across all stores if you need value across whole cluster.

Related changes
N/A

Release note

metric "pd_cluster_status" now has additional label "store" containing ID of the store.

ti-chi-bot · 2025-10-31T19:05:45Z

Hi @SerjKol80. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rleungx · 2025-11-03T05:40:59Z

/ok-to-test

lhy1024 · 2025-11-04T04:15:53Z

pkg/statistics/store_collection_test.go

 		ObserveHotStat(store, storesStats)
 	}
 	stats := storeStats.stats
-	tikvStats := stats.engineStatistics[core.EngineTiKV]


Do we need to add a new test for it?

@lhy1024
Since we don't have aggregation logic anymore, then the test was removed for that part.
So, the only thing that might be tested in a new logic is if actual metric is emitted. I looked through existing tests and didn't find any tests validating actual metric emission. Thus, no new tests.

lhy1024 · 2025-11-04T04:19:00Z

pkg/statistics/metrics.go

 			Name:      "status",
 			Help:      "Status of the cluster.",
-		}, []string{"type", "engine"})
+		}, []string{"type", "engine", "store"})


Do we need to update metrics/grafana/pd.json?

@lhy1024
I don't think so. All queries for pd_cluster_status metrics already aggregate that metric with sum(). Thus, there should no be any changes there. The description of that metrics should be updated, but I wasn't able to find doc describing metrics in this repo.

SerjKol80 · 2025-11-05T19:19:24Z

@lhy1024
Thank you. Would you initiate the merge. It looks like I don't have permission.

lhy1024 · 2025-11-06T02:08:46Z

@bufferflies PTAL

ti-chi-bot · 2025-11-11T23:30:22Z

[LGTM Timeline notifier]

Timeline:

2025-11-05 07:29:51.714334856 +0000 UTC m=+255241.157364725: ☑️ agreed by lhy1024.
2025-11-11 23:30:21.105077587 +0000 UTC m=+831270.548107466: ☑️ agreed by Tema.

ti-chi-bot · 2025-11-12T01:59:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024, Tema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Tema · 2025-11-12T17:55:15Z

@lhy1024 @bufferflies could you please approve 4 pending workflows to run ^

SerjKol80 · 2025-11-12T20:09:29Z

/retest

codecov · 2025-11-12T20:18:14Z

Codecov Report

❌ Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (75bdf39) to head (fc8d6df).
⚠️ Report is 69 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9898      +/-   ##
==========================================
+ Coverage   78.58%   78.68%   +0.10%     
==========================================
  Files         494      495       +1     
  Lines       66411    66457      +46     
==========================================
+ Hits        52187    52294     +107     
+ Misses      10440    10379      -61     
  Partials     3784     3784

Flag	Coverage Δ
unittests	`78.68% <95.91%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SerjKol80 · 2025-11-12T21:57:58Z

/retest

lhy1024 · 2025-11-13T03:01:58Z

/test pull-unit-test-next-gen

lhy1024 · 2025-11-13T03:02:47Z

pkg/statistics/store_collection.go

 	"fmt"
 	"strconv"

 	"github.com/pingcap/kvproto/pkg/metapb"


SerjKol80 · 2025-11-13T18:12:46Z

/retest

Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com>

SerjKol80 · 2025-11-13T20:07:42Z

/retest

close tikv#9855 Add 'store' label to metric pd_cluster_status. Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com> Co-authored-by: Sergey Kolosov <sergey.kolosov@airbnb.com> (cherry picked from commit 697cbd3) Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com>

close tikv#9855 Add 'store' label to metric pd_cluster_status. Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com> Co-authored-by: Sergey Kolosov <sergey.kolosov@airbnb.com>

close tikv#9855 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-12-12T03:59:45Z

In response to a cherrypick label: new pull request created to branch release-8.5: #10055.
But this PR has conflicts, please resolve them!

…10055) close #9855 Add 'store' label to metric pd_cluster_status. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: 童剑 <1045931706@qq.com> Co-authored-by: Sergey Kolosov <47006793+SerjKol80@users.noreply.github.com> Co-authored-by: 童剑 <1045931706@qq.com>

close tikv#9855 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2026-01-08T00:41:58Z

In response to a cherrypick label: new pull request created to branch release-7.5: #10136.
But this PR has conflicts, please resolve them!

ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2025

SerjKol80 mentioned this pull request Oct 31, 2025

Add 'store' label to metric pd_cluster_status in 8.5. #9865

Merged

rleungx requested a review from bufferflies November 3, 2025 05:40

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 3, 2025

lhy1024 reviewed Nov 4, 2025

View reviewed changes

lhy1024 approved these changes Nov 5, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 5, 2025

Tema approved these changes Nov 11, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2025

bufferflies approved these changes Nov 12, 2025

View reviewed changes

SerjKol80 force-pushed the sergey-kolosov/metric-labels-master branch from 4fca504 to 4a4d487 Compare November 12, 2025 18:59

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2025

SerjKol80 force-pushed the sergey-kolosov/metric-labels-master branch from 4a4d487 to 750b9be Compare November 12, 2025 21:17

lhy1024 reviewed Nov 13, 2025

View reviewed changes

pkg/statistics/store_collection.go

"fmt"

"strconv"

"github.com/pingcap/kvproto/pkg/metapb"

Copy link

Contributor

lhy1024 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix ci

Add 'store' label to metric pd_cluster_status.

fc8d6df

Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com>

SerjKol80 force-pushed the sergey-kolosov/metric-labels-master branch from 750b9be to fc8d6df Compare November 13, 2025 19:50

ti-chi-bot bot merged commit 697cbd3 into tikv:master Nov 13, 2025
29 checks passed

SerjKol80 deleted the sergey-kolosov/metric-labels-master branch November 13, 2025 20:43

okJiang mentioned this pull request Nov 19, 2025

statistics: delete cluster status metrics on store deletion #9945

Merged

ti-chi-bot mentioned this pull request Dec 6, 2025

statistics: delete cluster status metrics on store deletion (#9945) #10009

Merged

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 12, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 12, 2025

This is an automated cherry-pick of tikv#9898

e10d96d

close tikv#9855 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 12, 2025

statistics: Add 'store' label to metric pd_cluster_status. (#9898) #10055

Merged

ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 8, 2026

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 8, 2026

This is an automated cherry-pick of tikv#9898

7beb303

close tikv#9855 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jan 8, 2026

statistics: Add 'store' label to metric pd_cluster_status. (#9898) #10136

Open

This was referenced Jan 23, 2026

statistics: delete cluster status metrics on store deletion (#9945) #10188

Open

statistics: delete cluster status metrics on store deletion (#9945) #10189

Open

statistics: Add 'store' label to metric pd_cluster_status. #9898

statistics: Add 'store' label to metric pd_cluster_status. #9898

Uh oh!

Conversation

SerjKol80 commented Oct 31, 2025

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Oct 31, 2025

Uh oh!

rleungx commented Nov 3, 2025

Uh oh!

lhy1024 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

SerjKol80 Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lhy1024 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

SerjKol80 Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SerjKol80 commented Nov 5, 2025

Uh oh!

lhy1024 commented Nov 6, 2025

Uh oh!

ti-chi-bot bot commented Nov 11, 2025

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot bot commented Nov 12, 2025

Uh oh!

Tema commented Nov 12, 2025

Uh oh!

SerjKol80 commented Nov 12, 2025

Uh oh!

codecov bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SerjKol80 commented Nov 12, 2025

Uh oh!

lhy1024 commented Nov 13, 2025

Uh oh!

lhy1024 Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

SerjKol80 commented Nov 13, 2025

Uh oh!

SerjKol80 commented Nov 13, 2025

Uh oh!

Uh oh!

ti-chi-bot commented Dec 12, 2025

Uh oh!

ti-chi-bot commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SerjKol80 Nov 4, 2025 •

edited

Loading

SerjKol80 Nov 4, 2025 •

edited

Loading

codecov bot commented Nov 12, 2025 •

edited

Loading