-
Notifications
You must be signed in to change notification settings - Fork 753
statistics: delete cluster status metrics on store deletion #9945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s on store deletion Signed-off-by: okjiang <819421878@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9945 +/- ##
==========================================
+ Coverage 78.65% 78.67% +0.02%
==========================================
Files 495 495
Lines 66469 66475 +6
==========================================
+ Hits 52279 52301 +22
+ Misses 10398 10387 -11
+ Partials 3792 3787 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: okjiang <819421878@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
close tikv#9942 Signed-off-by: okjiang <819421878@qq.com>
|
@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created. DetailsIn response to adding label named type/cherry-pick-for-release-8.5. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#9942 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
close tikv#9942 Signed-off-by: okjiang <819421878@qq.com>
close tikv#9942 Signed-off-by: okjiang <819421878@qq.com>
close tikv#9942 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
close tikv#9942 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: Close #9942
What is changed and how does it work?
Due to adding
storelabel in #9898, we need to delete the related metrics on store deleting, otherwise it will retain forever.Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note