Skip to content

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Nov 19, 2025

What problem does this PR solve?

Issue Number: Close #9942

What is changed and how does it work?

Due to adding store label in #9898, we need to delete the related metrics on store deleting, otherwise it will retain forever.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. scale-in one tikv
  2. pd-ctl store remove-tombstone
img_v3_02s6_fb7a775b-307a-4faf-b493-4184098f657g

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

…s on store deletion

Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (4a11b99) to head (05d7b94).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9945      +/-   ##
==========================================
+ Coverage   78.65%   78.67%   +0.02%     
==========================================
  Files         495      495              
  Lines       66469    66475       +6     
==========================================
+ Hits        52279    52301      +22     
+ Misses      10398    10387      -11     
+ Partials     3792     3787       -5     
Flag Coverage Δ
unittests 78.67% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: okjiang <819421878@qq.com>
Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 21, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-21 08:09:30.042565038 +0000 UTC m=+258333.691759495: ☑️ agreed by rleungx.
  • 2025-11-21 08:10:47.950726763 +0000 UTC m=+258411.599921220: ☑️ agreed by bufferflies.

@okJiang
Copy link
Member Author

okJiang commented Nov 21, 2025

/retest

2 similar comments
@okJiang
Copy link
Member Author

okJiang commented Nov 21, 2025

/retest

@okJiang
Copy link
Member Author

okJiang commented Nov 21, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit c87b73a into tikv:master Nov 21, 2025
29 checks passed
JmPotato pushed a commit to JmPotato/pd that referenced this pull request Dec 3, 2025
@bufferflies bufferflies added type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 6, 2025
@ti-chi-bot ti-chi-bot bot removed the type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. label Dec 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-8.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 6, 2025
close tikv#9942

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #10009.
But this PR has conflicts, please resolve them!

okJiang added a commit to ti-chi-bot/pd that referenced this pull request Dec 12, 2025
okJiang added a commit to ti-chi-bot/pd that referenced this pull request Dec 15, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Dec 15, 2025
…10009)

close #9942

Signed-off-by: okjiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
@bufferflies bufferflies added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jan 23, 2026
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 23, 2026
close tikv#9942

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10188.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 23, 2026
close tikv#9942

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #10189.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tombstone hasn't been deleted after exec remove-tombstone successful

4 participants