Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Issue setting Slider's min if provided min is greater than the default max value. #2019

Closed
joshvanallen opened this issue Nov 6, 2019 · 0 comments · Fixed by #2073
Closed

Issue setting Slider's min if provided min is greater than the default max value. #2019

joshvanallen opened this issue Nov 6, 2019 · 0 comments · Fixed by #2073
Assignees
@trimox
Labels
bug
Milestone
v5.0.3

Comments

@joshvanallen
Copy link

joshvanallen commented Nov 6, 2019 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

When using the mdc-slider, there's a limitation for min if I want to make it greater than the default max value. For example: If I want to set the max to 1000 and the min to 500, the resulting min will be 0.

https://stackblitz.com/edit/angular-mdc-slider-minmax-issue

Expected behavior
A clear and concise description of what you expected to happen.
Should be set to min if the min is less than the max, otherwise the default min value.

What Angular MDC version are you using?
^3.2.1
rapropos added a commit to rapropos/angular-mdc-web that referenced this issue Nov 7, 2019
@rapropos
add minmax property to slider, addresses trimox#2019
a2046fe
@rapropos rapropos mentioned this issue Nov 7, 2019
Closed
@trimox trimox self-assigned this Feb 11, 2020
@trimox trimox added this to the v5.0.1 milestone Feb 11, 2020
@trimox trimox added the bug label Feb 11, 2020
@trimox trimox mentioned this issue Feb 11, 2020
Merged
@trimox trimox modified the milestones: v5.0.1, v5.0.2, v5.0.3 Feb 12, 2020
trimox added a commit that referenced this issue Feb 17, 2020
@trimox
fix(slider): Min and max values + improvements (#2073)
c8519ec 
- Allow custom ranged `min` and `max` values
- Add `valueChange(value: number)` event emitter
- Adds `tabIndex` property
- Mark as touched on `blur` event
- Improved slider examples

closes #2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trimox trimox

Labels
bug
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging a pull request may close this issue.

fix(slider): Ranged min/max values + improvements trimox/angular-mdc-web
2 participants
@joshvanallen @trimox