Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

fix(slider): Ranged min/max values + improvements #2073

Merged
merged 15 commits into from
Feb 17, 2020
Merged

Conversation

trimox
Copy link
Owner

@trimox trimox commented Feb 11, 2020

  • Allow custom min and max values
  • Add valueChange(value: number) event emitter
  • Mark as touched on blur event
  • Updated slider examples

closes #2019

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3595882). Click here to learn what that means.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2073   +/-   ##
=========================================
  Coverage          ?   90.06%           
=========================================
  Files             ?      100           
  Lines             ?     4309           
  Branches          ?      555           
=========================================
  Hits              ?     3881           
  Misses            ?      224           
  Partials          ?      204
Impacted Files Coverage Δ
packages/slider/slider.ts 91.66% <86.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3595882...4f5b0e8. Read the comment docs.

@trimox trimox added this to the v5.0.3 milestone Feb 16, 2020
@trimox trimox changed the title fix(slider): Should allow custom min/max values fix(slider): Ranged min/max values + improvements Feb 17, 2020
@trimox trimox merged commit c8519ec into master Feb 17, 2020
@trimox trimox deleted the fix/slider-range branch February 17, 2020 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue setting Slider's min if provided min is greater than the default max value.
1 participant