This repository was archived by the owner on Oct 7, 2020. It is now read-only.
feat(slider): add minmax property #2020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 97 97
Lines 4322 4322
Branches 586 586
=======================================
Hits 3908 3908
Misses 211 211
Partials 203 203Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address #2019.
There are probably ways to do this without adding an additional property binding, but I couldn't think of any that didn't add additional surprise. The fundamental problem seems to be that existing values are used for sanity checking on new ones, which setting them as a unit avoids.