Skip to content

Location: test IDNA behavior of origin #5939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annevk merged 1 commit into from
May 24, 2017
Merged

Location: test IDNA behavior of origin #5939

annevk merged 1 commit into from
May 24, 2017

Conversation

@annevk
Copy link
Member

@annevk annevk commented May 16, 2017 •
edited by wpt-pr-bot
Loading

@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham, zcorpan and zqzhang May 16, 2017 12:46
@annevk
Copy link
Member Author

annevk commented May 16, 2017

@jgraham this test is rather small and demonstrates my issue with the substitution feature rather clearly. You can use the feature to build up a URL, but this is a) somewhat cumbersome (you need to take care of scheme and port yourself if you want a custom domain) and b) buggy (the port bit doesn't work on w3c-test.org as it uses the default port).

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision f47581f
Using browser at version BuildID 20170516100213; SourceStamp 3e166b6838931b3933ca274331f9e0e115af5cc0
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html
Subtest Results Messages
OK
Test that location.origin returns ASCII FAIL assert_equals: expected "http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000" but got "http://天�����.web-platform.test:8000"

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision c8ce1b1
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html
Subtest Results Messages
TIMEOUT
Test that location.origin returns ASCII TIMEOUT Test timed out

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision c8ce1b1
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html
Subtest Results Messages
TIMEOUT

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision f47581f
Using browser at version 60.0.3095.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html
Subtest Results Messages
OK
Test that location.origin returns ASCII PASS

@annevk annevk mentioned this pull request May 17, 2017
Merged
annevk added a commit to whatwg/html that referenced this pull request May 18, 2017
@annevk
Remove Unicode serialization of an origin
59ebd9c 
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes #2568.
@zcorpan
Copy link
Member

zcorpan commented May 24, 2017

I restarted the Safari and Edge stability checker jobs since the results were TIMEOUT (but I didn't get a TIMEOUT in Safari locally).

@annevk annevk merged commit ec98b0d into master May 24, 2017
@annevk annevk deleted the annevk/location-origin-idna branch May 24, 2017 15:43
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@annevk
Remove Unicode serialization of an origin
d210af1 
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes whatwg#2568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zcorpan zcorpan zcorpan approved these changes

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

No one assigned

Labels

html

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annevk @zcorpan @wpt-pr-bot