self.origin: return IDNA in ASCII #5955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox (nightly)Testing web-platform-tests at revision c8bb4d2 All results1 test ran/html/dom/self-origin.sub.html
|
Sauce (safari)Testing web-platform-tests at revision c8bb4d2 All results1 test ran/html/dom/self-origin.sub.html
|
Sauce (MicrosoftEdge)Testing web-platform-tests at revision c8bb4d2 All results1 test ran/html/dom/self-origin.sub.html
|
Chrome (unstable)Testing web-platform-tests at revision c8bb4d2 All results1 test ran/html/dom/self-origin.sub.html
|
Member
|
The stability checker got TIMEOUT results for Edge and Safari. Is that new with this change? I don't get a TIMEOUT for /html/dom/self-origin.sub.html on master in Safari TP when testing locally. Otherwise the change LGTM. |
Member
Author
|
@zcorpan are you sure? It says everything is okay other than you not having used the review tool. |
Member
|
A TIMEOUT result does not fail the check, but it's still a TIMEOUT result. Expand the "all results" from @w3c-bots comments above. If the test status changed relate to master, it would be good to file bugs about that at least. |
zcorpan
approved these changes
May 17, 2017
Member
Author
|
I misunderstood. I'm not sure if this is new since when we checked this in initially these bots did not exist. @bobholt is this common with the new bots? |
Contributor
|
@annevk: This is the first time I've seen it. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 18, 2017
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes #2568.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes whatwg#2568.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#2568.