Skip to content

EventSource: IDNA origin should be in ASCII #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcorpan merged 1 commit into from
May 31, 2017
Merged

EventSource: IDNA origin should be in ASCII #5946

zcorpan merged 1 commit into from
May 31, 2017

Conversation

@annevk
Copy link
Member

@annevk annevk commented May 16, 2017 •
edited by wpt-pr-bot
Loading

@wpt-pr-bot wpt-pr-bot requested review from Yaffle, odinho and zqzhang May 16, 2017 16:38
@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 6da2eed
Using browser at version BuildID 20170516100213; SourceStamp 3e166b6838931b3933ca274331f9e0e115af5cc0
Starting 10 test iterations
All results were stable

All results

1 test ran
/eventsource/eventsource-cross-origin.htm
Subtest Results Messages
OK
EventSource: cross-origin basic use FAIL assert_equals: expected "http://xn--lve-6lad.web-platform.test:8000" but got "http://élève.web-platform.test:8000"
EventSource: cross-origin redirect use FAIL assert_equals: expected "http://xn--lve-6lad.web-platform.test:8000" but got "http://élève.web-platform.test:8000"
EventSource: cross-origin redirect use recon FAIL assert_equals: expected "http://xn--lve-6lad.web-platform.test:8000" but got "http://élève.web-platform.test:8000"
EventSource: cross-origin allow-origin: http://example.org should fail PASS
EventSource: cross-origin allow-origin:'' should fail PASS
EventSource: cross-origin No allow-origin should fail PASS

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 6da2eed
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran
/eventsource/eventsource-cross-origin.htm
Subtest Results Messages
TIMEOUT
EventSource: cross-origin basic use TIMEOUT Test timed out
EventSource: cross-origin redirect use TIMEOUT Test timed out
EventSource: cross-origin redirect use recon TIMEOUT Test timed out
EventSource: cross-origin allow-origin: http://example.org should fail PASS
EventSource: cross-origin allow-origin:'' should fail PASS
EventSource: cross-origin No allow-origin should fail PASS

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 6da2eed
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran
/eventsource/eventsource-cross-origin.htm
Subtest Results Messages
OK
EventSource: cross-origin basic use FAIL 'EventSource' is undefined
EventSource: cross-origin redirect use FAIL 'EventSource' is undefined
EventSource: cross-origin redirect use recon FAIL 'EventSource' is undefined
EventSource: cross-origin allow-origin: http://example.org should fail FAIL 'EventSource' is undefined
EventSource: cross-origin allow-origin:'' should fail FAIL 'EventSource' is undefined
EventSource: cross-origin No allow-origin should fail FAIL 'EventSource' is undefined

@ghost
Copy link

ghost commented May 16, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 6da2eed
Using browser at version 60.0.3095.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/eventsource/eventsource-cross-origin.htm
Subtest Results Messages
OK
EventSource: cross-origin basic use PASS
EventSource: cross-origin redirect use PASS
EventSource: cross-origin redirect use recon PASS
EventSource: cross-origin allow-origin: http://example.org should fail PASS
EventSource: cross-origin allow-origin:'' should fail PASS
EventSource: cross-origin No allow-origin should fail PASS

@annevk annevk mentioned this pull request May 17, 2017
Merged
annevk added a commit to whatwg/html that referenced this pull request May 18, 2017
@annevk
Remove Unicode serialization of an origin
59ebd9c 
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes #2568.
@annevk annevk requested a review from zcorpan May 18, 2017 05:45
@zcorpan zcorpan merged commit 892ccbf into master May 31, 2017
@zcorpan zcorpan deleted the annevk/eventsource-origin-idna branch May 31, 2017 07:34
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@annevk
Remove Unicode serialization of an origin
d210af1 
And rename “ASCII serialization of an origin” to “serialization of an
origin” though allow both to be used.

Not all implementations implemented the Unicode variant and the ones
that did, did so in a way that made it hard to use.

Tests:

* web-platform-tests/wpt#5939
* web-platform-tests/wpt#5940
* web-platform-tests/wpt#5941
* web-platform-tests/wpt#5944
* web-platform-tests/wpt#5946
* web-platform-tests/wpt#5955
* web-platform-tests/wpt#5957
* web-platform-tests/wpt#5958

URL Standard change: whatwg/url#311.

Service Worker specification follow-up issue: w3c/ServiceWorker#1142.

Fixes whatwg#2568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zcorpan zcorpan zcorpan approved these changes

@Yaffle Yaffle Awaiting requested review from Yaffle

@odinho odinho Awaiting requested review from odinho

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

No one assigned

Labels

eventsource wg-webapps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annevk @zcorpan @wpt-pr-bot