Take Development to Master for next release #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ast in UseToExportFieldsInManifest.
Fixes to UseToExportFieldsInManifest rule.
Instead of using ast.extent property for comparing empty string or null argument we use the parsed values.
…eAttribute Fixes to AvoidNullOrEmptyHelpMessageAttribute.
…applicable for PSVersions > 5.0.
Fix a custom rule path bug that prevented loading rules with version in their path.
Add conditions to check if indexing does not take place on a null valued Value property. If a PowerShell based custom rule does't have comment based help, the engine throws an error. This occurs because the lack of comment based help results in a null value for the Value property of the dynamically typed description variable.
Changes the AppVeyor os image to WMF 5
Fix loading custom rules that do not have comment help
Modifies error messages of AvoidUsernameAndPasswordParams and UsePSCredentialType rules.
…PlainText rule. The severity showed by Get-ScriptAnalyzerRule and Invoke-ScriptAnalyzer for this rule were different. This was because scriptanalyzer defines two types of severities, viz., RuleSeverity and DiagnosticSeverity and the severity levels were not consistent. This commit makes the severity level consistent by setting them both to Warning.
Fix severity inconsistency in AvoidUsingConvertToSecureStringWithPlainText and UseIdenticalParametersDSC
Re merge into my branch
We need this capability in the PowerShell extension for VSCode to enable it to use an external settings file. This will allow users of the extension to be able to customize the default settings.
…es-profile Updates the Initialize method to process the profile parameter.
Filters the rules based on their severity before passing them the AST for analysis. Prior to the fix, the severity filter was applied on diagnostic records. This was inefficient as Invoke-ScriptAnalyzer would run all the rules irrespective of the given severity and then filter the diagnostic records to extract the results that corresponded to the given severity.
Fix for hang issue
Rules are filtered prior to creating tasks (threads). This avoids creating unnecessary tasks as opposed to the earlier approach where rule invocation was decided within their corresponding tasks.
Fixes scope name comparison. Fixes #473
…tyFilter Fix severity filtering while invoking script analyzer
|
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 21 of 22 files at r3, 3 of 3 files at r8. Comments from the review on Reviewable.io |
|
Review status: Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
Does this include @rkeithhill's latest PR? It'd be ideal if that was included in the next release. |
|
Whoops, ignore that comment, I just saw that it's in there :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is