fix(control_evaluator, planning_evaluator): fix goal-related metrics calculation#11337
Merged
xtk8532704 merged 2 commits intoautowarefoundation:mainfrom Sep 9, 2025
Merged
Conversation
xtk8532704
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
maxime-clem and
takayuki5168
as code owners
github-actions
bot
added
type:ci
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xtk8532704
force-pushed
the
fix-goal-metric-bug
branch
from
93068a7 to
c80bb50
Compare
Signed-off-by: xtk8532704 <1041084556@qq.com>
Signed-off-by: xtk8532704 <1041084556@qq.com>
github-actions
bot
removed
the
type:ci
xtk8532704
force-pushed
the
fix-goal-metric-bug
branch
from
c80bb50 to
0f6e5f5
Compare
xtk8532704
added
the
run:build-and-test-differential
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11337 +/- ##
==========================================
+ Coverage 20.19% 20.36% +0.16%
==========================================
Files 1571 1574 +3
Lines 112908 113189 +281
Branches 36658 36721 +63
==========================================
+ Hits 22800 23046 +246
- Misses 72588 72850 +262
+ Partials 17520 17293 -227
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kosuke55
approved these changes
Sep 9, 2025
github-project-automation
bot
moved this from To Triage
to Done
in Software Working Group
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 30, 2025
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com> Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
xtk8532704
added a commit
to tier4/autoware_universe
that referenced
this pull request
Dec 26, 2025
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com>
xtk8532704
added a commit
to tier4/autoware_universe
that referenced
this pull request
Jan 16, 2026
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com>
xtk8532704
added a commit
to tier4/autoware_universe
that referenced
this pull request
Jan 16, 2026
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com> Signed-off-by: Kem (TiankuiXian) <temkei.kem@tier4.jp>
xtk8532704
added a commit
to tier4/autoware_universe
that referenced
this pull request
Jan 26, 2026
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com> Signed-off-by: Kem (TiankuiXian) <temkei.kem@tier4.jp>
mkquda
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Mar 16, 2026
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com>
xtk8532704
added a commit
to tier4/autoware_universe
that referenced
this pull request
Apr 10, 2026
…calculation (autowarefoundation#11337) * fix stop condition Signed-off-by: xtk8532704 <1041084556@qq.com> * fix include Signed-off-by: xtk8532704 <1041084556@qq.com> --------- Signed-off-by: xtk8532704 <1041084556@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The original design of goal-related metrics was intended to measure only where the Ego stopped within 3 meters of the goal_pose.
However, in the original implementation, the longitudinal distance was used incorrectly. This PR modifies it to use the Euler distance instead.
Related links
Parent Issue:
How was this PR tested?
Evaluator
The statistics are now back to normal:
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.