Skip to content

Upstream pull + Handle no categories #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 202 commits into from
Closed

Upstream pull + Handle no categories #5

wants to merge 202 commits into from

Conversation

antazoey
Copy link

@antazoey antazoey commented Jun 23, 2020 •
edited
Loading

  • Pull upstream master
  • Fix bug in fetch where if there are no significant file categories, it would add an empty filter list and 400

I left comments on the two areas of change that are from me

roysagi and others added 30 commits June 8, 2020 23:41
@roysagi @bakatzir
Content additional fix validations (demisto#7445)
41dfbc7 
* Content additional fix validations

* updating gmail docker image

* Update Packs/Digital_Defense_FrontlineVM/Playbooks/playbook-Digital_Defense_FrontlineVM_-_PAN-OS_block_assets.yml

Co-authored-by: Bar Katzir <[email protected]>

* adding changelogs

Co-authored-by: Bar Katzir <[email protected]>
@jochman
fix lintings (demisto#7454)
cb1cf92
@hod-alpert
Improved empty response handling (demisto#7296)
7301211 
Co-authored-by: halpert <[email protected]>
@altmannyarden @yaron-libman
[Enhancement] Search Search Endpoints By Hash - Carbon Black Response (…
33a6d98 
…demisto#7399)

* Deprecated Search Search Endpoints By Hash - Carbon Black Response.
Created new playbook Search Search Endpoints By Hash - Carbon Black Response V2 instead.

* added the playbook image.

* added the playbook image.

* Updated playbook image

* Update playbook-Search_Endpoints_By_Hash_-_Carbon_Black_Response_V2.yml

* Update playbook-Search_Endpoints_By_Hash_-_Generic_V2.yml

* Update playbook-Hunt_Extracted_Hashes.yml

* Update playbook-Search_Endpoints_By_Hash_-_Carbon_Black_Response.yml

* updated release notes

Co-authored-by: yaron-libman <[email protected]>
@guyfreund
out of skipped tests (demisto#7456)
addd165 
* out of skipped

* parse email files out of skipped
@orhovy
Auto detect api modules (demisto#7257)
9078198 
* changed docker image

* changed docker image

* changed docker image

* changed docker image

* changed docker image

* updated conf json for nightly tests on generic feeds

* updated None to ''

* updated None to ''

* updated conf json

* updated conf json

* updated conf json

* updated conf json

* updated rn

* updated rn

* updated pr

* updated pr

* fixed json ut

* fixed json ut

* fixed json ut

* fixed json ut

* updated pr

* updated pr

* updated pr

* updated pr

* updated pr

Co-authored-by: yorhov <Orekhova97229!>
@roysagi
small fix in content (demisto#7462)
4ba778c
@roysagi
unskipping phishlabs (demisto#7455)
6310edb 
* unskipping phishlabs

* fixing test playbook
@jochman @roysagi
RTIR: fix ID header bug (demisto#7453)
17bdd88 
* RTIR: Fix ID header

* fix lint and format

* fix flake8

* added rns

* fix cr

* Update 1_0_2.md

Co-authored-by: roysagi <[email protected]>
@guyfreund @kirbles19
fortisiem bug fix (demisto#7469)
9df8ad4 
* disabled the request to trigger an event, made queryData hardcoded

* changelog

* Updated.

* Updated

* Updated

Co-authored-by: Alex Fiedler <[email protected]>
@anara123 @reutshal
remove old regexes from content (demisto#7398)
a54d552 
* remove old regexes from content

* use demisto-sdk from master

* Update dev-requirements-py3.txt

Co-authored-by: reut shalem <[email protected]>

* Update dev-requirements-py3.txt

* replace old regexes

* sdk release 1-1-2 test

* sdk release 1-1-2 test

* sdk release 1-1-2 test

* sdk release 1-1-2

Co-authored-by: reut shalem <[email protected]>
Co-authored-by: rshalem <[email protected]>
@roysagi
changing playbook name (demisto#7474)
3493acf 
* changing playbook name

* changing playbook name
@yuvalbenshalom
fix rastarize name in core packs list (demisto#7471)
80d8916
@dantavori @anara123
@reutshal @yuvalbenshalom @yaakovi
Nightly Marketplace (demisto#7467)
8c5354d 
* remove old regexes from content

* use demisto-sdk from master

* Update dev-requirements-py3.txt

Co-authored-by: reut shalem <[email protected]>

* Update dev-requirements-py3.txt

* replace old regexes

* use sdk master

* conflicts fix

* changed sdk branch

* changed sdk branch to master

* fixed config.yml, added developerTools pack to packs_to_install

* reduced flake8 version

* moved test playbooks to packs

* removed Extract Indicators From File - test from conf.json

* reverted changes in collect_tests and dev-requirements-py3

Co-authored-by: Anar Azadaliyev <[email protected]>
Co-authored-by: reut shalem <[email protected]>
Co-authored-by: ybenshalom <[email protected]>
Co-authored-by: Shai Yaakovi <[email protected]>
@jochman
bump content and sha1 versions (demisto#7470)
a4cba0c
@yaakovi
reverted instance tests to run on server 5.5 (demisto#7465)
9c62506
@jochman
Return of cofense feed (demisto#7481)
32a8e49
@yaakovi @glicht
Updated Cortex XDR IOCs pack names - 20.6.0 (demisto#7437) (demisto#7457
2c6c1fc 
)

* Updated Cortex XDR IOCs pack names - 20.6.0 (demisto#7437)

* updated pack name, integration name, and command names of "Cortex XDR - IOC"

* fixed bug

* update tests

* update pack & integration description

* update pack & integration description

* updated descriptions

* update integration format

* fixup! update integration format

* adding ioc triger to push command

* update README

* fix CR

* fixup! fix CR

* Update Packs/XDR_iocs/Integrations/XDR_iocs/XDR_iocs.yml

Co-authored-by: Shai Yaakovi <[email protected]>

* Apply suggestions from code review

Co-authored-by: Guy Lichtman <[email protected]>

* update readme with a better description

* updated descriptions and display name in yml

* Update Packs/XDR_iocs/Integrations/XDR_iocs/XDR_iocs.yml

* Update Packs/XDR_iocs/Integrations/XDR_iocs/XDR_iocs.yml

* Apply suggestions from technical writer review

* fix

* fixup! fix

* fixinig

* last fix

* add sleep time

* add sleep time

Co-authored-by: eli sharf <[email protected]>
Co-authored-by: esharf <[email protected]>
Co-authored-by: Guy Lichtman <[email protected]>

* adding empty release notes

* Update CHANGELOG.md

Co-authored-by: Shai Yaakovi <[email protected]>
Co-authored-by: esharf <[email protected]>
Co-authored-by: Guy Lichtman <[email protected]>
@IkaDemisto
deleted Legacy pack (demisto#7463)
fea875b
@liorblob
Delete Exchange pack (demisto#7433)
0230fd2
@amshamah419 @kirbles19
Add the GetShiftsPerUser automation (demisto#7213)
2ee8e6d 
* Add the GetShiftsPerUser automation

* Add current user to script and fix bad check for GetOnCallHoursPerUser

* Style guides

* Remove unusedimports

* Remove used vars

* Add a better output type

* Fix imports

* Release notes of bug in GetOnCallHoursPerUser

* Fix the tests

* Fix the eslint lines too long

* Fix eslint changelog

* release notes

* docker tags

* Fix the output

* Add related tests

* Add header for the markdown

* Update Packs/ShiftManagement/ReleaseNotes/1_1_0.md

Co-authored-by: Andrew Shamah <[email protected]>

* Eslint

* Shifts per user

* Trailing whitespace

* RN

* Docker version

* Tests + imports

* Debug tests

* Debug tests 2

* Debug tests 3

* Debug 4

* Debug 5

* Debug 6

* Debug 7

* Debug 8

* Debug 9

* Debug 10

* Debug 12

* Fix mock result

* Fix mock result

* linting

* Flake8

* Updated

* Updated.

Co-authored-by: Agam More <[email protected]>
Co-authored-by: Andrew Shamah <[email protected]>
Co-authored-by: Alex Fiedler <[email protected]>
@yaakovi
ignore missing CHANGELOG failures (demisto#7482)
52371f9 
* Update config.yml

* Update config.yml
@jochman
demistomock.py formatting (demisto#7483)
453d71a
@hod-alpert
Fixed print when GCS_MARKET_KEY is not set (demisto#7486)
f6c79ee 
* Fixed print when GCS_MARKET_KEY is not set

* Skipping a step in contribution

Co-authored-by: halpert <[email protected]>
@IkaDemisto
fixed build images paths (demisto#7450)
900b38a
@IkaDemisto
Packs changelog - added build number to display name (demisto#7279)
f6599b0 
* added build number to pack changelog

* switched brackets to dash in changelog version

* added versionInfo field

* fixed doc strings

* added versionInfo to unit test
@ShahafBenYakir
Nightly failures (demisto#7317)
97698ab 
* Skipped nightly failures

* Un-skipped infoblox

* Skipped tonight's failing tests

* Skipping failing tests

* Skipping failing tests

* Skipped traps

* Skipped traps

* Added timeout to "Digital Defense FrontlineVM - Scan Asset Not Recently Scanned Test

* Skipped Digital Defense FrontlineVM - Scan Asset Not Recently Scanned Test

* Skipped Digital Defense FrontlineVM - Scan Asset Not Recently Scanned Test

* Skipped Test - Cofense Intelligence

* Skipped Test - Cofense Intelligence
@yaakovi
Update XDR_iocs.yml (demisto#7494)
8c85884
@IkaDemisto
Uploader - changed upload corepacks.json logic (demisto#7487)
af2259c 
* changed upload corepacks.json logic

* added sys.exit(1) in case of failure
@idovandijk @amshamah419
Updated video link for Crisus Management (demisto#7496)
246f7d2 
* Updated video link

* moved video to pack readme

* http = https

* fix RNs

Co-authored-by: Andrew Shamah <[email protected]>
guyfreund and others added 18 commits June 22, 2020 10:58
@guyfreund @kirbles19 @ShahafBenYakir
Detonate File Lastline v2 bugfix (demisto#7580)
ab23bf0 
* bug fix

* Updated.

* update circle config

Co-authored-by: Alex Fiedler <[email protected]>
Co-authored-by: ShahafBenYakir <[email protected]>
@amshamah419
Sane doc reports (demisto#7641)
02baf24 
* Updating sane doc + add logo

* Updating sane doc tag

* Bump version, add RNs

Co-authored-by: Agam More <[email protected]>
Co-authored-by: Andrew Shamah <[email protected]>
@amshamah419
Update sane-pdf-reports docker tag - bug fixes (demisto#7660)
49a67b2 
* Update release notes

* Bump version, add RNs

Co-authored-by: Agam More <[email protected]>
Co-authored-by: Andrew Shamah <[email protected]>
@orlichter1
Cofense Inteligence - Unskip test (demisto#7649)
4961e21 
* try to restore

* change indicators

* secrets ignore
@barchen1
Fix microsoft test playbook (demisto#7656)
d8cfe68 
* add 3 retries to every task in test playbook
@DeanArbel @kirbles19
EWS O365 expanded changelog (demisto#7686)
45498d5 
* enhanced changelog

* Updated

Co-authored-by: Alex Fiedler <[email protected]>
@mayagoldb
Release notes for cortex XDR new playbooks (demisto#7690)
0373428
@bakatzir @liorblob
snow v2 - Fixed the test button to work with debug mode (demisto#7694)
a2a8c66 
* snow v2 - Fixed the test button to work with debug mode

* Update Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2.py

Co-authored-by: Lior Blobstein <[email protected]>

* mypy 101

* mypy 102

* import as

Co-authored-by: Lior Blobstein <[email protected]>
@jochman
fixed f string (demisto#7699)
99b1094
@ronykoz
Fix configure instances fromversion compare (demisto#7282)
ddaf597 
* Fix Configure instances

* testing the fix

* Update configure_and_test_integration_instances.py

* update installation condition check

* fix lint

* Update FeedMicrosoftIntune.yml
@content-bot @ayman-m
@aymansm @yaakovi
NozomiGuardian Integration Same As Closed PR demisto#7112 (demisto#7701)
02f1f59 
* Initial Commit (demisto#7529)

Co-authored-by: Ayman <[email protected]>

* fixed missing description and wrong version

* fixed descriptions suggested by tech writer

* updated docker image

* skip integration - no instance

Co-authored-by: Ayman Mahmoud <[email protected]>
Co-authored-by: Ayman <[email protected]>
Co-authored-by: syaakovi <[email protected]>
@dantavori @yaakovi
New RN summary (demisto#7133)
2a4d34e 
* in progress

* in progress

* in progress

* in progress

* in progress

* in progress

* in progress

* in progress

* changed RN file name

* added comments

* test in progress

* updated script

* updated script

* updated script

* test fix helloworld

* in progress

* in progress

* in progress

* in progress

* in progress

* in progress

* in progress

* added test

* fix

* fixed doc

* in progress

* updated new release notes generator

* in progress

* in progress

* in progress

* in progress

* fixed ignored release notes validations and added tests

* small fixes

* restored .gitignore

* added new packs to release notes generator

* fixed unit tests

* fixed lint error

* fixed lint error

* fixed modified packs collection

* Fixed handling of ignored section in RN files

* fixed modified release notes filter

* start merging pack versions block to single block

* added support for merging pack versions block to single block

* added unit test for merge release notes block function

* fixed small formatting issue

* fixed CR notes

* fixed content-descriptor.json path

* fixed time formats in content-descriptor.json

Co-authored-by: syaakovi <[email protected]>
@content-bot @DctrG @bakatzir
Microsoft azure feed (demisto#7715)
e38741e 
* Microsoft azure feed (demisto#7410)

* Add pack Azure AD Connect Health Feed

* Clean up

* Passed all tests

* Fix test playbook

* Minor fixes

* Minor changes

* remove changelog

* change integration name global

* include integration name in demisto.info

* add docstring to substitution function

* add disclaimer to readme

* remove the other changelog

* add command_examples.txt and generate readme with demisto-sdk

* remove entries in tests/conf.json

* remove urls from readme as it fails secrets test

* remove trailing space

* add entries back to conf.json as it fails pre-commit otherwise

* remove exept blocks and apply suggestion to subs function

* add suggested changes

* Fix issue with results dict

* changes to avoid duplicated indicators

* remove substitution function as it's not deded

Co-authored-by: Bar Katzir <[email protected]>

* chnge taskid task.id TO UUIDS

Co-authored-by: Guillermo Serrano <[email protected]>
Co-authored-by: Bar Katzir <[email protected]>
Co-authored-by: bar katzir <[email protected]>
@Bargenish @yaakovi @kirbles19
Workday (demisto#7478)
c1f3a27 
* creating workday pack

* Worker context build function

* Integration Ready but README.md, fine-tuning on unitests and TPB

* Added Unittests and README.md

* * Removed "Business_Title" from headers
* Changed `Phone Number` field source. (and changed expected context accordingly)
* Changed Test_module output
* Changed username and password params to credentials type. in Workday.yml
* Changed TPB according to Shai's review in Workday_-_Test.yml
* Added TPB details to conf.json

Co-authored-by: Shai Yaakovi <[email protected]>

* Update Packs/Workday/Integrations/Workday/Workday.py

Co-authored-by: Shai Yaakovi <[email protected]>

* Changed verion in README.md

* CR Changes

* Secrets

* Updated

* CR changes
Added Workday TPB to skipped tests (lack of access)

* Update docker image

Co-authored-by: Shai Yaakovi <[email protected]>
Co-authored-by: Alex Fiedler <[email protected]>
@bakatzir
pan-os-edl-docs1 (demisto#7510)
945f777
@amshamah419
Revert base fix (demisto#7717)
c9cd88c 
* revert 1.0.11 and 1.0.12 versions in Base pack by issuing version 1.0.13
skiping XDR iocs test (demisto#7719)
0f628b5 
Co-authored-by: esharf <[email protected]>
Test
e67c091
antazoey
antazoey commented Jun 23, 2020
View reviewed changes
Packs/Code42/Integrations/Code42/Code42.py
@@ -411,7 +411,8 @@ def _create_file_category_filters(self):
"""Determine if file categorization is significant"""
observed_file_categories = self._observation_data["fileCategories"]
categories = [c["category"].upper() for c in observed_file_categories if c["isSignificant"]]
return FileCategory.is_in(categories)
if categories:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change from me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a test too

antazoey
antazoey commented Jun 23, 2020
View reviewed changes
Packs/Code42/Integrations/Code42/Code42_test.py
@@ -1239,6 +1239,25 @@ def test_fetch_incidents_handles_multi_severity(code42_fetch_incidents_mock):
assert "LOW" in str(code42_fetch_incidents_mock.alerts.search.call_args[0][0])


def test_fetch_when_no_significant_file_categories_ignores_filter(code42_fetch_incidents_mock, mocker):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the test

@antazoey antazoey changed the title Test Upstream pull + Handle no categories Jun 23, 2020
@antazoey antazoey closed this Jun 23, 2020
@antazoey antazoey deleted the bugfix/fix-fetch-and-catchup branch June 23, 2020 16:56
jdullum pushed a commit that referenced this pull request Oct 12, 2023
@darkushin
Private upload mode docs #5 (demisto#28700)
c4c150c 
* Updated Docs

* added RNs

* Bump pack from version SymantecBlueCoatMalwareAnalysis to 1.0.9.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.32.

* Updated RNs

---------

Co-authored-by: Content Bot <[email protected]>
ceciliastevens pushed a commit that referenced this pull request Dec 4, 2024
@inbalapt1 @content-bot
Aud demisto/auto update docker staging branch 40 (demisto#37147)
2802f4e 
* Updated docker image to demisto/python3:3.11.10.115186. PR batch #2/5 (demisto#37137)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.115186. PR batch #1/5 (demisto#37136)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.115186. PR batch #5/5 (demisto#37140)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.115186. PR batch #3/5 (demisto#37138)

Co-authored-by: root <root@1e2de18e0cc3>
Co-authored-by: inbalapt1 <[email protected]>

* demisto/python3:3.11.10.115186 | 70-100 | PR batch #4/5 (demisto#37139)

* Updated docker image to demisto/python3:3.11.10.115186. PR batch #4/5

* Update CortexXDRIR.yml

* Update XQLQueryingEngine.yml

* Update PaloAltoNetworksAIOps.yml

---------

Co-authored-by: root <root@1e2de18e0cc3>
Co-authored-by: inbalapt1 <[email protected]>

* update release-notes

* Bump pack from version CommonScripts to 1.15.88.

* Bump pack from version SplunkPy to 3.1.44.

* Bump pack from version Phishing to 3.6.27.

* Bump pack from version CortexXDR to 6.1.89.

---------

Co-authored-by: content-bot <[email protected]>
Co-authored-by: root <root@1e2de18e0cc3>
Co-authored-by: Content Bot <[email protected]>
ceciliastevens pushed a commit that referenced this pull request Dec 4, 2024
@inbalapt1 @content-bot
Aud demisto/auto update docker staging branch 69 (demisto#37407)
8d03ff2 
* Updated docker image to demisto/python3:3.11.10.116949. PR batch #1/5 (demisto#37402)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.116949. PR batch #2/5 (demisto#37403)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.116949. PR batch #4/5 (demisto#37405)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.116949. PR batch #5/5 (demisto#37406)

Co-authored-by: root <root@1e2de18e0cc3>

* Updated docker image to demisto/python3:3.11.10.116949. PR batch #3/5 (demisto#37404)

Co-authored-by: root <root@1e2de18e0cc3>

* update to 3.11.10.115186

* remove issues

* utc

* remove

* remove

* update release notes

* update

* Bump pack from version Okta to 3.3.8.

* remove mailsendernew

* remove core

* update release notes

* Bump pack from version Palo_Alto_Networks_Enterprise_DLP to 2.0.13.

* Bump pack from version Okta to 3.3.9.

* Bump pack from version AzureSentinel to 1.5.54.

* Bump pack from version PaloAltoNetworks_Threat_Vault to 2.0.15.

---------

Co-authored-by: content-bot <[email protected]>
Co-authored-by: root <root@1e2de18e0cc3>
Co-authored-by: Content Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanag13 alanag13 Awaiting requested review from alanag13

@kiran-chaudhary kiran-chaudhary Awaiting requested review from kiran-chaudhary

@timabrmsn timabrmsn Awaiting requested review from timabrmsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.