Merged
Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Closed
Codecov Report
@@ Coverage Diff @@
## ign-sensors3 #82 +/- ##
=============================================
Coverage 77.54% 77.54%
=============================================
Files 23 23
Lines 2298 2298
=============================================
Hits 1782 1782
Misses 516 516 Continue to review full report at Codecov.
|
added 2 commits
January 20, 2021 09:19
Signed-off-by: John Shepherd <john@openrobotics.org>
chapulina
approved these changes
Jan 21, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
I know this wasn't the goal of this PR, but I'll just point out that we're missing macOS installation instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargeting #71 to Citadel