FIX: URL sanitization to handle schemeless credentials by bircni · Pull Request #37440 · go-gitea/gitea

bircni · 2026-04-26T17:35:22Z

Fixes #37435

… logging output

wxiaoguang · 2026-04-26T18:02:40Z

Theoretically speaking, if you have introduced the new regexp, then you don't need to keep the old algorithm

bircni · 2026-04-26T18:05:02Z

Theoretically speaking, if you have introduced the new regexp, then you don't need to keep the old algorithm

yep just had a look at it again and that also makes it easier

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

bircni · 2026-04-26T20:55:43Z

@silverwind why you remove the % ??

silverwind · 2026-04-26T20:58:31Z

Because it was duplicate in the [] character set and therefor no-op. [%%] matches the same things as [%], e.g. a single % character.

wxiaoguang · 2026-04-26T21:09:09Z

Found some edge cases, I think regexp is not easy to be right. Will try to improve.

Copilot

Pull request overview

This PR addresses credential exposure risks by improving URL/userinfo sanitization so that credential-like substrings (including schemeless user:token@host forms seen in git stderr) are masked before being surfaced in logs/UI errors.

Changes:

Sanitize repo.CloneURL before logging during repository migration.
Rework util.SanitizeCredentialURLs to mask schemeless credential patterns and update the masking placeholder.
Update/add unit tests and expand git command log sanitization coverage for schemeless a:b@c patterns.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`services/migrations/migrate.go`	Sanitizes the clone URL before trace logging during migration.
`modules/util/sanitize.go`	Updates sanitization logic to catch schemeless credential patterns and standardizes the placeholder.
`modules/util/sanitize_test.go`	Adjusts/adds test cases for the updated sanitization behavior.
`modules/git/gitcmd/command.go`	Ensures arguments are passed through the sanitization routine when building debug log strings.
`modules/git/gitcmd/command_test.go`	Updates expectations for the new placeholder and adds coverage for schemeless `a:b@c/`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Consume "[...]" IP-literals as a single host token. The previous switch arms for `[`/`]` were dead: at `sepAtPos+1` the `[` fell through, and the next `:` broke the host loop. Output looked correct only because the unparsed tail was appended verbatim. - Replace the fast path's `sepColPos > sepAtPos` check (which used only the first `@` and `:`) with an existence test on both. Lines containing a `git@host:path` SSH URL followed by a credential URL were skipped. - Add tests for `[2001:db8::1]:8080`, multi-URL with `[::1]`, unmatched `[`, and SSH-URL-then-HTTPS. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-28T02:22:18Z

@wxiaoguang check 69003ad please.

@bircni

Backport #37440 by @bircni Fixes #37435 Co-authored-by: Nicolas <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

* main: Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465) Fix compare dropdown for branches without common history (go-gitea#37470) FIX: URL sanitization to handle schemeless credentials (go-gitea#37440) Refactor pull request view (4) (go-gitea#37451) Fix scheduled action panic with null event payload (go-gitea#37459) Fix attachment Content-Security-Policy (go-gitea#37455) [skip ci] Updated translations via Crowdin Rename CurrentRefPath to CurrentRefSubURL (go-gitea#37453) Clean up org pages layout (go-gitea#37445) Fix script error alert (go-gitea#37458) Fix inconsistent disabled styling on logged-out repo header buttons (go-gitea#37406) Add API endpoint to reply to pull request review comments (go-gitea#36683) Add CurrentURL template variable back (go-gitea#37444)

* origin/main: Refactor CI workflows (go-gitea#37487) Allow multiple projects per issue and pull requests (go-gitea#36784) [skip ci] Updated translations via Crowdin Refactor compare diff/pull page (1) (go-gitea#37481) Fix review submission from single-commit PR view (go-gitea#37475) Refactor integration tests infrastructure (go-gitea#37462) Fix allow maintainer edit permission check (go-gitea#37479) Serve OpenAPI 3.0 spec at /openapi.v1.json (go-gitea#37038) Batch-load related data in actions run, job, and task API endpoints (go-gitea#37032) Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465) Fix compare dropdown for branches without common history (go-gitea#37470) FIX: URL sanitization to handle schemeless credentials (go-gitea#37440) Refactor pull request view (4) (go-gitea#37451) # Conflicts: # modules/indexer/issues/elasticsearch/elasticsearch.go

Fixes go-gitea#37435 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit fedc9dc)

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [code.gitea.io/gitea](https://github.com/go-gitea/gitea) | `v1.26.1` → `v1.26.2` | ![age](https://developer.mend.io/api/mc/badges/age/go/code.gitea.io%2fgitea/v1.26.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/code.gitea.io%2fgitea/v1.26.1/v1.26.2?slim=true) | --- ### Release Notes <details> <summary>go-gitea/gitea (code.gitea.io/gitea)</summary> ### [`v1.26.2`](https://github.com/go-gitea/gitea/releases/tag/v1.26.2) [Compare Source](go-gitea/gitea@v1.26.1...v1.26.2) - SECURITY - fix(permissions): Fix reading permission ([#37769](go-gitea/gitea#37769)) - fix(actions): make artifact signature payloads unambiguous ([#37707](go-gitea/gitea#37707)) - fix: Unify public-only token filtering in API queries and repo access checks ([#37118](go-gitea/gitea#37118)) - fix: Add missed token scope checking ([#37735](go-gitea/gitea#37735)) - fix(oauth): bind token exchanges to the original client request ([#37704](go-gitea/gitea#37704)) - fix(oauth): strengthen PKCE validation and refresh token replay protection ([#37706](go-gitea/gitea#37706)) - fix(web): enforce token scopes on raw, media, and attachment downloads ([#37698](go-gitea/gitea#37698)) - fix(security): enforce wiki git writes and LFS token access at request time ([#37695](go-gitea/gitea#37695)) - feat(api): encrypt AWS creds ([#37679](go-gitea/gitea#37679)) - fix(deps): update dependency mermaid to v11.15.0 \[security], add e2e test - fix(packages): Add label for private and internal package and fix composor package source permission check ([#37610](go-gitea/gitea#37610)) - fix(git): Fix smart http request scope bug ([#37583](go-gitea/gitea#37583)) - Fix basic auth bug ([#37503](go-gitea/gitea#37503)) - Fix allow maintainer edit permission check ([#37479](go-gitea/gitea#37479)) ([#37484](go-gitea/gitea#37484)) - Fix URL sanitization to handle schemeless credentials ([#37440](go-gitea/gitea#37440)) ([#37471](go-gitea/gitea#37471)) - Fix attachment Content-Security-Policy ([#37455](go-gitea/gitea#37455)) ([#37464](go-gitea/gitea#37464)) - chore(deps): bump go-git/go-git/v5 to 5.19.0 ([#37608](go-gitea/gitea#37608)) - BUGFIXES - fix(pull): handle empty pull request files view to allow reviews ([#37783](go-gitea/gitea#37783)) - fix(markup): make RenderString never fail ([#37779](go-gitea/gitea#37779)) - fix: add natural sort to sortTreeViewNodes ([#37772](go-gitea/gitea#37772)) - fix: package creation unique conflict ([#37774](go-gitea/gitea#37774)) - fix!: add DEFAULT\_TITLE\_SOURCE setting for pull request title default behavior ([#37465](go-gitea/gitea#37465)) - fix: Allow direct commits for unprotected files with push restrictions ([#37657](go-gitea/gitea#37657)) - fix(actions): wrong assumption that run id always >= job id ([#37737](go-gitea/gitea#37737)) - fix(auth): set User-Agent on avatar fetch and sync avatar on link-account register ([#37564](go-gitea/gitea#37564)) ([#37588](go-gitea/gitea#37588)) - fix(actions): deadlock between PrepareRunAndInsert and UpdateTaskByState ([#37692](go-gitea/gitea#37692)) - fix(repo): /generate must sync the branch table for the new repo ([#37693](go-gitea/gitea#37693)) - build: Fix snap build (1.26) - fix(actions): run TransferLogs on UpdateLog{Rows:\[], NoMore:true} ([#37631](go-gitea/gitea#37631)) - fix show correct mergebase - fix: make clone URL respect public URL detection setting ([#37615](go-gitea/gitea#37615)) - fix: "run as root" check ([#37622](go-gitea/gitea#37622)) - chore(deps): update dependency go to v1.26.3 ([#37601](go-gitea/gitea#37601)) - Compare dropdown fails when selecting branch with no common merge-base ([#37470](go-gitea/gitea#37470)) - fix: treat email addresses case-insensitively ([#37600](go-gitea/gitea#37600)) - fix(actions): fix blank lines after ::endgroup:: ([#37597](go-gitea/gitea#37597)) - fix(actions): report individual step status in workflow job API response ([#37592](go-gitea/gitea#37592)) - fix: Invalid UTF-8 commit messages in JSON API responses ([#37542](go-gitea/gitea#37542)) - fix: use consistent GetUser family functions ([#37553](go-gitea/gitea#37553)) - fix(api): return 409 message instead of empty JSON for wrong commit id ([#37572](go-gitea/gitea#37572)) - fix(actions): prevent panic when workflow contains null jobs ([#37570](go-gitea/gitea#37570)) - Make ServeSetHeaders default to download attachment if filename exists ([#37552](go-gitea/gitea#37552)) ([#37555](go-gitea/gitea#37555)) - Fix(actions): validate workflow param to prevent 500 error ([#37546](go-gitea/gitea#37546)) ([#37554](go-gitea/gitea#37554)) - Don't unblock run-level-concurrency-blocked runs in the resolver ([#37461](go-gitea/gitea#37461)) ([#37538](go-gitea/gitea#37538)) - Fix(packages): use file names for generic web downloads ([#37514](go-gitea/gitea#37514)) ([#37520](go-gitea/gitea#37520)) - Fix merge autodetect can't close other PRs but only the last one when multiple PRs are pushed at once ([#37512](go-gitea/gitea#37512)) ([#37516](go-gitea/gitea#37516)) - Fix update branch protection order ([#37508](go-gitea/gitea#37508)) ([#37513](go-gitea/gitea#37513)) - Fix mCaptcha broken after Vite migration ([#37492](go-gitea/gitea#37492)) ([#37509](go-gitea/gitea#37509)) - Fix review submission from single-commit PR view ([#37475](go-gitea/gitea#37475)) ([#37485](go-gitea/gitea#37485)) - Fix scheduled action panic with null event payload ([#37459](go-gitea/gitea#37459)) ([#37466](go-gitea/gitea#37466)) - Make GetPossibleUserByID can handle deleted user ([#37430](go-gitea/gitea#37430)) ([#37431](go-gitea/gitea#37431)) - Remove excessive quote from terraform instructions ([#37424](go-gitea/gitea#37424)) ([#37426](go-gitea/gitea#37426)) - Fix color regressions, add `priority` color ([#37417](go-gitea/gitea#37417)) ([#37421](go-gitea/gitea#37421)) - MISC - Add CurrentURL template variable back ([#37444](go-gitea/gitea#37444)) ([#37449](go-gitea/gitea#37449)) Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/apoci/pulls/47

Enhance URL sanitization to handle schemeless credentials and improve…

67f9c29

… logging output

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2026

bircni changed the title ~~Enhance URL sanitization to handle schemeless credentials~~ FIX: URL sanitization to handle schemeless credentials Apr 26, 2026

bircni requested a review from wxiaoguang April 26, 2026 17:52

bircni marked this pull request as ready for review April 26, 2026 17:56

bircni requested a review from lunny April 26, 2026 17:58

bircni and others added 2 commits April 26, 2026 21:01

fixes

1d3bafb

remove duplicate % in userinfo regex char classes

7fecb15

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind approved these changes Apr 26, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 26, 2026

wxiaoguang added 2 commits April 27, 2026 04:29

fix

e0db6b6

comment

7dd1646

wxiaoguang marked this pull request as draft April 26, 2026 20:54

wxiaoguang self-assigned this Apr 26, 2026

wxiaoguang added 3 commits April 27, 2026 05:24

fix

5f4e3cc

fine tune

39db1e4

fine tune

fdc2e02

wxiaoguang requested review from Copilot and removed request for wxiaoguang April 26, 2026 21:30

Copilot started reviewing on behalf of wxiaoguang April 26, 2026 21:30 View session

wxiaoguang marked this pull request as ready for review April 26, 2026 21:33

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread modules/util/sanitize.go

Comment thread services/migrations/migrate.go

Comment thread modules/util/sanitize.go

Comment thread modules/util/sanitize.go Outdated

wxiaoguang added 2 commits April 27, 2026 05:35

fix comment

011dc70

Merge branch 'main' into fix/sanitization

3c48fe9

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2026

lunny added the type/bug label Apr 27, 2026

silverwind self-requested a review April 27, 2026 21:54

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 27, 2026

silverwind approved these changes Apr 27, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2026

wxiaoguang added 2 commits April 28, 2026 11:45

revert AI slop

41c1f9d

ipv6 parsing

7420736

silverwind approved these changes Apr 28, 2026

View reviewed changes

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 28, 2026

silverwind enabled auto-merge (squash) April 28, 2026 04:20

silverwind and others added 2 commits April 28, 2026 06:20

Merge branch 'main' into fix/sanitization

cefc358

Merge branch 'main' into fix/sanitization

12e19c3

wxiaoguang disabled auto-merge April 28, 2026 04:55

fine tune comments

080b0e5

wxiaoguang merged commit fedc9dc into go-gitea:main Apr 28, 2026
26 checks passed

GiteaBot added this to the 1.27.0 milestone Apr 28, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 28, 2026

GiteaBot mentioned this pull request Apr 28, 2026

FIX: URL sanitization to handle schemeless credentials (#37440) #37471

Merged

GiteaBot added the backport/done All backports for this PR have been created label Apr 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FIX: URL sanitization to handle schemeless credentials#37440

FIX: URL sanitization to handle schemeless credentials#37440
wxiaoguang merged 18 commits into
go-gitea:mainfrom
bircni:fix/sanitization

bircni commented Apr 26, 2026

Uh oh!

wxiaoguang commented Apr 26, 2026

Uh oh!

bircni commented Apr 26, 2026

Uh oh!

bircni commented Apr 26, 2026

Uh oh!

silverwind commented Apr 26, 2026 •

edited

Loading

Uh oh!

wxiaoguang commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

bircni commented Apr 26, 2026

Uh oh!

wxiaoguang commented Apr 26, 2026

Uh oh!

bircni commented Apr 26, 2026

Uh oh!

bircni commented Apr 26, 2026

Uh oh!

silverwind commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented Apr 26, 2026 •

edited

Loading