fix(actions): prevent panic when workflow contains null jobs

[Exgene]

The issue

Closes #37568. Basically due to empty fields being present in the actions file, the jobs would be produced as nil inside jobparser.go . Because of this when we call Parse on the jobparser module.

Needs:   job.Needs(),

would propagate the nil job down the chain.

The fix

For now i decide to fix it by guarding with an if job == nil check.

[lunny]

Please add a test

[Exgene]

sure @lunny I think some new commits were made in the main branch, do i rebase it or merge?

[lunny]

sure @lunny I think some new commits were made in the main branch, do i rebase it or merge?

Merge the main branch into the branch

[wxiaoguang]

The error seems unclear, it should report something like "needed job is not found"

[Exgene]

yeah i agree, will udpate the error message as well

[Exgene]

@lunny @wxiaoguang made the relevant changes

[Exgene]

off topic: @wxiaoguang are there any issues i can work on, Id love to contribute more, maybe helping with developing a feature etc.

[wxiaoguang]

off topic: @wxiaoguang are there any issues i can work on, Id love to contribute more, maybe helping with developing a feature etc.

I ever opened an issue "Some "good first issues" (likely easy to fix) for contributors #35015", but there were too many low-quality AI PRs (say, AI slop), so I closed it.

If you have understood the problems, feel free to open PRs to fix or improve. Thank you very much.

And you can also read through the whole code base or issue list, if anything seems wrong, feel free to propose correct changes.

[Exgene]

off topic: @wxiaoguang are there any issues i can work on, Id love to contribute more, maybe helping with developing a feature etc.

I ever opened an issue "Some "good first issues" (likely easy to fix) for contributors #35015", but there were too many low-quality AI PRs (say, AI slop), so I closed it.

If you have understood the problems, feel free to open PRs to fix or improve. Thank you very much.

And you can also read through the whole code base or issue list, if anything seems wrong, feel free to propose correct changes.

agreed, lot of slop out there, i think ill take some time off to go through the codebase, I want to learn go (in detail) so open source seems like a nice way to contribute and learn at the same time.

[wxiaoguang]

Yep, use AI to learn truths/knowledge and generate high-quality code, but be careful about AI hallucination and slop.

[wxiaoguang]

@Exgene

off topic: are there any issues i can work on, Id love to contribute more, maybe helping with developing a feature etc.

I did a quick look through, I think this one "Missing Source Repository URL in Migration Status (API vs UI) #36952" is a good first issue, maybe just need to add the missing field assignment in the API code.

[Exgene]

@wxiaoguang thanks will take a look!