Skip to content

chore(renovate): detect Makefile tools, enable go bumps#37595

Merged
silverwind merged 8 commits into
go-gitea:mainfrom
silverwind:renovate-config-tweaks
May 8, 2026
Merged

chore(renovate): detect Makefile tools, enable go bumps#37595
silverwind merged 8 commits into
go-gitea:mainfrom
silverwind:renovate-config-tweaks

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented May 7, 2026 •
edited
Loading

  • fix detection of Makefile tools and group them separately
  • Enable go.mod go directive bumps, schedule it at any time and exempt it from the release-age delay

This PR was written with the help of Claude Opus 4.7

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2026
@silverwind silverwind force-pushed the renovate-config-tweaks branch from 12ff6eb to 982e81a Compare May 7, 2026 19:21
@silverwind @claude
chore(renovate): detect Makefile tools, bump go directive
bb091ef 
- enable `custom.regex` manager so Makefile `*_PACKAGE` deps are detected
- group Makefile tool updates separately as "tool dependencies"
- opt in to bumping `go.mod` `go` directive (off by default in Renovate);
  schedule it at any time and exempt it from the release-age delay
- reduce minimum release age from 5 to 3 days

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind silverwind force-pushed the renovate-config-tweaks branch from 982e81a to bb091ef Compare May 7, 2026 19:22
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented May 7, 2026

After merging this, we should get the go 1.26.3 bump shortly.

@silverwind silverwind requested a review from Copilot May 7, 2026 19:34
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the repository’s Renovate configuration to better track tool dependencies defined in the Makefile and to update the go.mod go directive more proactively.

Changes:

  • Enable the custom.regex manager so the existing Makefile *_PACKAGE regex custom manager actually runs.
  • Split Renovate grouping so Makefile tool updates are grouped separately from gomod updates.
  • Allow Renovate to bump the go.mod go directive with rangeStrategy=bump, no release-age delay, and no schedule restriction; also reduce the global minimumReleaseAge from 5 to 3 days.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bircni
bircni approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2026
@bircni
Copy link
Copy Markdown
Member

bircni commented May 7, 2026

why dropping the release age from 5 to 3 days?

@bircni bircni added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 7, 2026
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented May 7, 2026

To make updates a bit fresher. Most major supply chain attacks are discovered in the first 12 hours or so. pnpm 11 defaults to 1 day for this (but we don't use that pnpm feature).

silverwind
silverwind commented May 7, 2026
View reviewed changes
Comment thread renovate.json5 Outdated
@silverwind
restore 5 days
1c067a3 
Signed-off-by: silverwind <me@silverwind.io>
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented May 7, 2026

Actually no strong reason for 3 days so I restored 5.

silverwind
silverwind commented May 7, 2026
View reviewed changes
Comment thread renovate.json5
@silverwind
Apply suggestion from @silverwind
d161037 
Signed-off-by: silverwind <me@silverwind.io>
silverwind
silverwind commented May 7, 2026
View reviewed changes
Comment thread renovate.json5
@silverwind
Apply suggestion from @silverwind
7bf2ebb 
Signed-off-by: silverwind <me@silverwind.io>
silverwind
silverwind commented May 7, 2026
View reviewed changes
Comment thread renovate.json5
@silverwind
Apply suggestion from @silverwind
0690094 
Signed-off-by: silverwind <me@silverwind.io>
silverwind
silverwind commented May 7, 2026
View reviewed changes
Comment thread renovate.json5 Outdated
@silverwind
Apply suggestion from @silverwind
314dbc0 
Signed-off-by: silverwind <me@silverwind.io>
@silverwind silverwind changed the title chore(renovate): detect Makefile tools, bump go directive chore(renovate): detect Makefile tools, enable go bumps May 7, 2026
@silverwind silverwind requested a review from Copilot May 7, 2026 22:19
Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@silverwind @claude
fix: use valid customType: regex for Makefile manager
c2d9b7f 
`customType` only accepts `regex` or `jsonata`; arbitrary names are
invalid. All regex custom managers share the `custom.regex` identifier,
so split tool deps from gomod via `matchFileNames` instead.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2026
@silverwind silverwind enabled auto-merge (squash) May 8, 2026 03:41
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2026
@silverwind silverwind merged commit bba748e into go-gitea:main May 8, 2026
23 checks passed
@silverwind silverwind deleted the renovate-config-tweaks branch May 8, 2026 03:44
@GiteaBot GiteaBot added this to the 1.27.0 milestone May 8, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request May 8, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into pin-go-tools-makefile
3749d34 
* origin/main:
  chore(renovate): detect Makefile tools, enable `go` bumps (go-gitea#37595)
  refactor: only reset a database table when the table's data was changed (go-gitea#37573)
  refactor: lint bare `fill`/`stroke` colors, add vars for git graph color series (go-gitea#37543)
  fix(actions): report individual step status in workflow job API response (go-gitea#37592)
  ci: allow `chore` type in PR title lint (go-gitea#37575)
  refactor: remove obsolete export (go-gitea#37579)
  fix: Invalid UTF-8 commit messages in JSON API responses (go-gitea#37542)
  fix: use consistent GetUser family functions (go-gitea#37553)
  fix(api): return 409 message instead of empty JSON for wrong commit id (go-gitea#37572)
  fix(actions): prevent panic when workflow contains null jobs (go-gitea#37570)
  [skip ci] Updated translations via Crowdin

# Conflicts:
#	services/pull/pull.go
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 8, 2026
@zjjhot
Merge branch 'main' into mainzjj
ba3a9b6 
* main:
  chore(deps): bump tool deps and pin, update `golangci-lint` (go-gitea#37574)
  build: update pnpm to v11 (go-gitea#37591)
  chore(renovate): detect Makefile tools, enable `go` bumps (go-gitea#37595)
  refactor: only reset a database table when the table's data was changed (go-gitea#37573)
  refactor: lint bare `fill`/`stroke` colors, add vars for git graph color series (go-gitea#37543)
  fix(actions): report individual step status in workflow job API response (go-gitea#37592)
  ci: allow `chore` type in PR title lint (go-gitea#37575)
  refactor: remove obsolete export (go-gitea#37579)
  fix: Invalid UTF-8 commit messages in JSON API responses (go-gitea#37542)
  fix: use consistent GetUser family functions (go-gitea#37553)
  fix(api): return 409 message instead of empty JSON for wrong commit id (go-gitea#37572)
  fix(actions): prevent panic when workflow contains null jobs (go-gitea#37570)
  [skip ci] Updated translations via Crowdin
  refactor: use modernc sqlite driver as default (go-gitea#37562)
  refactor(templates): remove ctxData from tmpl files, use ctx.RootData instead (go-gitea#37567)
  ci: increase renovate frequency and fix RENOVATE_ALLOWED_POST_UPGRADE_COMMANDS (go-gitea#37565)

# Conflicts:
#	models/user/user.go
silverwind added a commit to mohammad-rj/gitea that referenced this pull request May 8, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into feat/websocket-migration
23e1406 
* origin/main: (82 commits)
  build(deps): bump fast-uri from 3.1.0 to 3.1.2 (go-gitea#37616)
  fix: make clone URL respect public URL detection setting (go-gitea#37615)
  chore(deps): bump go-git/go-git/v5 to 5.19.0 (go-gitea#37608)
  chore(deps): update action dependencies (go-gitea#37603)
  fix(actions): fix blank lines after `::endgroup::` (go-gitea#37597)
  fix: treat email addresses case-insensitively (go-gitea#37600)
  fix(git): Fix smart http request scope bug (go-gitea#37583)
  chore(deps): update dependency go to v1.26.3 (go-gitea#37601)
  chore(deps): bump tool deps and pin, update `golangci-lint` (go-gitea#37574)
  build: update pnpm to v11 (go-gitea#37591)
  chore(renovate): detect Makefile tools, enable `go` bumps (go-gitea#37595)
  refactor: only reset a database table when the table's data was changed (go-gitea#37573)
  refactor: lint bare `fill`/`stroke` colors, add vars for git graph color series (go-gitea#37543)
  fix(actions): report individual step status in workflow job API response (go-gitea#37592)
  ci: allow `chore` type in PR title lint (go-gitea#37575)
  refactor: remove obsolete export (go-gitea#37579)
  fix: Invalid UTF-8 commit messages in JSON API responses (go-gitea#37542)
  fix: use consistent GetUser family functions (go-gitea#37553)
  fix(api): return 409 message instead of empty JSON for wrong commit id (go-gitea#37572)
  fix(actions): prevent panic when workflow contains null jobs (go-gitea#37570)
  ...

# Conflicts:
#	tests/e2e/events.test.ts
#	tests/integration/eventsource_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lunny lunny lunny approved these changes

@bircni bircni bircni approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @bircni @lunny @GiteaBot