fix: treat email addresses case-insensitively by silverwind · Pull Request #37600 · go-gitea/gitea

silverwind · 2026-05-08T01:13:31Z

Fixes #36184 and three more discovered cases.

This PR was written with the help of Claude Opus 4.7

Fixes go-gitea#36184 Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

Copilot

Pull request overview

This PR improves interoperability by treating email-derived identifiers case-insensitively, preventing failures when MTAs/email clients alter address casing (notably for incoming-email reply tokens).

Changes:

Normalize incoming email token decoding to tolerate lowercased base32 tokens.
Compile incoming-email address/reference matchers case-insensitively.
Compare SSH authorized-principal email strings case-insensitively.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`services/mailer/token/token.go`	Normalizes token case before base32 decode to survive lowercased reply-to addresses.
`services/mailer/incoming/incoming.go`	Makes reply-to and reference token regex matching case-insensitive.
`models/asymkey/ssh_key_principals.go`	Makes email principal matching case-insensitive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Use LowerEmail for the SSH principal comparison to match the rest of the codebase's normalisation convention. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

Signed-off-by: silverwind <me@silverwind.io>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

wxiaoguang

Thanks to the new test cases, we can safely refactor the code and get rid of the abuses of the regexps

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

silverwind · 2026-05-08T08:44:54Z

lgtm

* origin/main: (82 commits) build(deps): bump fast-uri from 3.1.0 to 3.1.2 (go-gitea#37616) fix: make clone URL respect public URL detection setting (go-gitea#37615) chore(deps): bump go-git/go-git/v5 to 5.19.0 (go-gitea#37608) chore(deps): update action dependencies (go-gitea#37603) fix(actions): fix blank lines after `::endgroup::` (go-gitea#37597) fix: treat email addresses case-insensitively (go-gitea#37600) fix(git): Fix smart http request scope bug (go-gitea#37583) chore(deps): update dependency go to v1.26.3 (go-gitea#37601) chore(deps): bump tool deps and pin, update `golangci-lint` (go-gitea#37574) build: update pnpm to v11 (go-gitea#37591) chore(renovate): detect Makefile tools, enable `go` bumps (go-gitea#37595) refactor: only reset a database table when the table's data was changed (go-gitea#37573) refactor: lint bare `fill`/`stroke` colors, add vars for git graph color series (go-gitea#37543) fix(actions): report individual step status in workflow job API response (go-gitea#37592) ci: allow `chore` type in PR title lint (go-gitea#37575) refactor: remove obsolete export (go-gitea#37579) fix: Invalid UTF-8 commit messages in JSON API responses (go-gitea#37542) fix: use consistent GetUser family functions (go-gitea#37553) fix(api): return 409 message instead of empty JSON for wrong commit id (go-gitea#37572) fix(actions): prevent panic when workflow contains null jobs (go-gitea#37570) ... # Conflicts: # tests/e2e/events.test.ts # tests/integration/eventsource_test.go

* main: perf: replace `goheader` linter with custom check (go-gitea#37599) build(deps): bump fast-uri from 3.1.0 to 3.1.2 (go-gitea#37616) fix: make clone URL respect public URL detection setting (go-gitea#37615) chore(deps): bump go-git/go-git/v5 to 5.19.0 (go-gitea#37608) chore(deps): update action dependencies (go-gitea#37603) fix(actions): fix blank lines after `::endgroup::` (go-gitea#37597) fix: treat email addresses case-insensitively (go-gitea#37600) fix(git): Fix smart http request scope bug (go-gitea#37583) chore(deps): update dependency go to v1.26.3 (go-gitea#37601)

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [code.gitea.io/gitea](https://github.com/go-gitea/gitea) | `v1.26.1` → `v1.26.2` | ![age](https://developer.mend.io/api/mc/badges/age/go/code.gitea.io%2fgitea/v1.26.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/code.gitea.io%2fgitea/v1.26.1/v1.26.2?slim=true) | --- ### Release Notes <details> <summary>go-gitea/gitea (code.gitea.io/gitea)</summary> ### [`v1.26.2`](https://github.com/go-gitea/gitea/releases/tag/v1.26.2) [Compare Source](go-gitea/gitea@v1.26.1...v1.26.2) - SECURITY - fix(permissions): Fix reading permission ([#37769](go-gitea/gitea#37769)) - fix(actions): make artifact signature payloads unambiguous ([#37707](go-gitea/gitea#37707)) - fix: Unify public-only token filtering in API queries and repo access checks ([#37118](go-gitea/gitea#37118)) - fix: Add missed token scope checking ([#37735](go-gitea/gitea#37735)) - fix(oauth): bind token exchanges to the original client request ([#37704](go-gitea/gitea#37704)) - fix(oauth): strengthen PKCE validation and refresh token replay protection ([#37706](go-gitea/gitea#37706)) - fix(web): enforce token scopes on raw, media, and attachment downloads ([#37698](go-gitea/gitea#37698)) - fix(security): enforce wiki git writes and LFS token access at request time ([#37695](go-gitea/gitea#37695)) - feat(api): encrypt AWS creds ([#37679](go-gitea/gitea#37679)) - fix(deps): update dependency mermaid to v11.15.0 \[security], add e2e test - fix(packages): Add label for private and internal package and fix composor package source permission check ([#37610](go-gitea/gitea#37610)) - fix(git): Fix smart http request scope bug ([#37583](go-gitea/gitea#37583)) - Fix basic auth bug ([#37503](go-gitea/gitea#37503)) - Fix allow maintainer edit permission check ([#37479](go-gitea/gitea#37479)) ([#37484](go-gitea/gitea#37484)) - Fix URL sanitization to handle schemeless credentials ([#37440](go-gitea/gitea#37440)) ([#37471](go-gitea/gitea#37471)) - Fix attachment Content-Security-Policy ([#37455](go-gitea/gitea#37455)) ([#37464](go-gitea/gitea#37464)) - chore(deps): bump go-git/go-git/v5 to 5.19.0 ([#37608](go-gitea/gitea#37608)) - BUGFIXES - fix(pull): handle empty pull request files view to allow reviews ([#37783](go-gitea/gitea#37783)) - fix(markup): make RenderString never fail ([#37779](go-gitea/gitea#37779)) - fix: add natural sort to sortTreeViewNodes ([#37772](go-gitea/gitea#37772)) - fix: package creation unique conflict ([#37774](go-gitea/gitea#37774)) - fix!: add DEFAULT\_TITLE\_SOURCE setting for pull request title default behavior ([#37465](go-gitea/gitea#37465)) - fix: Allow direct commits for unprotected files with push restrictions ([#37657](go-gitea/gitea#37657)) - fix(actions): wrong assumption that run id always >= job id ([#37737](go-gitea/gitea#37737)) - fix(auth): set User-Agent on avatar fetch and sync avatar on link-account register ([#37564](go-gitea/gitea#37564)) ([#37588](go-gitea/gitea#37588)) - fix(actions): deadlock between PrepareRunAndInsert and UpdateTaskByState ([#37692](go-gitea/gitea#37692)) - fix(repo): /generate must sync the branch table for the new repo ([#37693](go-gitea/gitea#37693)) - build: Fix snap build (1.26) - fix(actions): run TransferLogs on UpdateLog{Rows:\[], NoMore:true} ([#37631](go-gitea/gitea#37631)) - fix show correct mergebase - fix: make clone URL respect public URL detection setting ([#37615](go-gitea/gitea#37615)) - fix: "run as root" check ([#37622](go-gitea/gitea#37622)) - chore(deps): update dependency go to v1.26.3 ([#37601](go-gitea/gitea#37601)) - Compare dropdown fails when selecting branch with no common merge-base ([#37470](go-gitea/gitea#37470)) - fix: treat email addresses case-insensitively ([#37600](go-gitea/gitea#37600)) - fix(actions): fix blank lines after ::endgroup:: ([#37597](go-gitea/gitea#37597)) - fix(actions): report individual step status in workflow job API response ([#37592](go-gitea/gitea#37592)) - fix: Invalid UTF-8 commit messages in JSON API responses ([#37542](go-gitea/gitea#37542)) - fix: use consistent GetUser family functions ([#37553](go-gitea/gitea#37553)) - fix(api): return 409 message instead of empty JSON for wrong commit id ([#37572](go-gitea/gitea#37572)) - fix(actions): prevent panic when workflow contains null jobs ([#37570](go-gitea/gitea#37570)) - Make ServeSetHeaders default to download attachment if filename exists ([#37552](go-gitea/gitea#37552)) ([#37555](go-gitea/gitea#37555)) - Fix(actions): validate workflow param to prevent 500 error ([#37546](go-gitea/gitea#37546)) ([#37554](go-gitea/gitea#37554)) - Don't unblock run-level-concurrency-blocked runs in the resolver ([#37461](go-gitea/gitea#37461)) ([#37538](go-gitea/gitea#37538)) - Fix(packages): use file names for generic web downloads ([#37514](go-gitea/gitea#37514)) ([#37520](go-gitea/gitea#37520)) - Fix merge autodetect can't close other PRs but only the last one when multiple PRs are pushed at once ([#37512](go-gitea/gitea#37512)) ([#37516](go-gitea/gitea#37516)) - Fix update branch protection order ([#37508](go-gitea/gitea#37508)) ([#37513](go-gitea/gitea#37513)) - Fix mCaptcha broken after Vite migration ([#37492](go-gitea/gitea#37492)) ([#37509](go-gitea/gitea#37509)) - Fix review submission from single-commit PR view ([#37475](go-gitea/gitea#37475)) ([#37485](go-gitea/gitea#37485)) - Fix scheduled action panic with null event payload ([#37459](go-gitea/gitea#37459)) ([#37466](go-gitea/gitea#37466)) - Make GetPossibleUserByID can handle deleted user ([#37430](go-gitea/gitea#37430)) ([#37431](go-gitea/gitea#37431)) - Remove excessive quote from terraform instructions ([#37424](go-gitea/gitea#37424)) ([#37426](go-gitea/gitea#37426)) - Fix color regressions, add `priority` color ([#37417](go-gitea/gitea#37417)) ([#37421](go-gitea/gitea#37421)) - MISC - Add CurrentURL template variable back ([#37444](go-gitea/gitea#37444)) ([#37449](go-gitea/gitea#37449)) Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/apoci/pulls/47

joggienl · 2026-05-20T21:37:59Z

Just added this to #37611 ... checked in 1.26.2 and it works as expected, thanks a lot!

fix: treat email addresses case-insensitively

69f9e4b

Fixes go-gitea#36184 Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2026

silverwind added the backport/v1.26 This PR should be backported to Gitea 1.26 label May 8, 2026

silverwind requested a review from Copilot May 8, 2026 01:19

Copilot started reviewing on behalf of silverwind May 8, 2026 01:19 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread services/mailer/token/token.go Outdated

Comment thread services/mailer/incoming/incoming.go Outdated

Comment thread models/asymkey/ssh_key_principals.go Outdated

test: cover lowercased email/token paths

6239302

Use LowerEmail for the SSH principal comparison to match the rest of the codebase's normalisation convention. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind commented May 8, 2026

View reviewed changes

Comment thread models/asymkey/ssh_key_principals.go Outdated

Apply suggestion from @silverwind

415c275

Signed-off-by: silverwind <me@silverwind.io>

silverwind added the type/bug label May 8, 2026

silverwind requested a review from Copilot May 8, 2026 03:29

Copilot started reviewing on behalf of silverwind May 8, 2026 03:29 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread services/mailer/incoming/incoming_test.go

Comment thread services/mailer/token/token.go

wxiaoguang added 2 commits May 8, 2026 15:47

fix

b39821e

fix

54c91cd

wxiaoguang approved these changes May 8, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2026

wxiaoguang requested a review from Copilot May 8, 2026 08:15

Copilot started reviewing on behalf of wxiaoguang May 8, 2026 08:16 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread modules/setting/incoming_email.go

fix func name, fix typos

fb19f2e

bircni approved these changes May 8, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2026

Merge branch 'main' into email-case-insensitive

2c9d638

bircni enabled auto-merge (squash) May 8, 2026 14:49

bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2026

bircni merged commit 29676ad into go-gitea:main May 8, 2026
23 checks passed

GiteaBot added this to the 1.27.0 milestone May 8, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2026

wxiaoguang deleted the email-case-insensitive branch May 8, 2026 15:22

GiteaBot mentioned this pull request May 8, 2026

fix: treat email addresses case-insensitively (#37600) #37611

Merged

GiteaBot added the backport/done All backports for this PR have been created label May 8, 2026

bircni pushed a commit that referenced this pull request May 8, 2026

fix: treat email addresses case-insensitively (#37600) (#37611)

65f3fea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: treat email addresses case-insensitively#37600

fix: treat email addresses case-insensitively#37600
bircni merged 7 commits into
go-gitea:mainfrom
silverwind:email-case-insensitive

silverwind commented May 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

wxiaoguang left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

silverwind commented May 8, 2026

Uh oh!

Uh oh!

joggienl commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

silverwind commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

wxiaoguang left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

silverwind commented May 8, 2026

Uh oh!

Uh oh!

joggienl commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented May 8, 2026 •

edited

Loading