Fix for #14593

[0m3r]

Description

Preconditions:

Magento version 2.2.4 with luma theme

Step to reproduce:

• Open chrome developer console
• Add a product to the cart.
• From the mini cart in the upper right click the trash icon.
• A confirmation modal will open.
• Press Esc button

Expected Result

• Close the confirm

Actual result

• js error

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined

Fixed Issues

1. Press Esc Key on modal generate a jquery UI error #14593

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @0m3r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Why it happens to be undefined?

[0m3r]

the event e is undefined

function escapeKey lost event param
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Ui/view/base/web/js/modal/modal.js#L108

but for closeModal function event is required param
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Ui/view/base/web/js/modal/confirm.js#L89

always (sidebar.js:95)
closeModal (confirm.js:97)                  

closeModal: function (event, result) {
            result = result || false;

            if (result) {
                this.options.actions.confirm(event);
            } else {
                this.options.actions.cancel(event);
            }
            this.options.actions.always(event);
            this.element.bind('confirmclosed', _.bind(this._remove, this));

            return this._super();
        }

(anonymous) (jquery-ui.js:402)
escapeKey (modal.js:111)                   

                escapeKey: function () {
                    if (this.options.isOpen && this.modal.find(document.activeElement).length ||
                        this.options.isOpen && this.modal[0] === document.activeElement) {
                        this.closeModal();
                    }
                }

keyEventSwitcher (modal.js:180)
...

[VladimirZaets]

Hi @0m3r, thanks for collaboration. I think that always method should always receive event object. The correct way to fix this issue is fixing the place where event object was lost