Skip to content

[Forwardport] Update checkout translations - #16638

Merged
magento-engcom-team merged 1 commit into
magento:2.3-developfrom
Jeroenll:patch-1
Jul 11, 2018
Merged

[Forwardport] Update checkout translations#16638
magento-engcom-team merged 1 commit into
magento:2.3-developfrom
Jeroenll:patch-1

Conversation

@Jeroenll

@Jeroenll Jeroenll commented Jul 9, 2018

Copy link
Copy Markdown
Member

Original Pull Request

#16553

Description

Add missing translations found in https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html

Fixed Issues (if relevant)

  1. None I could find.

Manual testing scenarios

  1. Install language pack other than English.
  2. Check translations in mini cart.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Jeroen
Update checkout translations
8ce1d8f 
# Conflicts:
#	app/code/Magento/Checkout/i18n/en_US.csv
@Jeroenll Jeroenll added Release Line: 2.3 forwardport partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital Partner: H&O labels Jul 9, 2018
@magento-engcom-team

magento-engcom-team commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 9, 2018
@magento-engcom-team
magento-engcom-team merged commit 8ce1d8f into magento:2.3-develop Jul 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2018
Stanislav Idolov
ENGCOM-2227: [Forwardport] Update checkout translations #16638
831db04
@magento-engcom-team

magento-engcom-team commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Jeroenll
Jeroenll deleted the patch-1 branch October 4, 2018 08:29
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
ENGCOM-2227: [Forwardport] Update checkout translations magento#16638
ff96ede 
 - Merge Pull Request magento#16638 from JeroenVanLeusden/magento2:patch-1
 - Merged commits:
   1. 8ce1d8f
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
Stanislav Idolov
🔃 [EngCom] Public Pull Requests - 2.3-develop
53241b9 
Accepted Public Pull Requests:
 - magento#16668: Fix missing PHPDocs hinting for AdvancedPricingImportExport module (by @mageprince)
 - magento#16659: [Forwardport] dev:di:info duplicates plugin info (by @coderimus)
 - magento#16670: [Forwardport] Removed unused class from forms less file. (by @mageprince)
 - magento#16664: [Forwardport] 7399-clickableOverlay-less-fix - added pointer-events rule to .modal-� (by @mageprince)
 - magento#16642: [Forwardport] Variable as a method parameter might be overridden by the loop (by @lfluvisotto)
 - magento#16600: [2.3-develop][ForwardPort] Fixed backwards incompatible change to Transport variable event parameters (by @gwharton)
 - magento#16640: Trim email address in newsletter, forgot password, checkout login and email to a friend form (by @gelanivishal)
 - magento#16607: Add spelling correction: formatedPrice to formattedPrice (by @arnoudhgz)
 - magento#16611: [Forwardport] Removed extra code (by @gelanivishal)
 - magento#16638: [Forwardport] Update checkout translations (by @JeroenVanLeusden)
 - magento#16635: [Forwardport] Updated SynonymGroup.xml (by @sanganinamrata)
 - magento#16348: [Port 2.3] Captcha: Added integration tests for checking customer login attempts cleanup (by @rogyar)
 - magento#16623: [Forwardport] Fix for magento#14593 (second try magento#16431)  (by @mageprince)


Fixed GitHub Issues:
 - magento#7399: Modal UI: clickableOverlay option doesn't work (reported by @thdoan) has been fixed in magento#16664 by @mageprince in 2.3-develop branch
   Related commits:
     1. 76ae28f

 - magento#10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (reported by @diybook) has been fixed in magento#16600 by @gwharton in 2.3-develop branch
   Related commits:
     1. cdbd324

 - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16640 by @gelanivishal in 2.3-develop branch
   Related commits:
     1. 6fd1eda
     2. f00c37a
     3. 1888b1e
     4. 0653f09

 - magento#14593: Press Esc Key on modal generate a jquery UI error (reported by @apomili) has been fixed in magento#16623 by @mageprince in 2.3-develop branch
   Related commits:
     1. 0fdc0a8
     2. 07f7d83
     3. 160bc5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Component: Checkout Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Jeroenll @magento-engcom-team @VladimirZaets