Skip to content

[Forwardport] Fix for #14593 (second try #16431) - #16623

Merged
magento-engcom-team merged 3 commits into
magento:2.3-developfrom
mageprince:2.3-develop-PR-port-16477
Jul 11, 2018
Merged

[Forwardport] Fix for #14593 (second try #16431) #16623
magento-engcom-team merged 3 commits into
magento:2.3-developfrom
mageprince:2.3-develop-PR-port-16477

Conversation

@mageprince

@mageprince mageprince commented Jul 8, 2018

Copy link
Copy Markdown
Contributor

Original Pull Request

#16477

Description

Preconditions:

Magento version 2.2.4 with luma theme

Step to reproduce:

  • Open chrome developer console
  • Add a product to the cart.
  • From the mini cart in the upper right click the trash icon.
  • A confirmation modal will open.
  • Press Esc button

Expected Result

  • Close the confirm

Actual result

  • js error

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined

2018-06-21 15-50-01

Fixed Issues

  1. Press Esc Key on modal generate a jquery UI error #14593

P.S.

First, pull request - #16431

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team

magento-engcom-team commented Jul 8, 2018

Copy link
Copy Markdown
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jul 8, 2018
@orlangur orlangur self-assigned this Jul 9, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 9, 2018
@magento-engcom-team

magento-engcom-team commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2219 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Jul 11, 2018
Closed
@magento-engcom-team
magento-engcom-team merged commit 160bc5d into magento:2.3-develop Jul 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2018
Stanislav Idolov
ENGCOM-2219: [Forwardport] Fix for #14593 (second try #16431) #16623
8eadaed
@magento-engcom-team

magento-engcom-team commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@mageprince
mageprince deleted the 2.3-develop-PR-port-16477 branch July 11, 2018 13:21
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
ENGCOM-2219: [Forwardport] Fix for magento#14593 (second try magento#…
2f6ecb5 
…16431)  magento#16623

 - Merge Pull Request magento#16623 from mageprince/magento2:2.3-develop-PR-port-16477
 - Merged commits:
   1. 0fdc0a8
   2. 07f7d83
   3. 160bc5d
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
Stanislav Idolov
🔃 [EngCom] Public Pull Requests - 2.3-develop
53241b9 
Accepted Public Pull Requests:
 - magento#16668: Fix missing PHPDocs hinting for AdvancedPricingImportExport module (by @mageprince)
 - magento#16659: [Forwardport] dev:di:info duplicates plugin info (by @coderimus)
 - magento#16670: [Forwardport] Removed unused class from forms less file. (by @mageprince)
 - magento#16664: [Forwardport] 7399-clickableOverlay-less-fix - added pointer-events rule to .modal-� (by @mageprince)
 - magento#16642: [Forwardport] Variable as a method parameter might be overridden by the loop (by @lfluvisotto)
 - magento#16600: [2.3-develop][ForwardPort] Fixed backwards incompatible change to Transport variable event parameters (by @gwharton)
 - magento#16640: Trim email address in newsletter, forgot password, checkout login and email to a friend form (by @gelanivishal)
 - magento#16607: Add spelling correction: formatedPrice to formattedPrice (by @arnoudhgz)
 - magento#16611: [Forwardport] Removed extra code (by @gelanivishal)
 - magento#16638: [Forwardport] Update checkout translations (by @JeroenVanLeusden)
 - magento#16635: [Forwardport] Updated SynonymGroup.xml (by @sanganinamrata)
 - magento#16348: [Port 2.3] Captcha: Added integration tests for checking customer login attempts cleanup (by @rogyar)
 - magento#16623: [Forwardport] Fix for magento#14593 (second try magento#16431)  (by @mageprince)


Fixed GitHub Issues:
 - magento#7399: Modal UI: clickableOverlay option doesn't work (reported by @thdoan) has been fixed in magento#16664 by @mageprince in 2.3-develop branch
   Related commits:
     1. 76ae28f

 - magento#10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (reported by @diybook) has been fixed in magento#16600 by @gwharton in 2.3-develop branch
   Related commits:
     1. cdbd324

 - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16640 by @gelanivishal in 2.3-develop branch
   Related commits:
     1. 6fd1eda
     2. f00c37a
     3. 1888b1e
     4. 0653f09

 - magento#14593: Press Esc Key on modal generate a jquery UI error (reported by @apomili) has been fixed in magento#16623 by @mageprince in 2.3-develop branch
   Related commits:
     1. 0fdc0a8
     2. 07f7d83
     3. 160bc5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@orlangur orlangur orlangur approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: UiComponents Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mageprince @magento-engcom-team @orlangur @VladimirZaets @0m3r