Skip to content

Test coverage for PR #27357 (E-mail templates) - #27609

Merged
magento-engcom-team merged 8 commits into
magento:2.4-developfrom
lbajsarowicz:test-coverage/27357-integration-tests
Sep 2, 2020
Merged

Test coverage for PR #27357 (E-mail templates)#27609
magento-engcom-team merged 8 commits into
magento:2.4-developfrom
lbajsarowicz:test-coverage/27357-integration-tests

Conversation

@lbajsarowicz

@lbajsarowicz lbajsarowicz commented Apr 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description (*)

Additional Integration Tests coverage for PR provided by @ptylek

Related Pull Requests

Fixed Issues (if relevant)

  1. Newsletter subscription emails should also use paragraph tags #27357

Manual testing scenarios (*)

  1. ...
  2. ...

Support

Solving this issue is supported by Mediotype

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant

m2-assistant Bot commented Apr 5, 2020

Copy link
Copy Markdown

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz lbajsarowicz mentioned this pull request Apr 5, 2020
Merged
5 tasks
@rogyar rogyar self-assigned this Apr 5, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 20, 2020
rogyar
rogyar previously approved these changes Apr 20, 2020
View reviewed changes
@magento-engcom-team

magento-engcom-team commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7461 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 21, 2020
@engcom-Alfa

engcom-Alfa commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Apr 21, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 21, 2020
@VladimirZaets VladimirZaets added the Priority: P3 May be fixed according to the position in the backlog. label Apr 21, 2020
@lbajsarowicz
Merge remote-tracking branch 'origin/2.4-develop' into test-coverage/…
1a6b60f 
…27357-integration-tests

# Conflicts:
#	dev/tests/integration/testsuite/Magento/Newsletter/Model/SubscriberTest.php
@magento-engcom-team

magento-engcom-team commented May 20, 2020

Copy link
Copy Markdown
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7461 has been created to process this Pull Request

@slavvka slavvka added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 20, 2020
@ptylek ptylek mentioned this pull request May 21, 2020
Merged
5 tasks
@VladimirZaets VladimirZaets added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels May 27, 2020
@lbajsarowicz

lbajsarowicz commented Aug 2, 2020

Copy link
Copy Markdown
Contributor Author

@magento run all tests

Just to make sure that nothing was broken in the meantime.

@ihor-sviziev

ihor-sviziev commented Aug 19, 2020

Copy link
Copy Markdown
Contributor

@slavvka @VladimirZaets is there any reasons why this PR isn't getting merged?

@sidolov sidolov removed this from the 2.4.1 milestone Aug 20, 2020
@ihor-sviziev

ihor-sviziev commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Progress:accept label just disappeared. I just fixed it

magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020
@sidolov
ENGCOM-7461: Test coverage for PR #27357 (E-mail templates) #27609
ced8102
@magento-engcom-team
magento-engcom-team merged commit 02d6f96 into magento:2.4-develop Sep 2, 2020
@m2-assistant

m2-assistant Bot commented Sep 2, 2020

Copy link
Copy Markdown

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - 2.4-develop
b87f1df 
Accepted Community Pull Requests:
 - magento#29799: Add elasticsearch params to integration tests config (by @ihor-sviziev)
 - magento#29634: [MFTF] Added some ActionGroups to Analytics module (by @Usik2203)
 - magento#29348: [MFTF] Test scenario for "Apply shopping cart rule to a single bundle item" (magento#28921) (by @zhartaunik)
 - magento#28413: Fix Downloadable product after refund (by @ProkopovVitaliy)
 - magento#27609: Test coverage for PR magento#27357 (E-mail templates) (by @lbajsarowicz)
 - magento#27579: Fix magento#27523: throw informative errors in setup:db:generate-patch (by @korostii)


Fixed GitHub Issues:
 - magento#29648: [Issue] [MFTF] Added some ActionGroups to Analytics module (reported by @m2-assistant[bot]) has been fixed in magento#29634 by @Usik2203 in 2.4-develop branch
   Related commits:
     1. f54fd86
     2. 1492668
     3. 59d5d32
     4. 8c2291f
     5. e25fc55

 - magento#28921: Apply shopping cart rule to a single bundle item (reported by @MilanFrajt) has been fixed in magento#29348 by @zhartaunik in 2.4-develop branch
   Related commits:
     1. e6aca3b
     2. 7abc82f

 - magento#28388: Downloadable product is available in My Download Products tab after it has been partially refunded  (reported by @YaninaPrudnikova) has been fixed in magento#28413 by @ProkopovVitaliy in 2.4-develop branch
   Related commits:
     1. a6f460d
     2. 9a83830
     3. 96c9d54
     4. 59cf9f7
     5. c6c3231
     6. eafdb17
     7. 92fd06b
     8. 1f7eace
     9. db84d3a
     10. d0a0962
     11. aea9276
     12. 1be2cd7
     13. dee9b16
     14. a49709f
     15. 8023f42
     16. 9e31246
     17. d91b305
     18. 62e4866
     19. 97df424
     20. 2d58988
     21. 87d8984

 - magento#27523: CLI Patch Generator: Lack of information what path cannot be created (reported by @lbajsarowicz) has been fixed in magento#27579 by @korostii in 2.4-develop branch
   Related commits:
     1. 1e8e825
     2. 1dd5290
     3. c1d8fef
     4. a74f8fe
     5. f48cd50
     6. 2bc691a
     7. 8991733
     8. 347602f
     9. 75bb2c3
     10. 7d316d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@slavvka slavvka slavvka approved these changes
@rogyar rogyar rogyar left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels

Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Event: Global-Contribution-Day Partner: Blue Acorn iCi Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Projects

Pull Requests Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@lbajsarowicz @magento-engcom-team @engcom-Alfa @ihor-sviziev @rogyar @slavvka @VladimirZaets @sidolov @lenaorobei @engcom-Echo