[MFTF] Added some ActionGroups to Analytics module by Usik2203 · Pull Request #29634 · magento/magento2

Usik2203 · 2020-08-18T13:17:40Z

This PR adds AdminConfigGeneralAnalyticsPageOpenActionGroup and AssertAdminAdvancedReportingPageUrlActionGroup ActionGroups to Analytics module

Resolved issues:

resolves [Issue] [MFTF] Added some ActionGroups to Analytics module #29648: [MFTF] Added some ActionGroups to Analytics module

m2-assistant · 2020-08-18T13:17:43Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2020-08-18T13:18:00Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

rogyar · 2020-08-18T14:53:37Z

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminConfigGeneralAnalyticsPageOpenActionGroup">


I would recommend include a verb into the name that describes an action in the action group. It's a common practice and we will have more or less transparent naming convent in this case.

AdminOpenConfigGeneralAnalytticsPageActionGroup

sidolov · 2020-08-18T16:52:18Z

@magento create issue

VladimirZaets

Hi @Usik2203. Please take a look at builds that are failed and rename action group according to the recommendation provided by @rogyar.

…odule

Usik2203 · 2020-08-21T08:29:00Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

magento-engcom-team · 2020-08-23T13:59:42Z

Hi @rogyar, thank you for the review.
ENGCOM-8061 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

rogyar · 2020-08-27T13:51:58Z

Hi @sidolov. Could you approve this one, please?
Thank you!

…odule

sidolov · 2020-08-27T14:08:00Z

@magento run all tests

magento-engcom-team · 2020-08-27T14:08:32Z

Hi @sidolov, thank you for the review.
ENGCOM-8061 has been created to process this Pull Request

m2-assistant · 2020-09-02T17:07:57Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev

Accepted Community Pull Requests: - magento#29799: Add elasticsearch params to integration tests config (by @ihor-sviziev) - magento#29634: [MFTF] Added some ActionGroups to Analytics module (by @Usik2203) - magento#29348: [MFTF] Test scenario for "Apply shopping cart rule to a single bundle item" (magento#28921) (by @zhartaunik) - magento#28413: Fix Downloadable product after refund (by @ProkopovVitaliy) - magento#27609: Test coverage for PR magento#27357 (E-mail templates) (by @lbajsarowicz) - magento#27579: Fix magento#27523: throw informative errors in setup:db:generate-patch (by @korostii) Fixed GitHub Issues: - magento#29648: [Issue] [MFTF] Added some ActionGroups to Analytics module (reported by @m2-assistant[bot]) has been fixed in magento#29634 by @Usik2203 in 2.4-develop branch Related commits: 1. f54fd86 2. 1492668 3. 59d5d32 4. 8c2291f 5. e25fc55 - magento#28921: Apply shopping cart rule to a single bundle item (reported by @MilanFrajt) has been fixed in magento#29348 by @zhartaunik in 2.4-develop branch Related commits: 1. e6aca3b 2. 7abc82f - magento#28388: Downloadable product is available in My Download Products tab after it has been partially refunded (reported by @YaninaPrudnikova) has been fixed in magento#28413 by @ProkopovVitaliy in 2.4-develop branch Related commits: 1. a6f460d 2. 9a83830 3. 96c9d54 4. 59cf9f7 5. c6c3231 6. eafdb17 7. 92fd06b 8. 1f7eace 9. db84d3a 10. d0a0962 11. aea9276 12. 1be2cd7 13. dee9b16 14. a49709f 15. 8023f42 16. 9e31246 17. d91b305 18. 62e4866 19. 97df424 20. 2d58988 21. 87d8984 - magento#27523: CLI Patch Generator: Lack of information what path cannot be created (reported by @lbajsarowicz) has been fixed in magento#27579 by @korostii in 2.4-develop branch Related commits: 1. 1e8e825 2. 1dd5290 3. c1d8fef 4. a74f8fe 5. f48cd50 6. 2bc691a 7. 8991733 8. 347602f 9. 75bb2c3 10. 7d316d4

added some action groups to analytics module

f54fd86

ghost added the Progress: pending review label Aug 18, 2020

magento-engcom-team added Component: Analytics Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 18, 2020

rogyar self-assigned this Aug 18, 2020

rogyar reviewed Aug 18, 2020

View reviewed changes

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020

m2-assistant Bot mentioned this pull request Aug 18, 2020

[Issue] [MFTF] Added some ActionGroups to Analytics module #29648

Closed

VladimirZaets suggested changes Aug 18, 2020

View reviewed changes

ghost assigned VladimirZaets Aug 18, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 18, 2020

Usik2203 added 3 commits August 19, 2020 09:57

rename action group

1492668

Merge branch '2.4-develop' into add-some-action-groups-to-analytics-m…

59d5d32

…odule

Merge branch '2.4-develop' into add-some-action-groups-to-analytics-m…

8c2291f

…odule

rogyar approved these changes Aug 23, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 23, 2020

rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 27, 2020

sidolov approved these changes Aug 27, 2020

View reviewed changes

ghost assigned sidolov Aug 27, 2020

Merge branch '2.4-develop' into add-some-action-groups-to-analytics-m…

e25fc55

…odule

ghost added Progress: extended testing and removed Progress: ready for testing labels Aug 27, 2020

engcom-Charlie self-assigned this Aug 28, 2020

engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 28, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 28, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020

ENGCOM-8061: [MFTF] Added some ActionGroups to Analytics module #29634

badf28b

magento-engcom-team merged commit b0ee936 into magento:2.4-develop Sep 2, 2020

Navigation Menu

Uh oh!

[MFTF] Added some ActionGroups to Analytics module - #29634

[MFTF] Added some ActionGroups to Analytics module#29634
magento-engcom-team merged 5 commits into
magento:2.4-developfrom
Usik2203:add-some-action-groups-to-analytics-module

Usik2203 commented Aug 18, 2020 •

edited by m2-assistant Bot

Loading

Uh oh!

m2-assistant Bot commented Aug 18, 2020

Uh oh!

Usik2203 commented Aug 18, 2020

Uh oh!

rogyar Aug 18, 2020

Uh oh!

Usik2203 Aug 19, 2020

Uh oh!

sidolov commented Aug 18, 2020

Uh oh!

VladimirZaets left a comment

Uh oh!

Usik2203 commented Aug 21, 2020

Uh oh!

magento-engcom-team commented Aug 23, 2020

Uh oh!

rogyar commented Aug 27, 2020

Uh oh!

sidolov commented Aug 27, 2020

Uh oh!

magento-engcom-team commented Aug 27, 2020

Uh oh!

m2-assistant Bot commented Sep 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Usik2203 commented Aug 18, 2020 • edited by m2-assistant Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolved issues:

Uh oh!

m2-assistant Bot commented Aug 18, 2020

Uh oh!

Usik2203 commented Aug 18, 2020

Uh oh!

rogyar Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov commented Aug 18, 2020

Uh oh!

VladimirZaets left a comment

Choose a reason for hiding this comment

Uh oh!

Usik2203 commented Aug 21, 2020

Uh oh!

magento-engcom-team commented Aug 23, 2020

Uh oh!

rogyar commented Aug 27, 2020

Uh oh!

sidolov commented Aug 27, 2020

Uh oh!

magento-engcom-team commented Aug 27, 2020

Uh oh!

m2-assistant Bot commented Sep 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Usik2203 commented Aug 18, 2020 •

edited by m2-assistant Bot

Loading