Align to master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle unavailabe entities * Remove some logging * Set valve to lowest temp when turned off * Remove some logging * Address comments * Report entity as connected if update is successful * Fix stupidness * Fix
* Allow control whether POE switches are to be created or not * Fix options flow and test
* Unsub dispatcher when removing entity from hass * Update homeassistant/components/plaato/sensor.py Co-Authored-By: Martin Hjelmare <[email protected]> * Update homeassistant/components/volvooncall/__init__.py Co-Authored-By: Martin Hjelmare <[email protected]> Co-authored-by: Martin Hjelmare <[email protected]>
If the harmony hub was not ready for connection or was busy when importing from yaml, the import validation would fail would not be retried. To mitigate this scenario we now do the validation in async_setup_platform which allows us to raise PlatformNotReady so we can retry later.
* Convert TTS tests to async * Address comments
* add remote platform to directv. * Update __init__.py * Update .coveragerc * Rename remote py to remote.py * Update remote.py * squash. * Update remote.py * squash. * Update remote.py
* Don't write storage to disk while stopping * rework change * lint * remove delay save and schedule final write at stop * update tests * fix test component using private methods * cleanup * always listen * use stop in restore state again * whitelist JSON exceptions for later * review comment * make zwave tests use mock storage
* lib version * unit-test refactoring * added type hints * added cover * added test to see that consts have the same value as library consts * Update tests/components/dynalite/test_init.py Co-Authored-By: Martin Hjelmare <[email protected]> * removed trigger template * Update homeassistant/components/dynalite/__init__.py Co-Authored-By: Martin Hjelmare <[email protected]> * Update homeassistant/components/dynalite/const.py Co-Authored-By: Martin Hjelmare <[email protected]> * removed CONF_TRIGGER from const corrected type hints - not clear why mypy didn't catch it * conversion of the config to library CONFs * moved to use the value since it should come from the library * taking CONF_HOST from homeassistant.const instead of module const * use dict.get removed leftover log * force device_class to be from homeassistant consts * move dict.get to inline * removed CONF from values changed "channelcover" to "channel_cover" * moved some CONF values out of const.py and taking them from homeassistant.const * verifying that device class is a valid HA device class * moved shutter to home assistant const Co-authored-by: Martin Hjelmare <[email protected]>
* Add Rachio Flex Schedules * Remove Duration Property * Missed duration call * Black formatting
* Add melcloud AtaDevice vane control * Return empty dict when no vane states available Co-Authored-By: springstan <[email protected]> * Use constants for services and conf * Split state attribute assignment and fix suggested changes * Log valid positions when called with an invalid position * Improve service description Co-Authored-By: springstan <[email protected]> Co-authored-by: springstan <[email protected]>
* mock storage for MQTT * more mqtt storage mocks
now all mqtt tests pass
* Support for returning NULL in color or temperature. Fixes #33469 * Added further support for ‘None’ returns in level template * Removed assumption that template render may not be a string * Streamlined code per cloud pylint * Updates per code review suggestions * Added improved error handling and logging for brightness * Additional exception handling for temperature
was caused by device_info being mocks, so write to storage failed
… upper_temp, ambient_temp & is_enabled (#33363)
* Fix MQTT state vacuum value_template support. * Remove support for state_template
* Temporary playMedia() workaround on plexapi 3.3.0 * Use constants for strings * Style cleanup
* Add config flow for Flu Near You * Cleanup * Cleanup * Add tests * Add test requirements * Code review * Reduce unnecessary async-ness * Handle API registration * Cleanup * Update homeassistant/components/flunearyou/.translations/en.json Co-Authored-By: Paulus Schoutsen <[email protected]> * Code review * Ensure config schema allows additional keys Co-authored-by: Paulus Schoutsen <[email protected]>
* Use backend-provided fan speed presets for Xiaomi vacuums This needs input from Xiaomi vacuum owners to verify that it does not break anything. I have personally tested this on rockrobo v1 (old mapping). Related issues/PRs: #32821 #31268 #27268 This is a WIP as it requires a new upstream release. The PR is rytilahti/python-miio#643 * Bump version requirement for 0.5.0 * Bump requirements_test_all.txt, too * Fix linting; missing setup.cfg on local checkout caused wrong settings for black.. * Add tests for both fan speed types * Remove useless else.. * bump python-miio to 0.5.0.1 due to broken 0.5.0 packaging
* Update manifest.json * Update requirements_all.txt * Update requirements_test_all.txt
#32348) * Switch homekit lights to use service callbacks Service callbacks allow us to get the on/off, brightness, etc all in one call so we remove all the complexity that was previously needed to handle the out of sync states We now get the on event and brightness event at the same time which allows us to prevent lights from flashing up to 100% before the requested brightness. * Fix STATE_OFF -> STATE_ON,brightness:0
* add sound mode support for devices that support it * make setting and unsetting flag better * move eq and audio settings into constants * fix missed statement to use constant instead of hardcoded string * further fixes based on review * bump pyvizio version to include newly identified app
* Async fix * Update homeassistant/components/rachio/switch.py Co-Authored-By: J. Nick Koston <[email protected]> * Update homeassistant/components/rachio/switch.py Co-Authored-By: J. Nick Koston <[email protected]> * Fix format * Remove from hass * undo dispatcher Co-authored-by: J. Nick Koston <[email protected]>
When placeholders are in use, flow_title needs to be set in the json to prevent an empty name in the integrations dashboard. This affected doorbirds that were found via ssdp.
* force_update added As per this discussion we need to update last_changed when active timer restarted. One way to do that is to force HA update the state on each request even if it remains the same. More details here - home-assistant/architecture#345 * add test for force_update make sure state_change event fired every time timer (re)started * remove whitespaces * remove whitespace * Update tests/components/timer/test_init.py Co-Authored-By: Alexei Chetroi <[email protected]> * fix lint * fix isort Co-authored-by: Alexei Chetroi <[email protected]>
* Directly call async_write_ha_state pt2 * Directly call async_write_ha_state pt2 * Fix mock * Address comments
* Adding vera config entries support. * Fixing lint error. * Applying minimal changes necessary to get config entries working. * Addressing PR feedback by further reducing the scope of the change. * Addressing PR feedback. * Fixing pyvera import to make it easier to patch. Addressing PR feedback regarding creation of controller and scheduling of async config flow actions. * Updating code owners file. * Small fixes. * Adding a user config flow step. * Adding optional configs for user config flow. * Updating strings to be more clear to the user. * Adding options flow. Fixing some PR feedback. * Better handling of options. PR feedback changes. * Using config registry to update config options. * Better managing config from file or config from UI Disabling config through UI if config is provided from a file. More tests to account for these adjustments. * Address PR feedback. * Fixing test, merging with master. * Disabling all Vera UI for configs managed by configuration.yml. Adding more tests. * Updating config based on unique_id. Addressing additional PR feedback. * Rebasing off dev. Addressing feedback. * Addressing PR feedback.
* Upgrade Mastodon.py to 1.5.1 * Remove left-overs
* Fix network failure startup Fix for issue ##33284 - Asuswrt component fail at startup after power failure * Removed comment * Removed bare except * is_connected moved out try-catch * Removed pointless-string-statement * Raise PlatformNotReady on "not is_connected" * Removed unnecessary check * Revert "Removed unnecessary check" This reverts commit a2ccdda. * Implemented custom retry mechanism * Fix new line missing * Fix formatting * Fix indent * Reviewed check * Recoded based on tibber implementation * Formatting review * Changes requested * Fix tests for setup retry * Updated missing test * Fixed check on Tests * Return false if not exception * Format correction
ollo69
pushed a commit
that referenced
this pull request
Mar 5, 2021
…nt#46463) * Add get_configuration_values websocket command to zwave_js * Tweak return value * Review comments and cleanup returned values * Update test * Rename to get_config_parameters * Add get_configuration_values websocket command to zwave_js * Rename to get_config_parameters * fix test * fix tests #2 * Add readable to metadata Co-authored-by: Raman Gupta <[email protected]>
ollo69
pushed a commit
that referenced
this pull request
Mar 19, 2021
* Add suggested_area to MQTT Discovery This adds suggested_area to MQTT discovery, so that the discovered devices could be automatically added to the proper area. * Add abbreviation for MQTT suggested_area * Remove extra whitespace * Remove extra whitespace #2 * Added tests for MQTT Dicovery of suggested_area * Fix test for MQTT suggested_area * Better tests of MQTT suggested_area Changes made as per feedback from @emontnemery
ollo69
pushed a commit
that referenced
this pull request
Sep 4, 2021
* Fix fjaraskupan dependency for tests * update package list * Typo * hadolint fixes * hadolint fixes #2 * Cleanup * Rewording
ollo69
pushed a commit
that referenced
this pull request
Nov 21, 2021
* Remove old migrations from KNX integration * Remove cover migration
ollo69
pushed a commit
that referenced
this pull request
Dec 31, 2021
* Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Bump aioshelly * Bump fritzconnection and remove workarounds * Cleanup fritzbox_callmonitor * Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Update homeassistant/components/shelly/utils.py Co-authored-by: Shay Levy <[email protected]> * Update homeassistant/components/shelly/__init__.py Co-authored-by: Shay Levy <[email protected]> * Revert slipped in commit * Rename param * Apply review comment * Apply comment review #2 Co-authored-by: Shay Levy <[email protected]>
ollo69
pushed a commit
that referenced
this pull request
Jan 7, 2022
ollo69
pushed a commit
that referenced
this pull request
Jan 7, 2022
ollo69
pushed a commit
that referenced
this pull request
Jan 7, 2022
…t#63522)" (home-assistant#63561) This reverts commit 1baa3d8.
ollo69
pushed a commit
that referenced
this pull request
May 23, 2022
* First version of laundrify integration * Code cleanup * Code cleanup after review #2 * Move coordinator to its own file * Save devices as dict and implement available prop as fn * Validate token on init, abort if already configured * Some more cleanup after review * Add strict type hints * Minor changes after code review * Remove OptionsFlow (use default poll interval instead) * Fix CODEOWNERS to pass hassfest job * Fix formatting to pass prettier job * Fix mypy typing error * Update internal device property after fetching data * Call parental update handler and remove obsolete code * Add coordinator tests and fix some config flow tests * Refactor tests * Refactor fixtures * Device unavailable if polling fails
ollo69
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Increase file upload limit to 100 MB * Remove comment * Add test and fix chunk processing * Add test for wrong field * Add review suggestions * Use nonlocal and remove unneeded executor task * Use Janus to process chunk uploading * Address review comments * Address review comments #2 * Improve tests * Fix discovery test * Fix tests
ollo69
pushed a commit
that referenced
this pull request
Dec 27, 2023
* initial work on alarm * final work on alarm * coveragerc * add tests * add code validation * remove sensor changes for a dedicated PR * code optimization and cleanup * tweaks * tweak #2 * apply suggestion * code quality * code quality #2 * fix cover.py * api typing * use base classes where possibile * apply const as per review comment * cleanup unload entry * apply review comments
ollo69
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Initial commit for fyta integration * Update __init__.py Delete BinarySensor for first PR * Update __init__.py Rewind wrongful deletion of comma * Delete homeassistant/components/fyta/binary_sensor.py Delete binary_sensor for first pr of integration * Update manifest.json Updated requirement to new version of fyta_cli 0.2.1, where bug in import of modules has been resolved. * Update requirements_test_all.txt adjust to updated manifest * Update requirements_all.txt adjust to updated manifest * Update test_config_flow.py * Update config_flow.py update file to correct error with _entry attribute * Fyta integration - update initial PR based on review in initial PR home-assistant#110816 (#2) * adjustments to pass test for config_flow * backport of changes in intitial PR to dev * update text_config_flow * changes based on review in initial PR home-assistant#110816 * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/strings.json Co-authored-by: Sid <[email protected]> * Update homeassistant/components/fyta/strings.json Co-authored-by: Sid <[email protected]> * Update homeassistant/components/fyta/manifest.json Co-authored-by: Sid <[email protected]> * Adjustments based on PR-commet of Feb 19 (#3) * add test for config_flow.validate_input * update based on pr review * update based on pr review * further refinings based on PR review * Update tests/components/fyta/test_config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update test_config_flow.py Update tests based on PR comment * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * add handling and test for duplicate entry * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/sensor.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/entity.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update test_config_flow.py parametrize test for exceptions * Update config_flow.py Move _async_abort_entries_match, add arguments * Update coordinator.py * Update typing in coordinator.py * Update coordinator.py update typing * Update coordinator.py corrected typo * Update coordinator.py * Update entity.py * Update sensor.py * Update icons.json * Update homeassistant/components/fyta/entity.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/entity.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update entity.py * Update test_config_flow.py * Update config_flow.py (change FlowResult to ConfigFlowResult) * Update config_flow.py * Update homeassistant/components/fyta/config_flow.py Co-authored-by: Robert Resch <[email protected]> * Update homeassistant/components/fyta/config_flow.py Co-authored-by: Robert Resch <[email protected]> * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Robert Resch <[email protected]> * Update coordinator.py * Update config_flow.py (typing FlowResult -> ConfigFlowResult) * Update config_flow.py * Aktualisieren von config_flow.py * remove coordinator entities * Update strings.json remove plant_number * Update icons.json remove plant_number * Update manifest.json Update requirement to latest fyta_cli version * Update requirements_all.txt * Update requirements_test_all.txt * Update homeassistant/components/fyta/sensor.py * Update homeassistant/components/fyta/sensor.py * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/coordinator.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/entity.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/strings.json Co-authored-by: Joost Lekkerkerker <[email protected]> * Update homeassistant/components/fyta/strings.json Co-authored-by: Joost Lekkerkerker <[email protected]> * Update tests/components/fyta/test_config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * Update tests/components/fyta/test_config_flow.py Co-authored-by: Joost Lekkerkerker <[email protected]> * move test-helpers into conftest.py, adjust import of coordinator.py --------- Co-authored-by: Joost Lekkerkerker <[email protected]> Co-authored-by: Sid <[email protected]> Co-authored-by: Robert Resch <[email protected]>
ollo69
pushed a commit
that referenced
this pull request
Jun 24, 2025
* clean pull request * Create one device per console * Requested changes * Pr/tr4nt0r/1 (#2) * clean pull request * Create one device per console * device setup * Merge PR1 - Dynamic Device Support * Merge PR1 - Dynamic Device Support --------- Co-authored-by: tr4nt0r <[email protected]> * nitpicks * Update config_flow test * Update quality_scale.yaml * repair integrations.json * minor updates * Add translation string for invalid account * misc changes post review * Minor strings updates * strengthen config_flow test * Requested changes * Applied patch to commit a358725 * migrate PlayStationNetwork helper classes to HA * Revert to standard psn library * Updates to media_player logic * add default_factory, change registered_platforms to set * Improve test coverage * Add snapshot test for media_player platform * fix token parse error * Parametrize media player test * Add PS3 support * Add PS3 support * Add concurrent console support * Adjust psnawp rate limit * Convert to package PlatformType * Update dependency to PSNAWP==3.0.0 * small improvements * Add PlayStation PC Support * Refactor active sessions list * shift async logic to helper * Implemented suggested changes * Suggested changes * Updated tests * Suggested changes * Fix test * Suggested changes * Suggested changes * Update config_flow tests * Group remaining api call in single executor --------- Co-authored-by: tr4nt0r <[email protected]> Co-authored-by: Joost Lekkerkerker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: