remove executable bit for various files

[svenevs]

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

• I agree to contribute to the project under Apache 2 License.
• To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
• The PR is proposed to proper branch.
  • AFAICT this is desired on 3.4 rather than master.
  • BUT do note that master branch has other files affected not in 3.4. Easy to do a separate PR for master-master if desired, let me know 🙂
• There is reference to original bug report and related work.
  • Do you want me to create an issue to have this fix it?
• There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. Not applicable.
• The feature is well documented and sample code can be built with the project CMake. It built for me. But I don't think that comprehensively tests things. It's not a feature though 🙂

---

Remove executable bits from files that do not need it. Including steps taken to identify for help in review, feel free to force push over my branch or alternatively fix it directly without a PR from me. See bottom checklist for "outliers".

# Finding the files that are executable
$ find . -type f -executable -not -path "*/.git/*"

The available file extensions for consideration:

$ find . -type f -executable -not -path "*/.git/*" -exec /bin/sh -c 'bname="$(basename {})"; echo ${bname##*.}' \; | sort | uniq
bib
binaryproto
caffemodel
cmake
cpp
h
hpp
jpg
markdown
md
ply
png
prototxt
py
sh
txt

Assuming sh and py files are correctly executable, some of these file types can be fixed as is but some I am not sure whether the executable bit matters. In this PR I'm removing it from everything except for sh and py files.

# To exclude more easily, just add another
#   -and -not "*.[ext to keep executable]"
# switch there at the end.
$ find . -type f -executable -not -path "*/.git/*" -and -not -name "*.sh" -and -not -name "*.py"

Then to actually fix the permissions you just want to, now that we have the right listing, execute chmod -x:

$ find . -type f -executable -not -path "*/.git/*" -and -not -name "*.sh" -and -not -name "*.py" -exec chmod -x {} \;

and to check what went down, look for executable files again without pruning (except for .git folder):

$ find . -type f -executable -not -path "*/.git/*"
./samples/python2/seeds.py
./samples/python2/common.py
./samples/python2/video.py
./modules/reg/samples/reg_shift.py
./modules/optflow/samples/motempl.py
./modules/face/samples/etc/crop_face.py
./modules/face/samples/etc/create_csv.py
./modules/cnn_3dobj/samples/datagen_front.sh
./modules/cnn_3dobj/samples/datagen_all.sh
./modules/cnn_3dobj/samples/datagen_back.sh
./modules/cnn_3dobj/samples/featstore.sh
./modules/dnns_easily_fooled/download_caffe_gradient_ascent.sh
./modules/dnns_easily_fooled/download_sferes.sh
./modules/dnns_easily_fooled/download_caffe_evolutionary_algorithm.sh

Unofficially labeling these as "outliers", do any of the below need to have the executable bit removed? As far as I could tell it's correct but I didn't look super close and don't use most of these modules.

• ./samples/python2/seeds.py
• ./samples/python2/common.py
• ./samples/python2/video.py
• ./modules/reg/samples/reg_shift.py
• ./modules/optflow/samples/motempl.py
• ./modules/face/samples/etc/crop_face.py
• ./modules/face/samples/etc/create_csv.py
• ./modules/cnn_3dobj/samples/datagen_front.sh
• ./modules/cnn_3dobj/samples/datagen_all.sh
• ./modules/cnn_3dobj/samples/datagen_back.sh
• ./modules/cnn_3dobj/samples/featstore.sh
• ./modules/dnns_easily_fooled/download_caffe_gradient_ascent.sh
• ./modules/dnns_easily_fooled/download_sferes.sh
• ./modules/dnns_easily_fooled/download_caffe_evolutionary_algorithm.sh

[alalek]

Looks good to me! Thank you 👍

Keeping executable .py samples is OK.