Skip to content

BUG Series rolling count ignores min periods #31319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 165 commits into from
Closed

BUG Series rolling count ignores min periods #31319

wants to merge 165 commits into from

Conversation

fujiaxiang
Copy link
Member

This PR targets 1.0.x branch and is a manual backport for #30923

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jbrockmendel and others added 30 commits January 9, 2020 18:11
@jbrockmendel @WillAyd
CLN: remove unnecessary overriding in subclasses (pandas-dev#30875)
b7fcb54
@jorisvandenbossche @TomAugspurger
DEPR: fix missing stacklevel in pandas.core.index deprecation (pandas…
6f2c509 
…-dev#30878)
@gfyoung
DOC: Encourage use of pre-commit in the docs (pandas-dev#30864)
d1b9598 
Previously, we stated it as merely optional

xref:

pandas-dev#30773
pandas-dev#30814
@datapythonista @gfyoung
WEB: Removing Discourse links (pandas-dev#30890)
447a3b0 
We are not using them for now.
@datapythonista @WillAyd
WEB: Remove from roadmap moving the docstring script (pandas-dev#30893)
03cdcb6
@ShaharNaveh @simonjayhawkins
TYP: typing annotations (pandas-dev#30901)
0b4bac7
@jbrockmendel @simonjayhawkins
TYP: offsets (pandas-dev#30897)
f887eb0
@jbrockmendel @simonjayhawkins
BUG: pickle files left behind by tm.round_trip_pickle (pandas-dev#30906)
6e9651e
@fujiaxiang
BUG: Series rolling count ignores min_periods (GH26996)
398bf7d
@HH-MWB @WillAyd
replace syntax with f-string (pandas-dev#30919)
7f2948c
@dinasv @WillAyd
CLN: F-strings (pandas-dev#30916)
939e7dd
@gfyoung @WillAyd
DOC: Fixture docs in pandas/conftest.py (pandas-dev#30917)
b47a454
@jbrockmendel @gfyoung
CLN: remove unnecesary _date_check_type (pandas-dev#30932)
75ecfa4 
The check doesn't do anything, and we still a raise KeyError anyways
@galuhsahid @gfyoung
DOC: Fix SS03 docstring error (pandas-dev#30939)
044559a 
xref:

pandas-dev#27977
pandas-dev#30733
@topper-123 @simonjayhawkins
TYP: type up parts of series.py (pandas-dev#30761)
28e909c
@ShaharNaveh @jbrockmendel
STY: wrong placed space in strings (pandas-dev#30940)
4e2546d
@jschendel @jorisvandenbossche
DOC: Fix whatsnew contributors section (pandas-dev#30926)
45580a2
@jbrockmendel @jorisvandenbossche
CI: numpydev changed double to single quote (pandas-dev#30952)
439d629
@jbrockmendel @simonjayhawkins
CLN: leftover ix checks (pandas-dev#30951)
46c2864
@souvik3333 @simonjayhawkins
DOC: Move import conventions from wiki to docs pandas-dev#30808 (pand…
bbccf2d 
…as-dev#30888)
@ryankarlos @simonjayhawkins
DOC: Move couple of deprecations whatsnew to correct section (pandas-…
2c76d06 
…dev#30961)
@ShaharNaveh @simonjayhawkins
STY: concat strings that should not be seperated (pandas-dev#30942)
62d16ab
@TomAugspurger
REGR: Fixed hash_key=None for object values (pandas-dev#30900)
dd6e31a 
* REGR: Fixed hash_key=None for object values

Closes pandas-dev#30887
@jbrockmendel @WillAyd
CLN: remove no-op from indexing (pandas-dev#30934)
bd63ece
@MarcoGorelli @TomAugspurger
BUG: -1 to the power of pd.NA was returning -1 (pandas-dev#30960)
7ba53f0
@topper-123 @simonjayhawkins
TYP: NDFrame.resample (pandas-dev#30947)
67fcdef
@WillAyd @jorisvandenbossche
DOC: whatsnew for 1.1 (pandas-dev#30972)
993fdbe
@jbrockmendel @WillAyd
CLN: misc cleanups (pandas-dev#30877)
6928327
@TomAugspurger
Compat for util.testing import (pandas-dev#30973)
2bf0c9f 
* Compat for util.testing import

Closes pandas-dev#30869
@ShaharNaveh @WillAyd
STY: concat strings (pandas-dev#30979)
307137c
fujiaxiang and others added 24 commits January 21, 2020 10:46
@fujiaxiang
TST: added more tests (GH26996)
bfe10f0
@fujiaxiang
Merge branch 'master' into series_rolling_count_ignores_min_periods
1a90629
@rebecca-palmer @simonjayhawkins
Remove possibly illegal test data (pandas-dev#31146)
964400d
@fujiaxiang @simonjayhawkins
BUG: concat not copying index and columns when copy=True (pandas-dev#…
7ffcf9d 
…31119)
@fujiaxiang
Merge remote-tracking branch 'upstream/master' into series_rolling_co…
be0926b 
…unt_ignores_min_periods
@fujiaxiang
BUG: updated rolling and expanding count for consistency (GH26996)
c0046b6 
Updated the behavior of rolling and expanding count so that it becomes consistent with all other rolling and expanding functions.
Also updated many test cases to reflect this change of behavior.
@jbrockmendel @WillAyd
ENH: partial string indexing on non-monotonic PeriodIndex (pandas-dev…
4050e4c 
…#31096)
@mroeschke
TST: Add more regression tests for fixed issues (pandas-dev#31171)
d77b1d8 
* TST: Add more regression tests for fixed issues

* Fix lint and platform compat

* Using intp

* Move interval indexing test to appropriate location
@nschloe @WillAyd
COMPAT: numpy test warnings (pandas-dev#30345)
e31c5ad
@jbrockmendel @WillAyd
REF: move misplaced tests (pandas-dev#31189)
c3f492f
@jbrockmendel @jorisvandenbossche
CLN: remove unused fixtures (pandas-dev#31192)
6dea557
@jbrockmendel @TomAugspurger
REG: restore format_type attr (pandas-dev#31017)
f4c99ff 
* REG: restore format_type attr
@TomAugspurger
CI: numpydev ragged array dtype warning (pandas-dev#31203)
6752833
@fujiaxiang
CLN: further cleaned code (GH26996)
8807ba1
@TomAugspurger
DOC: fixup whatsnew (pandas-dev#31217)
118dc6c
@Rik-de-Kort @WillAyd
Follow-up: XLSB Support (pandas-dev#31215)
774498b
@ShaharNaveh @WillAyd
Replaced set comprehension with a generator (pandas-dev#31229)
6f395ad
@TomAugspurger @jreback
BUG: Fixed upcast dtype for datetime64 in merge (pandas-dev#31211)
e83a6bd
@fujiaxiang
Merge remote-tracking branch 'upstream/master' into series_rolling_co…
7aa1582 
…unt_ignores_min_periods
@fujiaxiang
TST: cleaned up tests (GH26996)
bcce129
@fujiaxiang
BUG: changed min_periods default to 0 for rolling and expanding (GH26…
1a4352b 
…996)
@fujiaxiang
BUG: reverted non-relevant changes accidentally added (GH26996)
9fa4531
@fujiaxiang
BUG: small change in whatsnew (GH26996)
987c033
@fujiaxiang
CLN: slight cleanup (GH26996)
a00532a
@fujiaxiang fujiaxiang mentioned this pull request Jan 26, 2020
Merged
5 tasks
@jreback
Copy link
Contributor

jreback commented Jan 26, 2020

you need to clone the 1.0.x branch and cherry-pick this.

@fujiaxiang
Copy link
Member Author

got it, will close this PR

@fujiaxiang fujiaxiang closed this Jan 26, 2020
@jreback
Copy link
Contributor

jreback commented Jan 26, 2020

k you could have actually pushed to this branch after you rebased but ok

@fujiaxiang fujiaxiang deleted the series_rolling_count_ignores_min_periods branch January 26, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.