fix: Setting a keyboard shortcut to its default value creates an unnecessary dashboard config storage entry

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Issue

Setting a keyboard shortcut to its default value creates an unnecessary dashboard config storage entry.

Summary by CodeRabbit

• Bug Fixes

  • Improved keyboard shortcuts reset functionality with safer validation checks.
  • Enhanced error handling and logging for keyboard shortcuts operations.

• Improvements

  • Optimized keyboard shortcuts storage to only save custom configurations, reducing unnecessary data storage.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified keyboard shortcuts management to conditionally save or delete shortcuts based on default value comparison, and enhanced reset functionality with defensive server config checks and error handling with logging.

Changes

Cohort / File(s)	Summary
Keyboard Shortcuts Management src/lib/KeyboardShortcutsPreferences.js	Modified saveKeyboardShortcuts to conditionally save or delete entries based on default comparison. Enhanced resetKeyboardShortcuts with server config validation and targeted error handling. Added isServerConfigEnabled() method to determine if server configuration is active.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: Add keyboard shortcuts for quick actions in data browser #3073: Modifies the same KeyboardShortcutsManager methods in KeyboardShortcutsPreferences.js, including server-config checks and save/reset logic adjustments.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is incomplete. It lacks the Approach section describing the specific changes made and the Tasks section documenting test/documentation updates.	Add an Approach section explaining how the fix works (conditional save/delete logic based on default comparison) and complete the Tasks section to indicate whether tests and documentation updates are included.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: preventing unnecessary storage entries when keyboard shortcuts are set to default values.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[parseplatformorg]

🎉 This change has been released in version 8.3.0-alpha.43