feat: Add keyboard shortcut for executing script on selected rows in data browser

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Summary by CodeRabbit

• New Features
  • Added configurable keyboard shortcut to run scripts on selected rows in the Data Browser.
  • Keyboard shortcut support extended to include the meta (Command/Windows) modifier.
  • Settings UI updated to let users view and customize the Run Script on Selected Rows shortcut.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a configurable "Run Script on Selected Rows" keyboard shortcut, meta-key support for shortcuts, settings UI for the new shortcut, and wiring to DataBrowser and BrowserToolbar to trigger script execution for selected rows.

Changes

Cohort / File(s)	Summary
Keyboard Shortcuts Core src/lib/KeyboardShortcutsPreferences.js	Added meta field to DEFAULT_SHORTCUTS and new dataBrowserRunScriptOnSelectedRows entry. Updated createShortcut(key, meta = false) signature and return shape. matchesShortcut now compares shortcut.meta with event.metaKey. Validation updated to accept meta.
Settings UI src/dashboard/Settings/KeyboardShortcutsSettings.react.js	Added dataBrowserRunScriptOnSelectedRows to state/load/save flow and validation. Introduced a UI field for configuring the new shortcut and included it in saved shortcuts.
Data Browser + Toolbar src/dashboard/Data/Browser/DataBrowser.react.js, src/dashboard/Data/Browser/BrowserToolbar.react.js	DataBrowser handleKey now ignores keys when a modal is open, refines input-target checks, matches dataBrowserRunScriptOnSelectedRows and calls onExecuteScriptRows(selection) when selection exists. DataBrowser passes uppercased runScriptShortcut prop to BrowserToolbar; BrowserToolbar forwards it to the Script Run MenuItem as shortcut.

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant DB as DataBrowser
    participant KS as KeyboardShortcutsPreferences
    participant SE as ScriptExecution
    participant TB as BrowserToolbar

    User->>DB: press keys
    DB->>KS: matchesShortcut(event, dataBrowserRunScriptOnSelectedRows)
    KS-->>DB: match result
    alt shortcut matches and selection non-empty
        DB->>SE: onExecuteScriptRows(selection)
        SE-->>DB: execution result
        DB->>DB: preventDefault()
    end
    DB->>TB: pass runScriptShortcut prop
    TB->>TB: display shortcut in Script Run MenuItem

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: Add keyboard shortcuts for quick actions in data browser #3073 — Modifies keyboard-shortcuts core and settings; directly related to the new shortcut entry and prefs handling.
• feat: Execute scripts via right-click on info panel header column #3068 — Adds script execution UI/flows in DataBrowser; related to invoking script runs for selected rows.
• feat: Add Settings menu to scroll info panel to top when browsing through rows #2937 — Changes DataBrowser/BrowserToolbar wiring and props; relevant overlap in component APIs.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is missing critical required sections including Issue/Closes link, Approach details, and incomplete Tasks checklist.	Complete the description by adding the issue link in the 'Closes' field, describing the approach/changes made, and updating the Tasks checklist to reflect work completed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a keyboard shortcut feature for executing scripts on selected rows in the data browser.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/dashboard/Settings/KeyboardShortcutsSettings.react.js (1)

112-117: ⚠️ Potential issue | 🟡 Minor

Duplicate shortcut detection misses the new key.

Currently only two shortcuts are compared, so the new shortcut can silently collide and create ambiguous behavior. Please include dataBrowserRunScriptOnSelectedRows in the uniqueness check.

🔧 Suggested fix

-    // Check for duplicates among shortcuts without meta modifier (only if set)
-    if (shortcuts.dataBrowserReloadData && shortcuts.dataBrowserToggleInfoPanels &&
-        shortcuts.dataBrowserReloadData.key.toLowerCase() === shortcuts.dataBrowserToggleInfoPanels.key.toLowerCase()) {
-      this.showNote('Keyboard shortcuts must be unique. Please use different keys.', true);
-      return;
-    }
+    // Check for duplicates among shortcuts without meta modifier (only if set)
+    const keys = [
+      shortcuts.dataBrowserReloadData,
+      shortcuts.dataBrowserToggleInfoPanels,
+      shortcuts.dataBrowserRunScriptOnSelectedRows,
+    ]
+      .filter(Boolean)
+      .map(s => s.key.toLowerCase());
+    if (new Set(keys).size !== keys.length) {
+      this.showNote('Keyboard shortcuts must be unique. Please use different keys.', true);
+      return;
+    }

🤖 Fix all issues with AI agents

In `@src/dashboard/Data/Browser/DataBrowser.react.js`:
- Around line 811-822: The shortcut handler fires before the input-element guard
and doesn't respect editable mode; update the run-script-on-selected-rows block
(the matchesShortcut check for shortcuts.dataBrowserRunScriptOnSelectedRows that
calls this.props.onExecuteScriptRows) to first ensure the event is not coming
from an input/textarea (same guard used elsewhere in this file) and that the
component is editable by checking this.props.onEditSelectedRow exists;
alternatively move this entire block to run after the existing input-element
guard and add a guard requiring this.props.onEditSelectedRow before invoking
this.props.onExecuteScriptRows.

[parseplatformorg]

🎉 This change has been released in version 8.3.0-alpha.41