fix: Graph in canvas ignores date filter constraints

[mtrezza]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Summary by CodeRabbit

• Refactor
  • Centralized and simplified how saved filters are applied, delegating constraint logic to a common implementation.
  • Improved date parsing and handling for filter operations and broadened support for various constraint types.
  • No user-facing behavior changes; filter results remain consistent while internal reliability and maintainability are improved.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaces the local applyFilterToQuery method in CustomDashboard with a call to a new centralized addConstraintFromValues helper in lib/queryFromFilters; query constraint logic (including extensive date and object handling) is moved into the library and a backward-compatible wrapper was added.

Changes

Cohort / File(s)	Summary
CustomDashboard refactor src/dashboard/Data/CustomDashboard/CustomDashboard.react.js	Removes the local applyFilterToQuery(query, filter) method and adds import { addConstraintFromValues } from src/lib/queryFromFilters.js. Replaces per-condition applyFilterToQuery calls with addConstraintFromValues(query, condition.field, condition.constraint, condition.compareTo, condition.modifiers).
Query constraint centralization src/lib/queryFromFilters.js	Adds addConstraintFromValues(query, field, constraint, compareTo, modifiers) plus addConstraint(query, filter) wrapper. Introduces addQueryConstraintFromObject, date utilities (isParseDate, isRelativeDate, toDate), and broadens supported constraints (exists/dne/eq/neq/lt/lte/.../onOrBefore/onOrAfter/containsAny/matches/key* etc.). Replaces many in-file key-specific handlers with unified object-based logic and JSON parsing/validation.

Sequence Diagram(s)

sequenceDiagram
    participant Dashboard as CustomDashboard
    participant Filters as queryFromFilters.addConstraintFromValues
    participant ParseQuery as Parse.Query

    Dashboard->>Filters: iterate saved conditions\ncall addConstraintFromValues(query, field, constraint, compareTo, modifiers)
    Filters->>Filters: normalize compareTo (toDate / parse object)
    Filters->>ParseQuery: apply constraint to Query (add where / key constraints)
    Filters-->>Dashboard: return modified Query
    Dashboard->>ParseQuery: execute query (find / fetch)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: Canvas graph element does not apply data filter option #3128: Previously applied saved filter conditions via the local applyFilterToQuery in CustomDashboard; this PR removes that method and delegates to addConstraintFromValues.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description only contains a checklist but lacks the required sections: no Issue link, no Approach description, and no task completions are documented.	Add the Issue link, describe the changes made (constraint refactoring and date utilities), and document which tasks were completed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main change: fixing graph behavior with date filter constraints by refactoring constraint application logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/lib/queryFromFilters.js`:
- Around line 99-104: Wrap the JSON.parse in addQueryConstraintFromObject with a
try/catch: attempt to parse compareTo, and if parsing throws or the result is
not an object, fall back to applying the constraint directly on the base field
(call query[constraintType](field, compareTo)) instead of iterating keys; keep
the existing behavior for successful parses (iterate
Object.keys(parsedCompareTo) and apply query[constraintType](field + '.' + key,
value)). Ensure the try/catch handles both parse errors and non-object parse
results so malformed JSON doesn't throw.

[parseplatformorg]

🎉 This change has been released in version 8.3.0-alpha.20