Skip to content

feat: Add canvas tree to sidebar instead of loading dialog and favorite functionality#3146

Merged
mtrezza merged 2 commits intoparse-community:alphafrom
mtrezza:feat/canv-fav
Jan 23, 2026
Merged

feat: Add canvas tree to sidebar instead of loading dialog and favorite functionality#3146
mtrezza merged 2 commits intoparse-community:alphafrom
mtrezza:feat/canv-fav

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 23, 2026

Pull Request

Summary by CodeRabbit

  • New Features

    • Dashboard sidebar now shows all canvases, grouped and alphabetically sorted for easier navigation.
  • Bug Fixes

    • Filter lists now toggle open/closed when clicked instead of always expanding.
  • Removed Features

    • Load Canvas dialog removed.
    • Canvas favoriting and the favorite option in the save dialog removed.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 23, 2026

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

This PR removes canvas "favorite" and load-dialog functionality, replaces the favorites-based sidebar with grouped, alphabetically sorted canvases, simplifies the SaveCanvasDialog API, and changes CategoryList click handling to toggle filter list visibility.

Changes

Cohort / File(s) Summary
CategoryList toggle behavior
src/components/CategoryList/CategoryList.react.js
Click handler for classes with filters now toggles the class open state (removes if already open, adds if closed); comment updated.
Dashboard refactor & sidebar
src/dashboard/Data/CustomDashboard/CustomDashboard.react.js
Removed LoadCanvasDialog import/state and currentCanvasFavorite state; added expandedSidebarGroups; changed handleSaveCanvas(name, group, favorite)handleSaveCanvas(name, group); replaced favorites-filtered sidebar with alphabetically sorted, grouped canvases; updated CategoryList props (currentCategory, params, filterClicked) and navigation logic.
Save dialog simplification
src/dashboard/Data/CustomDashboard/SaveCanvasDialog.react.js
Removed currentFavorite prop/state and Toggle UI; onSave callback now called with (name, group) instead of (name, group, favorite); import of Toggle removed.

Sequence Diagram(s)

sequenceDiagram
  participant User as User
  participant Cat as CategoryList
  participant Dash as CustomDashboard
  participant Router as Router/URL

  User->>Cat: click class/filter
  Cat->>Cat: toggle openClasses for class id
  Cat-->>Dash: filterClicked(classId, filterId)
  Dash->>Router: navigate to canvas URL / load canvas
  Router-->>Dash: route params
  Dash-->>User: render selected/grouped canvas in sidebar
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, missing critical sections like Issue link, Approach, and Tasks checklist required by the template. Add the Issue link (Closes: #), describe the Approach/changes, and include the Tasks checklist with appropriate selections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: removing loading/favorite functionality and adding a canvas tree to the sidebar.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/dashboard/Data/CustomDashboard/CustomDashboard.react.js`:
- Around line 1064-1137: The group headers are generating navigable URLs like
canvas/group_<name> — change the CategoryList linkPrefix to target the current
canvas so group headers keep the existing canvas URL while toggling filters: use
linkPrefix={`canvas/${currentCanvasId}${currentCanvasId ? '?' : ''}`} (reference
currentCanvasId, CategoryList props linkPrefix and params, and
filterClicked/navigateToCanvas) so group items still have ids like
`group_<name>` for highlighting but their links resolve to the real canvas URL
with params for filters.

@mtrezza mtrezza changed the title feat: Remove loading and favorite functionality from canvas feat: Add canvas tree to sidebar instead of loading dialog and favorite functionality Jan 23, 2026
@mtrezza mtrezza merged commit e58dc82 into parse-community:alpha Jan 23, 2026
11 of 12 checks passed
@mtrezza mtrezza deleted the feat/canv-fav branch January 23, 2026 18:55
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2026
# [8.3.0-alpha.27](8.3.0-alpha.26...8.3.0-alpha.27) (2026-01-23)

### Features

* Add canvas tree to sidebar instead of loading dialog and favorite functionality ([#3146](#3146)) ([e58dc82](e58dc82))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.3.0-alpha.27

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 23, 2026
parseplatformorg pushed a commit that referenced this pull request Feb 5, 2026
# [8.3.0](8.2.0...8.3.0) (2026-02-05)

### Bug Fixes

* Canvas graph element does not apply data filter option ([#3128](#3128)) ([00ff1aa](00ff1aa))
* Canvas is not expandable or scrollable beyond current view size ([#3140](#3140)) ([cb73122](cb73122))
* Cloud Config parameter modal cannot scroll when content scales beyond visible area ([#3124](#3124)) ([bb6de31](bb6de31))
* Context menu of header cell in info panel does not group related records by class name ([#3122](#3122)) ([230c1e2](230c1e2))
* Context menu sub-menu in data browser vertically misaligned when scrolling in parent menu ([#3120](#3120)) ([2acaa27](2acaa27))
* Dashboard crashes when adding Parse Pointer JSON to array field in data browser ([#3125](#3125)) ([70bf081](70bf081))
* Data browser graph requires value field even when calculated value is defined ([#3127](#3127)) ([53e4f2b](53e4f2b))
* Graph in canvas ignores date filter constraints ([#3137](#3137)) ([6d8b8e6](6d8b8e6))
* Group-by not using custom aggregation type for single-series graph ([#3159](#3159)) ([b8e8891](b8e8891))
* Incorrect percentage and average calculation for calculated values in graphs ([#3152](#3152)) ([14b4d48](14b4d48))
* Info panel auto-scrolling not pausing during UI interaction like text selection or context menu display ([#3165](#3165)) ([bfe4e8a](bfe4e8a))
* Name of calculated value in data browser graph allows leading and trailing spaces ([#3132](#3132)) ([9493b18](9493b18))
* Optimize data browser cell context menu grouping and readability ([#3141](#3141)) ([5c711e1](5c711e1))
* Security upgrade react-router and react-router-dom ([#3107](#3107)) ([b76b9d1](b76b9d1))
* Setting a keyboard shortcut to its default value creates an unnecessary dashboard config storage entry ([#3173](#3173)) ([4949053](4949053))

### Features

* Add auto-scrolling for info panels ([#3149](#3149)) ([3cd8197](3cd8197))
* Add canvas tree to sidebar instead of loading dialog and favorite functionality ([#3146](#3146)) ([e58dc82](e58dc82))
* Add cloning of element in canvas ([#3144](#3144)) ([dec06ad](dec06ad))
* Add context menu in data browser to add cell content or selected text to Cloud Config parameter ([#3123](#3123)) ([9bc5197](9bc5197))
* Add context menu in data browser to get related records from String and Number fields ([#3118](#3118)) ([824bebd](824bebd))
* Add context menu item to get related records for selected text in data browser cell ([#3142](#3142)) ([33d3595](33d3595))
* Add custom dashboard canvas with graphs and data tables ([#3126](#3126)) ([d45c27b](d45c27b))
* Add customizable styles for line and bar series in data browser graph ([#3131](#3131)) ([501dd4b](501dd4b))
* Add customizable Y-axis titles for data browser graphs ([#3130](#3130)) ([2946e64](2946e64))
* Add dialog to execute Cloud Job with parameters ([#3158](#3158)) ([da419e0](da419e0))
* Add expanded view for canvas elements graph, table, view ([#3156](#3156)) ([0ffd767](0ffd767))
* Add field `objectId` to get related records context menu in data browser ([#3161](#3161)) ([2847ccf](2847ccf))
* Add formula-based calculated value to data browser graph ([#3129](#3129)) ([7c5d1b3](7c5d1b3))
* Add keyboard shortcut for executing script on selected rows in data browser ([#3171](#3171)) ([75389ad](75389ad))
* Add more customization options for graphs in canvas ([#3134](#3134)) ([ddbd666](ddbd666))
* Add non-alphanumeric character detection in Cloud Config parameters ([#3143](#3143)) ([1594ec8](1594ec8))
* Add quick-remove button to array parameter in Cloud Config ([#3121](#3121)) ([b632074](b632074))
* Add support for server side storage of Cloud Config parameter history ([#3169](#3169)) ([964e540](964e540))
* Allow adding View elements to canvas ([#3133](#3133)) ([2f2ae9a](2f2ae9a))
* Allow to favorite canvas for quick-access via sidebar menu ([#3135](#3135)) ([1e3a3c7](1e3a3c7))
* Allow to pause auto-scroll of info panel by holding the Option key ([#3160](#3160)) ([db38f14](db38f14))
* Allow to use ESC key to cancel, Cmd + Enter key to submit, Tab key to navigate a modal dialog ([#3172](#3172)) ([debdc09](debdc09))
* Detect and warn about unprintable characters in Cloud Config parameter values ([#3119](#3119)) ([26c909c](26c909c))
* Improve usability and layout of canvas and elements ([#3148](#3148)) ([cd654dc](cd654dc))
* Optimize appearance of graph tick labels on x-axis for date values ([#3147](#3147)) ([a9edcaf](a9edcaf))
* Optimize canvas menu organization ([#3145](#3145)) ([1558826](1558826))
* Replace graph fields with graph series for more customization ([#3157](#3157)) ([51feba4](51feba4))
* Various improvements for auto-scrolling info panel ([#3151](#3151)) ([423d83a](423d83a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants