fix: Group-by not using custom aggregation type for single-series graph

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Summary by CodeRabbit

• Improvements
  • Chart labels are now consistently prefixed with the series or calculation name across pie, bar, and line charts (e.g., "SeriesName (Category)"), including calculated values and grouped keys.
  • Series and calculation titles now have parentheses removed when entered to keep labels clean.
• Tests
  • Label expectations updated to reflect the new consistent prefixing across chart types.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[mtrezza]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

Label construction in GraphDataUtils was changed to always prefix series and calculated-value labels with the series title plus the group/composite key (e.g., "SeriesLabel (groupKey)"). Tests and two UI inputs were adjusted to align with the new labeling/sanitization behavior. No exported APIs were changed.

Changes

Cohort / File(s)	Summary
Labeling & grouping logic src/lib/GraphDataUtils.js	Consolidated label construction to always format group-aware labels as SeriesLabel (groupKey) for pie and SeriesLabel (compositeKey) for bar/line, including calculated values. Replaced heuristic matching with explicit belongsToSeries / belongsToCalc booleans used in aggregation and registry steps.
Tests src/lib/tests/GraphDataUtils.test.js	Updated expected label strings to reflect new prefixing when series titles are present (e.g., Value (A), Profit (B)); datasets unchanged.
UI input sanitization src/dashboard/Data/Browser/GraphDialog.react.js	Series title and calculated-value name inputs now strip parentheses (replace(/[()]/g, '')) on change to prevent ( or ) in titles/names.

Sequence Diagram(s)

(omitted — changes are internal labeling/formatting logic within a single module, not a multi-component control flow)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: Replace graph fields with graph series for more customization #3157 — Modifies src/lib/GraphDataUtils.js around series labeling/grouping; closely related to these label/key naming changes.
• feat: Add formula-based calculated value to data browser graph #3129 — Changes calculated-value processing in GraphDataUtils.js; directly related to the updated calculated-value aggregation and labeling.
• fix: Data browser graph requires value field even when calculated value is defined #3127 — Also touches calculated-value handling and acceptance in GraphDataUtils.js; relevant to the belongs-to/labeling adjustments.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is largely incomplete, missing the critical sections: Issue link, Approach explanation, and Tasks checklist that are required by the repository template.	Complete the description by adding: (1) Issue link under 'Closes:', (2) Summary of changes/approach under 'Approach', (3) Checked tasks indicating what was added/updated.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: changing group-by behavior for single-series graphs to use custom aggregation types, which aligns with the core labeling and grouping logic changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/lib/GraphDataUtils.js`:
- Around line 816-817: The calc group key is being set to just compositeKey so
calcValueOperatorMap lookup fails when there are only calculated values with
groupBy; update the key construction used in the calc grouping code to match the
series prefixing logic (i.e., prefix with seriesLabel like in the series
grouping block) so that groupKeyValue becomes `${seriesLabel}
(${compositeKey})`; modify the calc grouping branch that references
groupKeyValue/calcValueOperatorMap to use the same labeling as the series code
path (ensure references to groupKeyValue, seriesLabel, compositeKey, and
calcValueOperatorMap are updated consistently).

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/lib/GraphDataUtils.js`:
- Around line 974-977: The current belongsToSeries check (using groupKey ===
seriesLabel or groupKey.startsWith(`${seriesLabel} (`)) can produce false
positives when seriesLabel itself contains " ("; update the logic in the block
that defines belongsToSeries to use a regex match that escapes seriesLabel and
enforces the delimiter boundary (e.g., match either exact seriesLabel or
seriesLabel followed by a space and an opening parenthesis) so labels like "Foo
(bar)" don't incorrectly match "Foo (bar) (GroupValue)"; ensure you escape
special regex chars from seriesLabel before building the pattern and reference
the symbols groupKey, seriesLabel, and belongsToSeries when making the change.

[parseplatformorg]

🎉 This change has been released in version 8.3.0-alpha.36