[DO NOT MERGE] Standalone activity payload test w/ fixes #8700
+83
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changed? - Use immutable chasm context to access node when doing validations ## Why? - Validation doesn't change component state and nothing needs to be persisted. - Some parts of the system skips persistence when component access fail on validation step, if node is marked dirty, a dirty mutable state panic will be triggered upon releasing the execution lock. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
…onent root (#8595) # What changed? - Only add the Workflow root CHASM component if no root component already exists. - I think the overall feature should probably also be behind a feature flag. ## Why? - CHASM Scheduler functional tests are broken without this fix (scheduler mutable states 'become' chasmworkflows)
…8638) ## What changed? Changed the condition to check whether the root component of the chasm tree has been initialized for new workflows ## Why? The root component is never actually empty since we are using `NewEmptyTree` which sets a root component with no type ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Cherry-picking a few fixes
Why?
So that history service can run with chasm enabled in a test cell
How did you test it?