Skip to content

Fix a bug in tying OPT embeddings - #1

Merged
WoosukKwon merged 1 commit into
mainfrom
fix-opt
Feb 25, 2023
Merged

WoosukKwon merged 1 commit into
mainfrom
fix-opt

Conversation

@WoosukKwon

Copy link
Copy Markdown
Collaborator

This PR fixes a bug in supporting OPT-350m/OPT-6.7b/OPT-13b and OPT-IML models.

The bug happened because our model code didn't include some methods that were required to tie the input and output embeddings.

@WoosukKwon
WoosukKwon merged commit cbf8779 into main Feb 25, 2023
@WoosukKwon
WoosukKwon deleted the fix-opt branch February 25, 2023 00:29
CZT0 referenced this pull request in semedia-tech/vllm Sep 11, 2023
orangetin referenced this pull request in togethercomputer/vllm-ttgi Sep 14, 2023
add rope scaling as a cli arg so openai server can load rope scaled models
bigPYJ1151 referenced this pull request in bigPYJ1151/vllm Oct 30, 2023
Fix key cache block shape.
l1cacheDell pushed a commit to CaspianFang/vllm that referenced this pull request Nov 15, 2023
hongxiayang referenced this pull request in hongxiayang/vllm Feb 13, 2024
ilya-lavrenov referenced this pull request in ilya-lavrenov/vllm Feb 19, 2024
Deterministic OpenVINO inference
daniel-geon-park added a commit to gmlwns2000/vllm-timber that referenced this pull request Apr 15, 2024
mzusman pushed a commit to mzusman/vllm that referenced this pull request Apr 16, 2024
BA-78554: Jurassic 2.5

* worked on jurasic2.5 configuration file, updated jurassic2_5 modeling file to support alternating experts/attn layers

* finished working the forward pass of jurassic3.py

* finished working the forward pass of jurassic3.py

* finished working the forward pass of jurassic3.py

* jurassic_3 modeling file works, uses dummy weights initialized by "dummy" flag. Tokenizer raises issues, for now copying the mixtral tokenizer

* changed default tokenizer vocab values, loading of custom .pt weight files works.

* removed notebook

* merging master to jurassic-2.5 to reset head

* Merge branch 'master' into jurassic-2.5

* align to master

Approved-by: Tomer Asida
Approved-by: Mor Zusman
Bellk17 added a commit to Bellk17/vllm that referenced this pull request May 10, 2024
ykim362 referenced this pull request in ykim362/vllm Jun 17, 2024
Group Gemm Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant