Skip to content

match problem-specifications versions #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 5, 2018
Merged

match problem-specifications versions #634

merged 19 commits into from
Jan 5, 2018

Conversation

petertseng
Copy link
Member

Mostly no-ops

This script helps:

require 'json'
pr = ARGV[0]

exercise = `pwd`.chomp.split(?/).last
ver = JSON.parse(File.read("../../../problem-specifications/exercises/#{exercise}/canonical-data.json"))['version']
haskell_ver = Integer(`grep version: package.yaml`.chomp[-1])

`sed -i'' -e "s/^version: .*/version: #{ver}.#{haskell_ver + 1}/" package.yaml`

m = "#{exercise}: #{ver}.#{haskell_ver + 1}: no-op declare compliance with #{ver}

input object

https://github.com/exercism/problem-specifications/pull/#{pr}"

`git commit --all -m '#{m}'`

puts m

Remaining to do: alphametics adds big test which I'll probably comment out for time? We'll see

list-ops just haven't gotten around to using the exact same tests

palindrome-products not using Maybe

(example would have failed with `empty list` when trying to use `last xs`)

2.1.0: no-op, input object
exercism/problem-specifications#1053
2.2.0: forbid empty
exercism/problem-specifications#1055
We must have misnumbered; we have never had a 1.1.0, not now nor ever.

1.0.1:
exercism/problem-specifications#771
2.0.1: first/second -> input/output
exercism/problem-specifications#1004

The input/output bases are not positional. It would make more sense for
the descriptions to refer to them explicitly, rather than an assumed
order.

2.1.0: no-op input object
exercism/problem-specifications#1034
@petertseng petertseng merged commit 141b67d into exercism:master Jan 5, 2018
@petertseng petertseng deleted the ver branch January 5, 2018 07:24
petertseng pushed a commit that referenced this pull request Jan 31, 2018
This reverts commit 07c7426.
This reverts #634.

In exercism/problem-specifications#1027 three
error cases were removed by the result of a coin flip. Since that is
insufficient reason to remove them from the Haskell track, the Haskell
track chooses to keep them, and needs no further justification to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant