Implement private repository limits

[mvdkleijn]

Since @kasbah does not appear to have time to continue his work on PR #6184 I started looking at continuing his work. As there have been many changes to master since, I felt it was easier to start fresh.

Fixes #3653. Feedback very much appreciated.

• Adjust User model
• Adjust repo model
• Check fields when creating repositories
• Add locale entries
• Add setting to admin interfaces
• Adjust TransferOwner counts
• Adjust DeleteRepo counts
• Adjust checkers
• Add tests
• Check what happens if ownership of a private repositories is transferred to a user at the limit
• Test in a local install

For clarity: what I'm going for here is that the current num_repos / max_repo_creation stuff is equal to the public number of repos. For private repos, I'm adding new counts and admin screen entries.

[codecov-commenter]

Codecov Report

Merging #12705 into master will increase coverage by 0.01%.
The diff coverage is 21.21%.

@@            Coverage Diff             @@
##           master   #12705      +/-   ##
==========================================
+ Coverage   43.30%   43.31%   +0.01%     
==========================================
  Files         646      646              
  Lines       71625    71657      +32     
==========================================
+ Hits        31016    31039      +23     
- Misses      35591    35594       +3     
- Partials     5018     5024       +6     

Impacted Files	Coverage Δ
models/error.go	35.02% <0.00%> (+0.21%)	⬆️
routers/repo/repo.go	32.20% <0.00%> (-0.51%)	⬇️
models/repo.go	55.55% <20.00%> (-0.14%)	⬇️
models/user.go	53.26% <33.33%> (-0.30%)	⬇️
modules/setting/repository.go	58.49% <100.00%> (+0.79%)	⬆️
modules/indexer/stats/db.go	43.47% <0.00%> (-17.40%)	⬇️
modules/indexer/stats/queue.go	64.70% <0.00%> (-11.77%)	⬇️
services/pull/pull.go	41.57% <0.00%> (ø)
modules/log/event.go	57.54% <0.00%> (+0.94%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda9e51...7ba71c8. Read the comment docs.

[zeripath]

Ah so you intend to split the repo creation limits so that MaxCreationLimit only applies to public repositories and MaxPrivateCreationLimit only applies to private repositories.

This will essentially double users repo creation limits. You would be better off having a third limit MaxPublicCreationLimit.

You also need to handle what happens when a public repo becomes private and vice versa - see models/repo.go:1417:func updateRepository(...).

There is also the issue of ForkedRepos when their base repos have their visibility changed to private then the fork has to become private. How does that affect this?

[mvdkleijn]

Thanks for the comments, I'm still working through the source code to see what's arranged where... and it was 02:30 when I was committing this. 🤣

My initial thought was to split them. You want to have a limit for private, public and total? That would mean a user could have 2 private, 2 public and 3 total for example... leading to faulty settings and yet another error case needing to be checked. Or is that not what you meant?

As for the ForkedRepos.... When a user forks a repo, doesn't the fork become a mostly separate copy in its own right? I haven't tested it, but I'd be surprised if, on GitHub, a forked repo suddenly becomes private if the original repo does so. I don't really see the point of forcing forks to become private since, instead of forking, someone could just clone the original when it was still public and then push it as a new public repo with the same content as the original. Effectively bypassing the "forked" status.

[zeripath]

You want to have a limit for private, public and total? That would mean a user could have 2 private, 2 public and 3 total for example... leading to faulty settings and yet another error case needing to be checked.

I would read that is: A user would be allowed 3 repositories in total: 2 private, 1 public or 1 private, 2 public - up to the user how that's split - it would mean that you could make things private or public as necessary.

As for the ForkedRepos....

On Gitea if the parent repo becomes private - your fork will become private. You can break the fork relationship, and then make it public if you like.

This is particularly important if you have forked an organizations repos - a fork of a private organisation's repos is private even if the repo is a "public" repo of that organization. So if you make an organization private then all repos forked from its repos will become private.

[6543]

just idears: different limits for: forks, public and private repos
-> let's say a user is allowd to have 1 private, 10 public and kan fork as he like ( to contribute to other projects ... )

note: forks can be conferted to normal repos, before this hapen a check has to happen again too ...

[mvdkleijn]

just idears: different limits for: forks, public and private repos
-> let's say a user is allowd to have 1 private, 10 public and kan fork as he like ( to contribute to other projects ... )

note: forks can be conferted to normal repos, before this hapen a check has to happen again too ...

For the purposes of this PR, I'm going to limit it to public and private repo counts. A forked repo is also either public or private so it'll count against either the public or the private count.

[mvdkleijn]

Right! F-ed this up good. A combination of laptop performance issue, a fault between keyboard and chair as well as a four year old screaming in my ears. 🤣

I'll close this PR and re-create a new one that's not f-ed up. Sorry about this! 😄