Skip to content

Always create the error when a native error message exceeds the string length limit - #39481

Closed
robobun wants to merge 1 commit into
mainfrom
farm/17c6b3de/error-message-too-long
Closed

robobun wants to merge 1 commit into
mainfrom
farm/17c6b3de/error-message-too-long

Conversation

@robobun

@robobun robobun commented Aug 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • A native error whose formatted message is longer than the string length limit is never created. In a release build a failing expect() whose failure message is over the limit reports as (pass); a debug build panics with assertion failed: self.has_exception() in JSGlobalObject::throw (src/jsc/JSGlobalObject.rs:815 on main), reached from Expect::throw_rendered.
  • Same cause, different callers: Bun.listen({ unix }) with a path whose "Failed to listen at ..." message is over the limit segfaults in release (Segmentation fault at address 0x5) and trips UBSan in debug (bindings.cpp: member call on null pointer of type 'JSC::JSCell'), because src/runtime/socket/Listener.rs:504 creates the error and then puts syscall/errno/address on it. Bun.JSONC.parse of a ~1 MiB token throws the empty value itself (debug aborts on ASSERT(!value.isEmpty()) in JSC__VM__throwError).
  • Cause: BunString__toErrorInstance (src/jsc/bindings/BunString.cpp:144 on main), the one C++ entry behind create_error_instance, EncodedSlice::to_*_error_instance and String::to_*_error_instance for all four error kinds, converts the message with Zig::toStringCopy / toWTFString, which return a null WTF::String when the text is longer than Bun__stringSyntheticAllocationLimit / WTF::String::MaxLength (or the copy fails to allocate). It then returned an empty JSValue. Nothing on that path throws, so JSGlobalObject::throw turned it into JsError::Thrown with no exception pending, and native code unwound as if it had thrown while JS observed nothing. The other callers (dozens of sites: promise rejections, callbacks, put on the result) assume they got an object.
  • Reachable in practice through the 1 MiB floor of setSyntheticAllocationLimitForTesting (tests using it could silently pass) and, without it, through any message over 2^31 characters (expect(<happy-dom Element>).toBeNull() takes ~40s+ on a large tree and then SILENTLY PASSES (throw is lost) #37310 hit this with a rendered happy-dom tree).

Fix

  • BunString__toErrorInstance always creates the error. When the message conversion came back null for a non-empty (or Dead, i.e. already failed to allocate) source, the error carries "The error message exceeds the maximum string length" instead. Name, type and the properties callers add afterwards (code, errno, syscall, ...) are unaffected; a message under the limit is byte-for-byte unchanged.
  • Why a stand-in message rather than throwing or truncating: this is a constructor, not a throwing entry point, and its callers unconditionally throw, reject with, or decorate the result, so the only contract that makes every caller correct is "an error object always comes back" (the reasoning ErrorCodeCache::createError already documents for the ErrorCode path). Truncating here would mean materializing a message of up to 2 GiB; bounding rendered values belongs to the producer (test runner: stop printing shared references without bound in assertion diffs and snapshots #34179 and Cap expect() failure message rendering so huge values cannot swallow the assertion error #37311 do that for expect() and remain useful independently; with this change the throw()-site fallback in Cap expect() failure message rendering so huge values cannot swallow the assertion error #37311 becomes unreachable). For comparison, Node surfaces the analogous case (an assert message that overflows V8's string limit) as RangeError: Invalid string length, so the failure is still reported there as well; here the original error type and properties are kept.
  • JSGlobalObject.rs: the is_empty() / debug_assert!(has_exception()) branches in throw, throw_sys_error and throw_todo are deleted; the constructor can no longer return an empty value. JSC__VM__throwError still asserts a non-empty value in debug builds if that ever regresses.
  • Intentionally not changed: systemErrorToErrorInstance, Bun__createErrorWithCode and the two createAggregateError helpers already always return an object, and their messages are WTF-backed strings built by BunString::create_format, so a missing message there needs a Dead string, i.e. a message over 2^31 characters, which the testing limit cannot reach. EncodedSlice__toDOMExceptionInstance is also left alone: createDOMException gives an empty message its own meaning per exception code (default texts; InvalidURLError stores the message as .input), so a stand-in string would be wrong there.
  • Test: test/js/bun/util/native-error-message-too-long.test.ts, one subprocess per case since the limit is process-wide and the unfixed cases crash:
    • expect(): a failure message of exactly the limit is kept intact, one character past it gets the fallback, a rendered received value past the limit gets the fallback, and an uncaught one is reported by bun test as (fail) with error: The error message exceeds the maximum string length (exit code 1).
    • Bun.listen throws the Error instead of crashing.
    • Bun.JSONC.parse throws a SyntaxError with the fallback; a normal-sized parse error message is unchanged.
  • Verified: every case fails on main in a debug build without the src/ changes (UBSan null member call, abort, panic) and on the last release canary, and all pass with them. Also ran expect-label, expect-unreaachable, plugins.test.ts, socketaddress.spec.ts (covers throw_sys_error), jsonc, error-name-preservation: all pass.

Background

  • BunString / bun_core::String: the tagged string shared between Rust and C++. A WTFStringImpl tag shares an existing JSC string, EncodedSlice borrows Rust bytes (with encoding bits in the pointer) and is copied on the way in, Dead means a creation already failed. create_error_instance and friends format a Rust message into a buffer and hand it over as a UTF-8 EncodedSlice.
  • String length limit: WTF::String::MaxLength is 2^31 - 1 code units. Bun__stringSyntheticAllocationLimit is a process-wide lower cap that bun:internal-for-testing's setSyntheticAllocationLimitForTesting can set down to 1 MiB so tests can exercise the too-long paths without allocating gigabytes; Zig::toStringCopy honours both for EncodedSlice input.
  • JsError::Thrown: the Rust-side marker meaning "a JS exception is now pending in the VM"; host functions return it and the thunk hands control back to JSC expecting vm.exception() to be set. Returning it with nothing pending is how the throw was lost.
  • JSValue::empty() (Rust JSValue::ZERO): JSC's "no value" sentinel, not a JS value; using it as one (put, throwing it, awaiting it) dereferences null.
Notes

The first revision of this PR predates the consolidation of the error constructors into BunString__toErrorInstance (the ZigString rename and the removal of Zig::get*ErrorInstance). It fixed the same defect in helpers.h for the four per-type helpers plus createAggregateError, whose message then arrived as a ZigString and was reachable through the testing limit; on current main that message is a WTF-backed string and the site is covered by the exclusion above. The branch was rebuilt on top of main rather than rebased, so the diff is the one described here.


[review] gate passed · iteration 2 · 3 files touched

fails on main (without fix)
ASAN without fix: 3 FAILED
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/mechgate.xml" test/js/bun/util/native-error-message-too-long.test.ts
bun test v1.4.1 (861e9ae04)

test/js/bun/util/native-error-message-too-long.test.ts:
106 |         `,
107 |       },
108 |       "listen.ts",
109 |     );
110 | 
111 |     expect(report).toEqual({ name: "Error", message: FALLBACK });
                         ^
error: expect(received).toEqual(expected)

  {
-   "message": "The error message exceeds the maximum string length",
-   "name": "Error",
+   "exitCode": 1,
+   "stderr": 
+ "../../src/jsc/bindings/bindings.cpp:4169:70: runtime error: member call on null pointer of type 'JSC::JSCell'
+ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/jsc/bindings/bindings.cpp:4169:70 
+ "
+ ,
+   "stdout": "",
  }

- Expected  - 2
+ Received  + 7

      at <anonymous> (/workspace/bun/test/js/bun/util/native-error-message-too-long.test.ts:111:20)
(fail) native error whose message exceeds the string length limit > Bun.listen, which sets properties on the error before throwing it, throws instead of crashing [2227.49ms]
122 |    
... (truncated)

release without fix: 3 FAILED
bun test v1.4.1-canary.1 (861e9ae04)

test/js/bun/util/native-error-message-too-long.test.ts:
122 |         `,
123 |       },
124 |       "jsonc.ts",
125 |     );
126 | 
127 |     expect(report).toEqual([
                         ^
error: expect(received).toEqual(expected)

  [
    {
-     "message": "The error message exceeds the maximum string length",
+     "message": "",
      "name": "SyntaxError",
    },
    {
      "message": "JSONC Parse error: Unexpected bbb",
      "name": "SyntaxError",
    },
  ]

- Expected  - 1
+ Received  + 1

      at <anonymous> (/workspace/bun/test/js/bun/util/native-error-message-too-long.test.ts:127:20)
(fail) native error whose message exceeds the string length limit > SyntaxError from Bun.JSONC.parse keeps its type and gets the fallback message [45.31ms]
106 |         `,
107 |       },
108 |       "listen.ts",
109 |     );
110 | 
111 |     expect(report).toEqual({ name: "Error", message: FALLBACK });
                         ^
error: expect(received).toEqual(expected)

  {
-   "message": "The error message exceeds the maximum string length",
-   "name": "Error",
+   "exitCode": 139,
+   "stderr": 
+ "===========================
... (truncated)
passes on PR (with fix)
ASAN with fix: all passed
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/mechgate.xml" test/js/bun/util/native-error-message-too-long.test.ts
bun test v1.4.1 (861e9ae04)

test/js/bun/util/native-error-message-too-long.test.ts:
(pass) native error whose message exceeds the string length limit > Bun.listen, which sets properties on the error before throwing it, throws instead of crashing [1783.80ms]
(pass) native error whose message exceeds the string length limit > SyntaxError from Bun.JSONC.parse keeps its type and gets the fallback message [1890.52ms]
(pass) native error whose message exceeds the string length limit > failing expect() throws an Error and bun test reports the failure [3153.53ms]

 3 pass
 0 fail
 10 expect() calls
Ran 3 tests across 1 file. [6.27s]
__F:0:S:0

release with fix: all passed
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped)
  target       linux-x64-gnu
  build type   Release
  build dir    ./build/release
  revision     732b669b83
  features     baseline

23 deps, 129 codegen, 1172 objects in 968ms

ninja: Entering directory `/workspace/bun/build/release'
[1/1244] install /workspace/bun
bun install v1.4.1-canary.1 (861e9ae04)

Checked 26 installs across 63 packages (no changes) [6.00ms]
[2/1244] gen ErrorCode+*.h
[3/1244] gen bindgenv2
[4/1244] install /workspace/bun/packages/bun-error
bun install v1.4.1-canary.1 (861e9ae04)

Checked 1 install across 2 packages (no changes) [3.00ms]
[5/1244] install /workspace/bun/src/node-fallbacks
bun install v1.4.1-canary.1 (861e9ae04)

Checked 111 installs across 104 packages (no changes) [9.00ms]
[6/1244] gen .bind.ts → GeneratedBindings.cpp
[7/1244] fetch libjpeg-turbo
[libjpeg-turbo] up to date
[8/1217] gen node-fallbacks/react-refresh.js
Bundled 1 module in 16ms

  react-refresh.js  4.81 KB  (entry point)

[9/1217] gen ProcessBindingConstants.lut.h
Generating /workspace/bun/build/release/codegen/ProcessBindingConstants.lut.h from /workspace/bun/src/jsc/bindin
... (truncated)
diff hotspot
src/jsc/JSGlobalObject.rs                          |  15 +--
 src/jsc/bindings/BunString.cpp                     |   6 +-
 .../bun/util/native-error-message-too-long.test.ts | 133 +++++++++++++++++++++
 3 files changed, 136 insertions(+), 18 deletions(-)

gate history · 3 passed · 0 rejected · iteration 2

evidence per changed file
file                                                    reads  edits  tests
src/jsc/JSGlobalObject.rs                                   7      8      0
src/jsc/bindings/BunString.cpp                              3      1      0
test/js/bun/util/native-error-message-too-long.test.ts      4      8      0

@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d8521304-6f99-4c47-a6f1-3197f69a5b79

📥 Commits

Reviewing files that changed from the base of the PR and between ff5fc1f and fe5857a.

📒 Files selected for processing (4)
  • src/jsc/JSGlobalObject.rs
  • src/jsc/bindings/bindings.cpp
  • src/jsc/bindings/helpers.h
  • test/js/bun/util/native-error-message-too-long.test.ts

Included review availability: Your plan includes up to 5 reviews per rolling hour; 0 remain after this review.


Walkthrough

Changes

Native error fallback handling

Layer / File(s) Summary
Centralize typed error construction
src/jsc/bindings/helpers.h, src/jsc/bindings/bindings.cpp, src/jsc/JSGlobalObject.rs
Error constructors use typed, fallback-aware message creation. AggregateError and throw paths no longer retain empty-error checks.
Validate length-limit behavior
test/js/bun/util/native-error-message-too-long.test.ts
Subprocess tests cover exact-limit and over-limit messages, error metadata, reporting, exit codes, and crash prevention.

Suggested reviewers: jarred-sumner

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: native errors are always created when messages exceed the string length limit.
Description check ✅ Passed The description provides detailed problem, fix, scope, testing, and verification information. It does not use the exact template headings, but it covers the required content and is complete.

Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Aug 18, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status: rebuilt on current main (732b669), waiting on CI.

Main consolidated the error constructors into BunString__toErrorInstance while this PR was open, so the branch was recreated on top of main instead of rebased: the fix now lives in that single entry point (the helpers.h and createAggregateError hunks of the first revision no longer exist on main; createAggregateError now gets a WTF-backed message that the testing limit cannot affect, so that case is gone from the test). The behaviour is the same: the error is always created, with The error message exceeds the maximum string length when the real message cannot become a string.

Reproduced on main with setSyntheticAllocationLimitForTesting(1 MiB):

  • expect(() => big).toThrow() with a ~1 MiB big: release reports (pass); debug panics with assertion failed: self.has_exception() in JSGlobalObject::throw.
  • Bun.listen({ unix: <~1 MiB path> }): release segfaults, debug trips UBSan (property put on the empty value).
  • Bun.JSONC.parse(<~1 MiB token>): the empty value is thrown; debug aborts in JSC__VM__throwError.

test/js/bun/util/native-error-message-too-long.test.ts fails on main for each case (debug build without the src/ changes) and passes with them.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — targeted fix that guarantees the four get*ErrorInstance constructors always return an object, replacing an over-limit message with a fallback string.

What was reviewed:

  • errorMessageOrFallback only affects the null-return edge case; normal-size messages pass through unchanged, so the hot path is byte-identical.
  • Verified create_error_instance's other path (JSC__createError via BunString::to_error_instance) already always returns an object, so the deleted is_empty() guards in throw/throw_sys_error/throw_todo are dead; JSC__VM__throwError still ASSERT(!value.isEmpty()) if that ever regresses.
  • Test covers the boundary (at-limit kept intact vs one-past → fallback), the crash case (Bun.listen puts properties on the result), and the sibling constructor (SyntaxError from Bun.JSONC.parse), each in its own subprocess since the limit is process-wide.
Extended reasoning...

Overview

Two production files. src/jsc/bindings/helpers.h gains errorMessageOrFallback(message, source), which returns "The error message exceeds the maximum string length" when toString/toStringCopy returned null for a non-empty source, and passes message through otherwise. All four get*ErrorInstance functions now route their message through it, so they always call JSC::create*Error with a valid WTF::String and always return an object. src/jsc/JSGlobalObject.rs deletes the three if err.is_empty() { debug_assert!(has_exception()); return JsError::Thrown } branches from throw, throw_sys_error, and throw_todo, which were the only Rust-side callers that special-cased the empty return (and whose debug_assert was wrong — nothing on that path threw). One new test file with three subprocess-isolated cases.

Security risks

None. This is error-construction plumbing; the only externally observable change is that an error whose message would exceed the string length limit now carries a stand-in message instead of coming back as an empty JSValue (crash / silent pass) or with no message property. No new user input is parsed and no security check is loosened.

Level of scrutiny

Medium. helpers.h is included widely and the four constructors have dozens of callers, but the change is additive on the [[unlikely]] null-string path only — for any message under the limit errorMessageOrFallback is an identity function, so normal error creation is behaviorally identical. The Rust deletions are dead code once the C++ invariant holds; I verified the other path into create_error_instance (BunString::static_str(...).to_error_instance → JSC__createError) unconditionally calls JSC::createError and never returned empty, and that JSC__VM__throwError retains ASSERT(!value.isEmpty()) as a debug backstop.

Other factors

The PR description enumerates the sibling constructors it intentionally left alone (JSC__createError & co., systemErrorToErrorInstance, Bun__createErrorWithCode, AggregateError, DOMException) with a reason for each, which matches what I found. The test file follows harness conventions (tempDir, bunEnv, Buffer.alloc(n, fill).toString(), describe.concurrent for independent subprocesses, drains stdout/stderr/exited concurrently, asserts stderr/stdout before exit code) and exercises the exact boundary. The author verified the test fails on main (release: silent pass / segfault 139; debug: UBSan + panic) and re-ran the affected suites (expect.test.js, socketaddress.spec.ts, jsonc.test.ts, etc.). No prior reviews on the timeline beyond a CodeRabbit rate-limit notice.

Comment thread src/jsc/bindings/helpers.h Resolved
Comment thread src/jsc/bindings/helpers.h Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because it changes the shared error-construction path in the JSC bindings (used by dozens of callers) and picks a specific fallback strategy, a human look would still be worthwhile.

What was reviewed:

  • Confirmed JSC::createError(JSGlobalObject*, ErrorType, const String&) is an existing overload already used at bindings.cpp:2586 and BunAnalyzeTranspiledModule.cpp:221, so the four consolidated helpers dispatch to the same constructors as before.
  • Traced create_error_instance's two paths (JSC__createError for BunString, ZigString__toErrorInstance → getErrorInstance) — both now always return an object, so the removed is_empty() guards in throw/throw_sys_error/throw_todo are dead.
  • Checked the source.len == 0 case: errorMessageOrFallback passes the null string through unchanged, matching the old behavior for empty messages.
  • Verified the "always return an object" contract matches the reasoning already documented in ErrorCodeCache::createError (ErrorCode.cpp:210-213).
Extended reasoning...

Overview

The PR fixes a crash / silent-failure when a natively formatted error message exceeds the string length limit (WTF::String::MaxLength or the lowered Bun__stringSyntheticAllocationLimit). Zig::toString/toStringCopy return a null WTF::String in that case; the old getErrorInstance turned that into an empty JSValue, which callers then threw (nothing pending → lost failure), put() on (null deref → segfault), or wrapped in an AggregateError with no message. The fix introduces errorMessageOrFallback, which substitutes a fixed message when a non-empty source produced a null conversion, and folds the four get*ErrorInstance helpers into one createErrorInstance(globalObject, ErrorType, message, source). createAggregateError gets the same fallback. The now-unreachable is_empty() guards in JSGlobalObject.rs's throw, throw_sys_error, and throw_todo are removed.

Security risks

None. This is error-message construction; no untrusted input is parsed differently, no allocation size is derived from external data, and the change strictly narrows the set of states callers can observe (from "object or empty JSValue" to "object").

Level of scrutiny

Moderate-to-high. The four get*ErrorInstance helpers back ZigString__to{,Type,Syntax,Range}ErrorInstance, which are called from create_*_error_instance and dozens of sites across the runtime. The refactor is a pure dedup — JSC::createError(JSGlobalObject*, ErrorType, const String&) is an existing WebKit overload already used in bindings.cpp:2586 and BunAnalyzeTranspiledModule.cpp:221 — and each wrapper keeps its original conversion (toString vs toStringCopy), so the only semantic change is in the previously-broken null-message case. The removed Rust guards were checking the wrong invariant (they debug_assert!(has_exception()) when nothing on the path throws). Still, this is the shared error path in the JSC FFI layer, and the choice of fallback strategy (fixed message vs throwing vs bounded truncation) is a design call a maintainer should ratify.

Other factors

The test file is thorough: one subprocess per case (limit is process-wide; unfixed Bun.listen crashes), covers at-limit / one-past-limit boundaries for both expect() and AggregateError, exercises Error, Error+put, SyntaxError, and AggregateError paths, and asserts bun test reports (fail) with exit 1 for the uncaught case. The PR description enumerates what was intentionally left unchanged (BunString constructors, DOMException) with reasons. The comment-cop feedback about the long code comment was addressed in c43e894. The description also lists a broad set of existing tests that were re-run.

@robobun
robobun force-pushed the farm/17c6b3de/error-message-too-long branch from c43e894 to a079c43 Compare August 24, 2026 05:00

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — targeted fix for a real crash / silent-pass bug, with the fallback applied at the shared constructor so every caller is covered.

What was reviewed:

  • errorMessageOrFallback gates on source.len > 0, so a legitimately empty ZigString still yields an empty-message error (unchanged from before); only the null-from-oversize case gets the fallback.
  • The four get*ErrorInstance wrappers keep their original conversions (toString vs toStringCopy), and EnsureStillAliveScope is preserved in the shared createErrorInstance.
  • The removed is_empty() branches in throw / throw_sys_error / throw_todo are dead now that both create_error_instance paths (JSC__createError and ZigString__toErrorInstance → getErrorInstance) always return an object.
  • Tests hit the exact-limit / one-past boundary and each constructor family (Error, SyntaxError, AggregateError, plus the put-on-result crash via Bun.listen), each in its own subprocess.
Extended reasoning...

Overview

The PR fixes native error construction when the formatted message exceeds Bun__stringSyntheticAllocationLimit / WTF::String::MaxLength. Previously Zig::getErrorInstance returned an empty JSValue in that case (comment claimed a pending exception, but nothing threw), and the sibling constructors passed a null WTF::String through, producing errors with no message. Downstream, JSGlobalObject::throw turned the empty value into JsError::Thrown with nothing pending (silent (pass) in release, debug panic), and callers that decorate the result (Bun.listen setting syscall/errno/address) segfaulted on the null cell.

The fix adds errorMessageOrFallback (substitutes a fixed message when a non-empty ZigString converted to a null WTF::String) and a shared createErrorInstance(globalObject, ErrorType, message, source) that the four get*ErrorInstance helpers now delegate to. JSC__JSGlobalObject__createAggregateError applies the same fallback to its message. The now-dead is_empty() / debug_assert!(has_exception()) branches in throw, throw_sys_error, and throw_todo are removed.

Security risks

None. This is error-message construction; the only user-controlled input is the length of a message that was already being formatted, and the change makes the oversize case more robust (an object with a short constant message instead of a null deref or a lost throw).

Level of scrutiny

Medium. helpers.h is included across the C++ bindings and these constructors sit under every Rust-side create_*_error_instance call, so the contract change ("always returns an object") is widely relied on. But the change is small and strictly widens the set of inputs that produce a valid error: the common path (message under the limit) is byte-for-byte unchanged, the empty-ZigString path is unchanged (source.len > 0 guard), and only the previously-broken oversize path gains behaviour. The consolidation into createErrorInstance preserves each wrapper's original conversion (toString for Error, toStringCopy for the typed errors) and keeps the EnsureStillAliveScope. JSC::createError(JSGlobalObject*, ErrorType, const String&) is the standard JSC dispatcher to the same per-type factories the old bodies called; CI (debug+ASAN and release) confirms it compiles and behaves.

Other factors

  • Tests are thorough: four subprocess cases (process-wide limit, and the unfixed Bun.listen case crashes) covering Error via expect() (at-limit kept intact, one-past gets fallback, uncaught reported as (fail) with exit 1), the put-on-result crash via Bun.listen, SyntaxError via Bun.JSONC.parse (plus a normal-sized message unchanged), and AggregateError via a data: import with two build errors (at-limit intact, one-past fallback, errors preserved either way). Each drains stdout/stderr/exited concurrently and asserts exit code last.
  • The describe.concurrent keeps the file under ~4.5s despite four subprocess spawns.
  • The github-actions comment-cop feedback about the long comment on errorMessageOrFallback was addressed (removed in c43e894); the fallback text itself states the condition.
  • CI is green on the head commit (Buildkite build 100497), and the PR body shows the test failing on main (release: message: "" for JSONC/AggregateError, segfault for Bun.listen/expect; debug: UBSan null member call / panic) and passing with the fix.

…g length limit

BunString__toErrorInstance returned an empty JSValue, without throwing, when
the message could not be converted to a WTF::String (longer than the synthetic
allocation limit or WTF::String::MaxLength). JSGlobalObject::throw then
returned JsError::Thrown with nothing pending, so a failing bun:test assertion
whose message was over the limit reported as passing, and callers that set
properties on the result before throwing it (Bun.listen) crashed.

The error is now always created; when the message cannot be materialized it
is replaced with "The error message exceeds the maximum string length". The
now-unreachable empty-instance checks in throw, throw_sys_error and
throw_todo are removed.
@robobun
robobun force-pushed the farm/17c6b3de/error-message-too-long branch from a079c43 to 732b669 Compare August 25, 2026 03:11

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because it changes the central native error-creation path (BunString__toErrorInstance) and removes the empty-value guards in throw/throw_sys_error/throw_todo based on the new invariant, a human look would still be worthwhile.

What was reviewed:

  • Traced every Rust caller whose guard is removed (EncodedSlice::to_error_instance, JSGlobalObject::error_instance) back to BunString__toErrorInstance, which now always returns a non-null object.
  • Checked the Dead / Empty tag handling in the new fallback condition — Empty still yields an error with no message (unchanged), Dead now gets the fallback instead of a null message.
  • Note: the PR description references helpers.h/bindings.cpp and an AggregateError test; the current diff (post-rebase onto the BunString__toErrorInstance consolidation) has 3 files / 3 tests, and JSC__JSGlobalObject__createAggregateError is unchanged. Worth confirming the AggregateError drop was intentional.
Extended reasoning...

Overview

This PR fixes a crash/silent-pass bug where a natively formatted error message exceeding the string-length limit caused BunString__toErrorInstance to return an empty JSValue. Callers that then put properties on it segfaulted (release) or hit UBSan (debug), and JSGlobalObject::throw returned JsError::Thrown with no exception pending, so a failing expect() reported as (pass). The fix substitutes a fallback message ("The error message exceeds the maximum string length") instead of returning {}, and removes the now-dead is_empty() guards in throw, throw_sys_error, and throw_todo. A new subprocess-based test exercises expect(), Bun.listen, and Bun.JSONC.parse at and past the limit.

Security risks

None identified. This is error-message construction; no untrusted-input parsing, auth, or crypto is touched. The change closes a null-deref crash reachable from user input (a very long string flowing into an error message), which is a robustness improvement.

Level of scrutiny

Medium-high. The source change is small (~6 lines in BunString.cpp, ~15 lines removed in JSGlobalObject.rs), but BunString__toErrorInstance is the single funnel for all four Rust create_*_error_instance helpers and EncodedSlice::to_*_error_instance, so every native throw goes through it. Removing defensive guards based on a newly-established invariant is exactly the kind of change REVIEW.md flags for careful auditing ("delete defensive code only when you can show the condition cannot occur"). I traced the callers and the invariant holds — all four JSC::create*Error overloads return non-null — but a maintainer should confirm.

Other factors

  • The evidence gate shows the new tests fail on main (segfault / UBSan / message: "") and pass with the fix, in both debug+ASAN and release.
  • The PR description is stale relative to the current diff: it describes changes to helpers.h (errorMessageOrFallback, createErrorInstance), a one-line bindings.cpp change for createAggregateError, and a fourth AggregateError test. After rebase onto main (where the get*ErrorInstance helpers were consolidated into BunString__toErrorInstance), the diff now only touches BunString.cpp and the test file has three tests. JSC__JSGlobalObject__createAggregateError still calls arg3->toWTFString() directly and would produce an empty-message AggregateError on overflow — not a crash, but the description claims it was fixed. A human should confirm whether dropping that piece was intentional.
  • The comment-cop bot's feedback about a paragraph-long comment in helpers.h is moot since helpers.h is no longer in the diff.

@robobun

robobun commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

On the review note about the description: the body was rewritten for the rebuilt branch at the same time that review ran, so it now describes the current diff (BunString.cpp plus the three removed guards in JSGlobalObject.rs).

Dropping the AggregateError case was intentional. On current main create_aggregate_error builds its message with BunString::create_format, which produces a WTF-backed string that the testing limit does not apply to, so the only way its message can go missing is a Dead string from a message over 2^31 characters. That puts it in the same group as systemErrorToErrorInstance and Bun__createErrorWithCode, listed under "Intentionally not changed": those always return an error object and are not reachable through the testing limit. The details are in the Notes block at the end of the description.

Jarred-Sumner pushed a commit that referenced this pull request Sep 14, 2026
…ng length limit (#42202)

### Problem

- An error message that embeds a string from JS has a user-controlled
length. Building one past the string length limit aborts the process,
also inside `try`/`catch`: `panic(main thread): abort() called`, exit
code 134. Example: `bun -e 'try { Buffer.from("x", "q".repeat(2**31-10))
} catch {}'`.
- The cause: `WTF::makeString` and a default-constructed
`WTF::StringBuilder` call `CRASH()` when the result passes
`String::MaxLength`. Every message builder in
`src/jsc/bindings/ErrorCode.cpp` is one of the two.

### Fix

- `Bun::MessageBuilder` (`ErrorCode.h`) records the overflow. Every
builder in `ErrorCode.cpp` uses it, and `determineSpecificType` and
`JSValueToStringSafe` accept only that type. `createError` and
`throwError` report a message that did not fit as `RangeError: Out of
memory`.
- Five sinks outside `ErrorCode.cpp` build with `tryMakeString`: the
`performance.measure` mark, the `ReadableStream` source `type`, three
`MessageEvent` constructor messages.
- Correct because JSC reports `RangeError: Out of memory` for a string
it cannot create. Node v26.3.0 reports the same inputs as `RangeError:
Invalid string length`. A message under the limit is unchanged.
- Verified:
`test/js/bun/util/error-message-string-length-limit.test.ts`, 8 cases in
one child, which aborts on main. Also the buffer, streams, webcrypto and
MessageEvent suites. Self-reviewed: 7 concerns raised, 6 addressed, 1 is
a question for a maintainer (Notes).

### Background

- `String::MaxLength` is 2^31 - 1 code units. A JS string can be that
long.
- `StringBuilder` takes an `OverflowPolicy`. The default crashes.
`RecordOverflow` sets a flag that `hasOverflowed()` reports, and later
appends do nothing.
- `determineSpecificType` renders the `Received ...` part of
`ERR_INVALID_ARG_TYPE`. It appends `constructor.name` with no bound.
- JSC treats its own messages this way in `ExceptionHelpers.cpp`.

<details><summary>Notes</summary>

**The type guards its own reads.** `StringBuilder::toString()` and
`length()` assert that the builder did not overflow, so on
`MessageBuilder` they are private. `tryToString()` returns a null string
on overflow, and `finish(globalObject, scope)` throws. No
`hasOverflowed()` check is written by hand in `ErrorCode.cpp`.

**Question for a maintainer.** This PR reports an over-long message as
`RangeError: Out of memory` with no `.code`, like JSC and like Node.
#39481 (open) takes the other policy for the Rust-side error
constructor: it keeps the error type and properties and uses a stand-in
message. If that policy is preferred here too, the change is in two
functions: `createError(ErrorCode, MessageBuilder&)` and
`MessageBuilder::finish`.

**Moved out of this PR.** The first revision also changed
`process.execve` and `Error.stack`. Neither uses `MessageBuilder`, and
each has its own question, so each has its own PR:
- `process.execve`: #42308
- `Error.stack` and the default `Error.prepareStackTrace`: #42314

**Cases in the test.** All abort on main and on 1.4.2 with exit code
134. With this branch each one throws `RangeError: Out of memory`.

```js
const long = "q".repeat(2 ** 31 - 10);
class C {}
Object.defineProperty(C, "name", { value: long });

Buffer.from("x", long);                                   // UNKNOWN_ENCODING
Buffer.from(new C());                                     // determineSpecificType
Buffer.alloc(1).indexOf(new C());                         // JSBuffer.cpp message
new SocketAddress({ address: "1.2.3.4", port: new C() }); // Bun__ErrorCode__determineSpecificType, the entry Rust validators call
performance.measure("m", long);                           // PerformanceUserTiming.cpp
crypto.subtle.importKey(long, new Uint8Array(8), "AES-GCM", false, ["encrypt"]); // JSSubtleCrypto.cpp
new ReadableStream({ type: long });                       // JSReadableStream.cpp
ReadableStream.from(Symbol(long));                        // throwNotIterable
```

**Verified by hand, not in the test.**
- The three `MessageEvent` messages: `new MessageEvent("m", { ports:
long })`, `{ ports: [long] }`, `{ source: long }`. Each aborts on main
and throws with this branch. They render the value through the inspector
first, which takes about 20 s in a release build and about 9 minutes in
a debug ASAN build for a 2 GiB string, so they cannot be a test.
- The quoted `ERR_INVALID_ARG_VALUE` path (`Buffer.alloc(4).fill(long,
"hex")`), `ERR_OUT_OF_RANGE` with a long name, and
`NodeError.prototype.toString` with a long message throw with this
branch. The quoted path appends one character at a time, about 8 minutes
in a debug build.
- The doors reported in the comments below (`Buffer.byteLength`,
`fs.mkdirSync` mode, `process.kill` signal name, `child_process.spawn`)
all go through `MessageBuilder`.
- The whole fixture also passes under
`BUN_JSC_validateExceptionChecks=1`.

**Scope.** This does not cover every `makeString` call that can reach an
error sink. A census at `4ff91937` counted 276 `makeString(` calls and
110 default-constructed `StringBuilder` locals under `src/jsc`. The
`makeString` calls left in `ErrorCode.cpp` take an `ASCIILiteral` or an
internal string, so the binary bounds their length. A different
mechanism is also out of scope: `String::utf8()` aborts for a Latin-1
string of more than about 2^30 characters, at many call sites.

**Cost of the test.** The length is what is under test, so the input is
about 2 GiB. One child runs all 8 cases, so the string is allocated
once. Peak RSS is 4.4 GB. The file takes 2 to 4 s in a debug ASAN build.
It skips below 10 GiB of total memory, the gate
`test/js/bun/transpiler/source-too-large.test.ts` uses. The one test
keeps a 30 s ceiling, because the default 5 s is too close on a loaded
machine.

**Pre-existing failures** seen in the surrounding suites, which also
fail with `src/` at `origin/main`: `error-gc-test.test.js` (timeouts in
a debug build), `socket.test.ts > should not call drain before
handshake`, and `process.test.js > process` (this container has no
`USER` in the environment).

</details>
usrbinkat pushed a commit to usrbinkat/bun that referenced this pull request Sep 15, 2026
…ng length limit (oven-sh#42202)

### Problem

- An error message that embeds a string from JS has a user-controlled
length. Building one past the string length limit aborts the process,
also inside `try`/`catch`: `panic(main thread): abort() called`, exit
code 134. Example: `bun -e 'try { Buffer.from("x", "q".repeat(2**31-10))
} catch {}'`.
- The cause: `WTF::makeString` and a default-constructed
`WTF::StringBuilder` call `CRASH()` when the result passes
`String::MaxLength`. Every message builder in
`src/jsc/bindings/ErrorCode.cpp` is one of the two.

### Fix

- `Bun::MessageBuilder` (`ErrorCode.h`) records the overflow. Every
builder in `ErrorCode.cpp` uses it, and `determineSpecificType` and
`JSValueToStringSafe` accept only that type. `createError` and
`throwError` report a message that did not fit as `RangeError: Out of
memory`.
- Five sinks outside `ErrorCode.cpp` build with `tryMakeString`: the
`performance.measure` mark, the `ReadableStream` source `type`, three
`MessageEvent` constructor messages.
- Correct because JSC reports `RangeError: Out of memory` for a string
it cannot create. Node v26.3.0 reports the same inputs as `RangeError:
Invalid string length`. A message under the limit is unchanged.
- Verified:
`test/js/bun/util/error-message-string-length-limit.test.ts`, 8 cases in
one child, which aborts on main. Also the buffer, streams, webcrypto and
MessageEvent suites. Self-reviewed: 7 concerns raised, 6 addressed, 1 is
a question for a maintainer (Notes).

### Background

- `String::MaxLength` is 2^31 - 1 code units. A JS string can be that
long.
- `StringBuilder` takes an `OverflowPolicy`. The default crashes.
`RecordOverflow` sets a flag that `hasOverflowed()` reports, and later
appends do nothing.
- `determineSpecificType` renders the `Received ...` part of
`ERR_INVALID_ARG_TYPE`. It appends `constructor.name` with no bound.
- JSC treats its own messages this way in `ExceptionHelpers.cpp`.

<details><summary>Notes</summary>

**The type guards its own reads.** `StringBuilder::toString()` and
`length()` assert that the builder did not overflow, so on
`MessageBuilder` they are private. `tryToString()` returns a null string
on overflow, and `finish(globalObject, scope)` throws. No
`hasOverflowed()` check is written by hand in `ErrorCode.cpp`.

**Question for a maintainer.** This PR reports an over-long message as
`RangeError: Out of memory` with no `.code`, like JSC and like Node.
oven-sh#39481 (open) takes the other policy for the Rust-side error
constructor: it keeps the error type and properties and uses a stand-in
message. If that policy is preferred here too, the change is in two
functions: `createError(ErrorCode, MessageBuilder&)` and
`MessageBuilder::finish`.

**Moved out of this PR.** The first revision also changed
`process.execve` and `Error.stack`. Neither uses `MessageBuilder`, and
each has its own question, so each has its own PR:
- `process.execve`: oven-sh#42308
- `Error.stack` and the default `Error.prepareStackTrace`: oven-sh#42314

**Cases in the test.** All abort on main and on 1.4.2 with exit code
134. With this branch each one throws `RangeError: Out of memory`.

```js
const long = "q".repeat(2 ** 31 - 10);
class C {}
Object.defineProperty(C, "name", { value: long });

Buffer.from("x", long);                                   // UNKNOWN_ENCODING
Buffer.from(new C());                                     // determineSpecificType
Buffer.alloc(1).indexOf(new C());                         // JSBuffer.cpp message
new SocketAddress({ address: "1.2.3.4", port: new C() }); // Bun__ErrorCode__determineSpecificType, the entry Rust validators call
performance.measure("m", long);                           // PerformanceUserTiming.cpp
crypto.subtle.importKey(long, new Uint8Array(8), "AES-GCM", false, ["encrypt"]); // JSSubtleCrypto.cpp
new ReadableStream({ type: long });                       // JSReadableStream.cpp
ReadableStream.from(Symbol(long));                        // throwNotIterable
```

**Verified by hand, not in the test.**
- The three `MessageEvent` messages: `new MessageEvent("m", { ports:
long })`, `{ ports: [long] }`, `{ source: long }`. Each aborts on main
and throws with this branch. They render the value through the inspector
first, which takes about 20 s in a release build and about 9 minutes in
a debug ASAN build for a 2 GiB string, so they cannot be a test.
- The quoted `ERR_INVALID_ARG_VALUE` path (`Buffer.alloc(4).fill(long,
"hex")`), `ERR_OUT_OF_RANGE` with a long name, and
`NodeError.prototype.toString` with a long message throw with this
branch. The quoted path appends one character at a time, about 8 minutes
in a debug build.
- The doors reported in the comments below (`Buffer.byteLength`,
`fs.mkdirSync` mode, `process.kill` signal name, `child_process.spawn`)
all go through `MessageBuilder`.
- The whole fixture also passes under
`BUN_JSC_validateExceptionChecks=1`.

**Scope.** This does not cover every `makeString` call that can reach an
error sink. A census at `4ff91937` counted 276 `makeString(` calls and
110 default-constructed `StringBuilder` locals under `src/jsc`. The
`makeString` calls left in `ErrorCode.cpp` take an `ASCIILiteral` or an
internal string, so the binary bounds their length. A different
mechanism is also out of scope: `String::utf8()` aborts for a Latin-1
string of more than about 2^30 characters, at many call sites.

**Cost of the test.** The length is what is under test, so the input is
about 2 GiB. One child runs all 8 cases, so the string is allocated
once. Peak RSS is 4.4 GB. The file takes 2 to 4 s in a debug ASAN build.
It skips below 10 GiB of total memory, the gate
`test/js/bun/transpiler/source-too-large.test.ts` uses. The one test
keeps a 30 s ceiling, because the default 5 s is too close on a loaded
machine.

**Pre-existing failures** seen in the surrounding suites, which also
fail with `src/` at `origin/main`: `error-gc-test.test.js` (timeouts in
a debug build), `socket.test.ts > should not call drain before
handshake`, and `process.test.js > process` (this container has no
`USER` in the environment).

</details>
Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

This is Claude (an AI assistant) commenting on Jarred's behalf.

This fix went in with #46021, which is merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants