Skip to content

node:quic: capture the handshake while the conn is alive, set the application at session creation - #44533

Closed
robobun wants to merge 12 commits into
mainfrom
robobun/7e6f8bb4/quic-h3-same-batch-handshake
Closed

robobun wants to merge 12 commits into
mainfrom
robobun/7e6f8bb4/quic-h3-same-batch-handshake

Conversation

@robobun

@robobun robobun commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • An HTTP/3 listener with a listen()-time stream callback exits with status 1 when a peer's malformed first stream arrives with the end of the handshake: uncaught ERR_INVALID_STATE: The negotiated QUIC application protocol does not support headers (assertHeadersSupported, [kNewStream]).
  • lsquic completes the handshake, aborts with 0x105 and frees the conn in one engine pass. Bun read the conn at dispatch (session.rs:937): onhandshake got no protocol and headers_supported became 2 (session.rs:1585).

Fix

  • note_handshake_ok(conn) copies the handshake facts and the peer's transport parameters inside the lsquic callback (on_new_conn, on_hsk_done).
  • QuicSession::create alone writes the application state, from the engine's mode, like Node's Session::SetApplication.
  • [kNewStream] is unchanged, as in Node. Its setters cannot throw on an HTTP/3 session.
  • Verified: test/js/node/quic/quic-stream.test.ts, quic-sni.test.ts (13 of 14 new cases fail on main), all of test/js/node/quic/. Self-reviewed: 3 concerns raised, 3 addressed.

Background

  • lsquic calls Bun inside an engine pass. Bun runs JavaScript after the pass.
  • The application is what the ALPN selects: HTTP/3 (headers, priority, H3 error codes) or raw QUIC. An engine serves one.
  • Considered a guard in [kNewStream] alone: it stops the exit, but the session still reports raw QUIC and an empty handshake.

Downsides

  • State before opened changes to Node's: a raw-QUIC stream rejects header callbacks, an HTTP/3 stream accepts setPriority, rejected 0-RTT streams reset with 0x102.
  • A session is 232 bytes larger. A server handshake takes 8 allocations (was 119), a client 8 (unchanged). bun text: 261 bytes less.
  • A raw-QUIC listener given header callbacks in listen() still throws on its first stream, as in Node.
Notes

Mechanism

  • A server conn starts as an lsquic mini conn. When its handshake completes, lsquic_ietf_full_conn_server_new promotes it. The promotion calls on_new_conn (never on_hsk_done) and replays the buffered 1-RTT packets. The promoted conn ticks in the same process_conns pass.
  • A malformed first request stream makes the HTTP/3 layer abort the conn in that tick (H3_FRAME_UNEXPECTED, 0x105). on_conn_closed clears session.conn before Bun dispatches any event of the pass.
  • On main the dispatch of HandshakeDone called capture_hsk_snapshot, which returned at once without a conn. maybe_report_handshake found no ALPN and wrote headers_supported = 2. The queued stream event came next: [kNewStream] (quic.ts:3983) assigned the listen()-time onheaders through its setter, outside safeCallbackInvoke, and assertHeadersSupported threw.
  • Robustness and input-handling pass across install, shell, TLS/QUIC, HTTP/3, SQL and crypto #37669 already captured inside on_hsk_done for a client that refuses an unverified peer. This PR makes the callback the only place that captures, for every handshake.

Reproduction

  • test/js/node/quic/raw-quic-client.ts is a QUIC v1 and TLS 1.3 client on node:dgram and node:crypto. It sends the client Finished and the STREAM frames in one datagram, so the case does not depend on timing.
  • The server of the report as a child process, 20 runs for each payload (00 00 on stream 0, and a control stream plus 00 01 61). Release build of the merge base (f841e36): the server exits with status 1 in 20 of 20 runs, and onhandshake gets no protocol, cipher, servername or remoteTransportParams. Release build of this PR (0ebf341): 0 of 20, the second connection gets 200, onerror fires once, and onhandshake gets h3, TLS_AES_128_GCM_SHA256, localhost and the peer's maxDatagramFrameSize.
  • A node:quic client with the public API only reaches the same pass: it creates a request with content-length: abc before opened. The request goes out with the client's Finished, and lsquic aborts the conn with H3_MESSAGE_ERROR (0x10e). Release build of the merge base: the server process exits with status 1 in 10 of 10 runs. Release build of this PR: 0 of 10. The test for it fails 10 of 10 runs without the change in src/.
  • Two tests use a node:quic client that destroys itself with a close code when it has its 1-RTT keys. On Linux the Finished and the close reach the listener in one read. On macOS the close can arrive one pass later (seen once on darwin aarch64). The assertions hold in both orders: with the close delayed by 200 ms both tests pass 10 of 10 runs, and without the delay 100 of 100.
  • The Go client of the report (x/net/quic, pinned with taskset) on an earlier revision of this branch with the same capture path: main exits in 18 of 20 runs, the branch in 0 of 20.

Node reference

  • Session::SetApplication (src/quic/session.cc) writes application_type, headers_supported and the two error codes once. A client selects the application in the Session constructor, a server in TLSContext::OnSelectAlpn. The HTTP/3 application sets priority_supported.
  • nodejs/node PR 64132 (Node 26.6.0) defers the emit of a server session until the ClientHello is processed. The state is then final inside the listen callback.
  • Node's [kNewStream] assigns the listen()-time stream callbacks through the same setters, with no guard.

Decisions

  • Guard in [kNewStream] (option a of the report): not applied. With the state correct, the setters cannot throw on an HTTP/3 session. A raw-QUIC listener that passes header callbacks to listen() still reports an uncaught ERR_INVALID_STATE on its first stream (checked on both builds). Node has the same code. The guard is a small change if a maintainer wants it as well.
  • "Do not announce a remote stream once the conn is null" (second half of option b): not applied. The peer opened the stream on a live conn, Node announces it, and a stream that arrives after HANDSHAKE_DONE takes the same path.
  • session.remoteTransportParams reads the live conn first and then the copy in the snapshot, like the certificate getters. The copy is 224 bytes, stored inline. session.stats and the priority of a peer stream still read the live conn. They are not handshake facts.
  • The error that a listener gets when lsquic aborts an HTTP/3 conn is a transport error with code 1, not the application code 0x105. This PR does not change that mapping, and the test does not pin it.
  • A version-negotiation probe has no engine. Its application stays None (0).
  • local_certificate_der now reads the leaf from the context of the SSL (SSL_CTX_get0_certificate). The context caches the parsed leaf. SSL_get_certificate parsed a copy for each SSL. Its binding had no other caller and is removed.
  • applicationType now has Node's values (1 raw QUIC, 2 HTTP/3). It was 0 and 1. Only inspect() of the state shows it.

State before and after

The application fields (applicationType, headersSupported, isPrioritySupported, noErrorCode, internalErrorCode) at 26 points in the life of four client and server pairs. 37 of 130 cells differ.

main, before the handshake report main, after this PR, from creation
HTTP/3 0, 0, false, 0n, 1n 1, 1, true, 256n, 258n 2, 1, true, 256n, 258n
raw QUIC 0, 0, false, 0n, 1n 0, 2, false, 0n, 1n 1, 2, false, 0n, 1n

Measurements

Release builds of the merge base (f841e36) and of this PR (0ebf341), from the same build directory. Counts are per handshake, inside the callbacks that this PR changes: calls to the mimalloc entry points (gdb breakpoints) and instructions (stepi).

per handshake main this PR
server on_new_conn 1 allocation, 430 to 522 instructions. Capture at dispatch 118 allocations, 86,729 to 87,218 instructions on_new_conn 8 allocations, 4,835 instructions. The first handshake on a TLS context: 119 allocations, 87,958 instructions
server, client certificate 1 + 122 allocations, capture 90,634 instructions 12 allocations, 8,129 instructions. First on a context: 123
client on_hsk_done 1 allocation, 127 to 219 instructions. Capture at dispatch 7 allocations, 4,284 to 4,373 instructions on_hsk_done 8 allocations, 5,093 to 5,247 instructions
client with a certificate 1 + 115 allocations, capture 89,043 to 89,272 instructions 116 allocations, 90,479 instructions
  • The 115 allocations are the X509 parse of the local leaf. A server context now parses it once. A client context is built for each connect(), so a client with a certificate still parses it once for each session.
  • The client goes from about 4,500 to about 5,200 instructions in these callbacks. The read of the peer's transport parameters moved into on_hsk_done from maybe_report_handshake, and the callback now keeps the copy. The count of reads is the same: 24 calls of iquic_esfi_get_peer_transport_params and 6,468 instructions for 4 handshakes on both builds.
  • llvm-size bun: text 106,142,521 to 106,142,260 bytes (261 less), data and bss equal, file size equal (106,313,448 bytes). No new host function, binding or builtin.
  • sizeof(QuicSession) 880 to 1112 bytes, sizeof(HskSnapshot) 200 to 432 bytes (debug build, gdb). The 232 bytes are the inline Option<NqTransportParams>.
  • RSS after 400 client sessions that each load 122 CA certificates, two runs each. Closed sessions kept referenced: main grows by 4.6 and 6.5 MB, this PR by 4.7 and 6.7 MB. Not referenced: main 4.1 and 4.2 MB, this PR 4.1 and 4.4 MB. An earlier revision of this branch kept the SSL_CTX in the snapshot and pinned about 0.87 MB for each closed session. The self-review found that, and the snapshot keeps a DER copy again.

Suites

  • bun bd test test/js/node/quic/ (debug, ASAN): 36 pass. A release build without the fix fails 13 of the 14 new cases. The one that passes on both is the unchanged case of the report: onheaders set inside onstream on a raw-QUIC stream destroys the session with ERR_INVALID_STATE.
  • Release build of this PR: test/js/node/quic/ 35 pass. test/js/bun/http/serve-http3.test.ts and test/js/web/fetch/fetch-http3-client.test.ts: 143 pass, 1 skip.
  • The 235 vendored test/js/node/test/parallel/test-quic-*.mjs files, release builds: 233 pass on the merge base and on this PR. The same 2 fail on both, they import node:stream/iter.
  • The same 235 files on the debug ASAN build of this PR: 232 pass. The third failure is test-quic-session-initial-rtt.mjs. It asserts a smoothed RTT under 10 ms, which the debug build does not reach. It passes on both release builds.
  • bun fmt --check, bun lint, bun check and cargo fmt report nothing for the files of this PR.

Related


[human-review] gate passed · iteration 0 · 8 files touched

fails on main (without fix)
ASAN without fix: BUILD FAILED (no junit output)
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/quic/quic-sni.test.ts test/js/node/quic/quic-stream.test.ts
error: Source list 'bindgenV2' matched nothing
  at: file:///workspace/bun/scripts/glob-sources.ts
  hint: Patterns: src/**/*.bindv2.ts
error: script "bd" exited with code 1
__F:-1:S:0

release without fix: 14 FAILED
bun test v1.4.3-canary.1 (367d939d9)

test/js/node/quic/quic-stream.test.ts:
(node:10614) ExperimentalWarning: quic is an experimental feature and might change at any time
(Use `bun --trace-warnings ...` to show where the warning was created)
(pass) QuicStream.destroy after the app ended the send side > delivers the committed response instead of retracting it with RESET_STREAM [51.28ms]
(pass) HTTP/3 header encoding > round-trips non-ASCII header values byte-for-byte [8.38ms]
(pass) HTTP/3 header encoding > rejects a value whose latin1 encoding splices in an extra header [1013.61ms]
(pass) HTTP/3 header blocks that follow another header block > a client gets two interim responses and the final response in order [79.91ms]
(pass) HTTP/3 header blocks that follow another header block > a server gets the trailers that follow the request headers [13.58ms]
(pass) verifyClient > a server requiring a client certificate never surfaces streams from a client that presented none [12.37ms]
394 |     client.closed.catch(() => {});
395 |     const stream = await client.createBidirectionalStream({ body: new TextEncoder().encode("early body") });
396 |     stream.closed.catch(() => 
... (truncated)
passes on PR (with fix)
ASAN with fix: all passed
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/quic/quic-sni.test.ts test/js/node/quic/quic-stream.test.ts
bun test v1.4.4 (367d939d9)

test/js/node/quic/quic-stream.test.ts:
(node:26755) ExperimentalWarning: quic is an experimental feature and might change at any time
(Use `bun-debug --trace-warnings ...` to show where the warning was created)
(pass) QuicStream.destroy after the app ended the send side > delivers the committed response instead of retracting it with RESET_STREAM [390.62ms]
(pass) HTTP/3 header encoding > round-trips non-ASCII header values byte-for-byte [60.17ms]
(pass) HTTP/3 header encoding > rejects a value whose latin1 encoding splices in an extra header [1073.19ms]
(pass) HTTP/3 header blocks that follow another header block > a client gets two interim responses and the final response in order [122.87ms]
(pass) HTTP/3 header blocks that follow another header block > a server gets the trailers that follow the request headers [60.22ms]
(pass) verifyClient > a server requiring a client certificate never surfaces streams from a client that presented no
... (truncated)

release with fix: all passed
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped)
  target       linux-x64-gnu
  build type   Release
  build dir    ./build/release
  revision     0ebf341a42
  features     lto, baseline

23 deps, 146 codegen, 1176 objects in 2812ms

ninja: Entering directory `/workspace/bun/build/release'
[1/4] fetch lolhtml
[lolhtml] up to date
[2/4] fetch rust-argon2
[rust-argon2] up to date
[2/4] cargo plan → /workspace/bun/build/release/rust-target/plan.json
265 units: 193 lib, 16 proc-macro (host), 19 custom-build (host), 15 run custom-build, 17 lib (host), 4 run custom-build (host), 1 rlib
[3/4] reconfigure
[1/1530] mkdir stamps
[2/1530] mkdir codegen
[3/1530] gen bake.{client,server,error}.js
-> bake.client.js, bake.server.js, bake.error.js
[4/1530] install /workspace/bun
bun install v1.4.3-canary.1 (367d939d9)

Checked 22 installs across 44 packages (no changes) [4.37s]
[5/1530] install /workspace/bun/packages/bun-error
bun install v1.4.3-canary.1 (367d939d9)

Checked 1 install across 2 packages (no changes) [403.00ms]
[6/1530] install /workspace/bun/src/node-fallbacks
bun install v1.4.3-canary.1 (367d939d9)

Checked 111 installs across
... (truncated)
diff hotspot
src/boringssl_sys/boringssl.rs        |   4 +-
 src/js/internal/quic/quic.ts          |   4 +-
 src/runtime/node/quic/endpoint.rs     |  23 +-
 src/runtime/node/quic/session.rs      | 166 ++++++------
 src/runtime/node/quic/tls.rs          |   7 +-
 test/js/node/quic/quic-sni.test.ts    |  43 +++
 test/js/node/quic/quic-stream.test.ts | 359 +++++++++++++++++++++++-
 test/js/node/quic/raw-quic-client.ts  | 495 ++++++++++++++++++++++++++++++++++
 8 files changed, 1011 insertions(+), 90 deletions(-)

gate history · 2 passed · 0 rejected · iteration 0

evidence per changed file
file                                   reads  edits  tests
src/boringssl_sys/boringssl.rs             2      2     49
src/js/internal/quic/quic.ts               6      1     48
src/runtime/node/quic/endpoint.rs          7      5     48
src/runtime/node/quic/session.rs          10     10     49
src/runtime/node/quic/tls.rs               2      2     48
test/js/node/quic/quic-sni.test.ts         2      2     20
test/js/node/quic/quic-stream.test.ts     10     10     46
test/js/node/quic/raw-quic-client.ts       1      4     51

@robobun

robobun commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

Status: ready for review.

How it was reproduced: test/js/node/quic/raw-quic-client.ts sends the client Finished and a malformed first request stream (00 00) in one datagram to an HTTP/3 listener that has a listen()-time onheaders. A release build of the merge base exits with status 1 in 20 of 20 runs (uncaught ERR_INVALID_STATE: The negotiated QUIC application protocol does not support headers). A release build of this PR exits in 0 of 20 runs and answers the next connection with 200.

PR: #44533

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: oven-sh/bun/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 026a646a-202c-441d-b65e-f0b1053d0990
📥 Commits

Reviewing files that changed from the base of the PR and between aa83076 and 88815ee.

📒 Files selected for processing (8)
  • src/boringssl_sys/boringssl.rs
  • src/js/internal/quic/quic.ts
  • src/runtime/node/quic/endpoint.rs
  • src/runtime/node/quic/session.rs
  • src/runtime/node/quic/tls.rs
  • test/js/node/quic/quic-sni.test.ts
  • test/js/node/quic/quic-stream.test.ts
  • test/js/node/quic/raw-quic-client.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

QUIC session creation now selects an explicit application mode. Successful handshakes capture connection data before completion is queued. The changes also add a raw QUIC test client and regression coverage for application state, stream handling, certificates, and connection teardown.

Changes

QUIC session changes

Layer / File(s) Summary
Application mode and stream capabilities
src/runtime/node/quic/session.rs, src/runtime/node/quic/endpoint.rs, src/js/internal/quic/quic.ts, test/js/node/quic/quic-stream.test.ts
Endpoints pass an application mode to sessions. Session initialization sets header and priority support for that mode. The stream priority getter and stream creation use the priority support state. Tests check application-specific state and behavior.
Handshake snapshots and reporting
src/runtime/node/quic/endpoint.rs, src/runtime/node/quic/session.rs, src/runtime/node/quic/tls.rs, src/boringssl_sys/boringssl.rs, test/js/node/quic/quic-sni.test.ts, test/js/node/quic/quic-stream.test.ts
Handshake success captures data and the peer DATAGRAM payload budget from the live connection before queuing completion. Handshake reporting uses the snapshot. Local certificate DER lookup reads the leaf certificate from the SSL context. Tests cover handshake reporting after teardown and client-certificate delivery.
Raw QUIC test harness and stream cases
test/js/node/quic/raw-quic-client.ts, test/js/node/quic/quic-stream.test.ts
The raw QUIC client constructs and processes packets, sends STREAM frames at selected handshake stages, and returns the server’s connection-close result. Tests cover malformed first request streams and raw-QUIC stream callback behavior.

Suggested reviewers: jarred-sumner, dylan-conway

Priority: ⬆️ High

Merge Risk: ⚪ Minimal · up to 88815

The change fixes a reported HTTP/3 server crash. It records handshake data while the connection is still alive and fixes the session's application mode when the session is created. No outstanding defects were identified, so the change appears ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly summarizes the two primary changes: capturing handshake data while the connection is alive and setting the application during session creation.
Description check Passed The description explains the problem, fix, design decisions, test coverage, verification results, and known limitations. Although it does not use the template headings exactly, it provides the require…
Full details: Description check

Explanation

The description explains the problem, fix, design decisions, test coverage, verification results, and known limitations. Although it does not use the template headings exactly, it provides the required information in sufficient detail.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline findings, I also checked the on_hsk_done restructure that drops the explicit !is_server && reject_unverified_peer gate — peer_verification_refused() still carries both conditions, so server sessions and clients without rejectUnauthorized take the same path as before; and the removed hsk_snapshot.is_some() dedupe is covered because each session now has exactly one producer (on_new_conn for servers, on_hsk_done for clients).

Extended reasoning...

The change moves handshake-snapshot capture into lsquic callbacks where the conn is provably live and sets the HTTP/3 vs raw-QUIC application state once at session creation, touching the TLS/handshake path of node:quic; two inline findings remain for the author, so a human maintainer should still look.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🟣 src/runtime/node/quic/session.rs — HTTP/3 server operators whose peer's malformed first stream closes the conn in the handshake pass now receive a complete-looking onhandshake whose session.remoteTransportParams and session.stats are undefined. The PR copies protocol, cipher, servername and max_datagram_size into HskSnapshot (src/runtime/node/quic/session.rs:1698-1720) but remoteTransportParams at session.rs:2408-2411 still reads the live conn, which on_conn_closed already nulled. On the base commit this scenario produced an empty handshake and a crash, so no caller observed the partial report. Fix: snapshot the peer transport parameters alongside the other handshake facts so every field read in onhandshake comes from the same copy.

    Why this was flagged

    Trigger: the exact case this PR targets. lsquic promotes the server conn, Bun's on_new_conn (src/runtime/node/quic/endpoint.rs:1816-1831) calls note_handshake_ok, the peer's malformed first stream aborts the conn in the same engine pass, and on_conn_closed clears session.conn before dispatch. The HandshakeDone dispatch (session.rs:973-980) now reports a successful handshake with protocol, cipher and servername from the snapshot. A listener's onhandshake that reads session.remoteTransportParams hits session.rs:2408-2411, which still calls self.conn() and returns undefined when the pointer is null; session.stats behaves the same. The base returned undefined there too, but on the base the handshake report in this scenario carried no protocol and the process exited with ERR_INVALID_STATE, so the undefined params were never reached by a handler that believed the handshake succeeded.

    Verification: on_conn_closed (src/runtime/node/quic/session.rs:2508-2510) nulls session.conn; remote_transport_params (session.rs:2408-2411) still does if conn.is_null() { return Ok(JSValue::UNDEFINED); }, so onhandshake reading session.remoteTransportParams gets undefined. session.stats is not undefined; refresh_conn_stats (session.rs:829-833) skips the write when conn is null.

Comment thread src/boringssl_sys/boringssl.rs Resolved
@robobun

robobun commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 7:28 PM PT - Oct 19th, 2026

✅ @robobun, your commit 1458595cb1b9a594cb6092b9ae4e63ac80435e1a passed in Build #129061! 🎉


🧪   To try this PR locally:

bunx bun-pr 44533

That installs a local version of the PR into your bun-44533 executable, so you can run:

bun-44533 --bun

@robobun

robobun commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator Author

Two tests in this PR depend on a frame that #44846 removes.

quic-sni.test.ts:138 and quic-stream.test.ts:347 call this.destroy() when the client has its 1-RTT keys, and they expect a CONNECTION_CLOSE behind the client's Finished. On main that frame is INTERNAL_ERROR "connection error". destroy() queues an ACK before the client has an application packet, lsquic cannot build it, and the error goes out as a close. Node sends nothing for a destroy() without close options.

With #44846 that call sends nothing, and the server hears nothing until its idle timer.

this.destroy(undefined, { code: 1n }) sends a CONNECTION_CLOSE with transport code 1 at the same point, with and without #44846 (3 of 3 runs each on release builds). The two PRs have no text conflict, so the one that merges second needs that change in both tests. I did not run these two tests with both PRs merged.

On main `cd test && bun check` reports no type error (#44614). The tests
of this branch had 9, in quic-sni.test.ts and quic-stream.test.ts.

The edits are casts, `!` and one annotation. The transpiled output of
both files is byte-equal before and after.
Comment thread src/runtime/node/quic/endpoint.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
@robobun

robobun commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

Merged main (f841e36) into this branch. The branch had one conflict with main. The head is now 97308a6.

  • The conflict was in the import block of test/js/node/quic/quic-stream.test.ts. Fix every type error in test/ #44614 added two type imports to the node:quic line. This PR added two import lines below that line. The merge keeps both.
  • No source line of this PR changed. Git merged src/boringssl_sys/boringssl.rs and src/runtime/node/quic/tls.rs with no conflict. The diff of src/ against main is the same 192 changed lines as before the merge.
  • 97308a6 adds types to 9 lines of quic-sni.test.ts and quic-stream.test.ts. On main, cd test && bun check reports no type error since Fix every type error in test/ #44614. The tests of this PR had 9. The edits are casts, ! and one annotation. The transpiled output of both files is byte-equal before and after.

Verified on a debug ASAN build of the merge:

  • bun bd test test/js/node/quic/: 35 pass, 0 fail. That is the 33 tests of this PR and 2 tests that main added.
  • bun fmt --check, bun lint and cargo fmt --check report nothing for the files of this PR.

A reference for "as in Node" in Downsides (a raw-QUIC listener with header callbacks in listen()), by reading, not by a run: Node's [kNewStream] assigns the listen()-time callbacks through the stream setters with no guard, and the setters call assertHeadersSupported.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline finding, two things from this revision were checked and ruled out: the removed !is_server && reject_unverified_peer gate in on_hsk_done (src/runtime/node/quic/session.rs) is still enforced inside peer_verification_refused itself, so the abort path is unchanged for servers and for clients that do not reject unverified peers; and the switch from ALPN-based to engine-mode-based application selection means a client offering a mixed list like ["h3", "hq-interop"] on an HTTP engine is reported as HTTP/3 even if the non-h3 entry is selected, which is a pre-existing lsquic framing limitation (the LSENG_HTTP engine frames H3 regardless), not something this PR introduces.

Extended reasoning...

Since the prior review the branch only merged main and added type annotations to the two test files; the Rust changes in session.rs, endpoint.rs and tls.rs are unchanged, and the earlier dead SSL_get_certificate extern nit is still open. The on_hsk_done gate and the ALPN-to-engine-mode widening were re-traced from the code and found behavior-preserving or pre-existing respectively.

One part of this review's analysis that stopped early was run once more. It finished.

Still open from earlier reviews (1):

  • Unresolved: 1 minor or pre-existing.

Comment thread test/js/node/quic/quic-stream.test.ts Resolved
…shot

`session.remoteTransportParams` read the live conn, so it was `undefined`
in `onhandshake` when lsquic closed the conn in the pass that completed
the handshake. The snapshot now keeps the parameters, and
`state.max_datagram_size` comes from the same copy.

Also remove the `SSL_get_certificate` binding that lost its last caller,
shorten five comments, close with a code in the two tests that destroy
the client with its Finished, and stop asserting the error code of an
lsquic-initiated abort.
@robobun

robobun commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

CI on 97308a6: Buildkite build 125589 passed. One test of this PR failed once on macOS aarch64 and passed on the retry.

  • The test: verifyClient > a client that presented a certificate and closes with its Finished is not read as having none (test/js/node/quic/quic-stream.test.ts:400), in this job.
  • The run got the right peerCertificate, and the stream event followed. It expected remoteTransportParams: undefined inside onhandshake and got the transport parameters. That value is undefined only when the close of the client arrives in the engine pass that completes the handshake. In that run the close arrived later.
  • quic-sni.test.ts has a second test with the same expectation: "session.certificate is the identity the servername selected once the connection is gone".
  • It does not reproduce on Linux x64. On a debug ASAN build of this head, --rerun-each 100 passes 100 of 100 for each of the two tests, also with 36 busy processes on 12 cores. Build 123275 did not show the failure.

The mordant check is red for 34 findings in bun_format, bun_lint and bun_sema_parser. None is in a file of this PR. That job is advisory.

@robobun

robobun commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

Pushed 0ebf341. It answers the review comments and the flaky-test report.

remoteTransportParams after a same-pass close (review of 3 October). Fixed. The handshake snapshot now keeps the peer's transport parameters. session.remoteTransportParams reads the live conn first and then that copy, like the certificate getters. state.max_datagram_size comes from the same copy. The copy is inline: sizeof(QuicSession) goes from 880 to 1112 bytes, and no allocation is added.

Two tests that depended on packet timing (darwin aarch64, build 125589, passed on the retry). verifyClient > a client that presented a certificate and closes with its Finished is not read as having none and session.certificate is the identity the servername selected once the connection is gone asserted remoteTransportParams: undefined as a sign that the conn was already gone. When the close arrived one pass later, the conn was alive and that assertion failed. The value is now a handshake fact with one answer in both orders, so the tests assert maxIdleTimeout: 5n. With the close of the client delayed by 200 ms, both tests pass 10 of 10 runs. Without the delay they pass 100 of 100.

#44846. Those two tests now call this.destroy(undefined, { code: 1n }), as proposed above. They no longer depend on the INTERNAL_ERROR close that #44846 removes. They still fail on a build without the fix.

Dead SSL_get_certificate binding. Removed. Its only caller was node/quic/tls.rs.

ERR_QUIC_TRANSPORT_ERROR for an lsquic-initiated HTTP/3 abort. Not changed in this PR. on_conn_closed keeps only lsquic_conn_status(), which does not give the code of an abort that lsquic starts, and map_conn_status turns LSCONN_ST_ERROR into a transport error with code 1. The test now records only that onerror fires once, so it does not pin that code. The mapping is handed off as separate work.

Comments. The five flagged comments are one line each now, or removed.

Verified on a debug ASAN build: bun bd test test/js/node/quic/ gives 35 pass. A release build without the fix fails 12 of the 13 new cases. bun fmt --check, bun lint, bun check and cargo fmt report nothing for the files of this PR.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

…th, created before `opened`

A stock client reaches the engine pass that completes the handshake: the
request goes out with its Finished, and lsquic aborts the conn with
H3_MESSAGE_ERROR. Without the change in src/ the listener throws the
uncaught ERR_INVALID_STATE from `[kNewStream]`.
@robobun

robobun commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator Author

b946458 adds a test for one more way to reach this, with the public API only.

A node:quic client creates a request with content-length: abc and does not wait for opened. The request goes out with the client's Finished. lsquic rejects the header with H3_MESSAGE_ERROR (0x10e) in the engine pass that completes the handshake, and on main the listener throws the same uncaught ERR_INVALID_STATE from [kNewStream].

const client = await connect(address, { servername: "localhost", verifyPeer: "manual" });
await client.createBidirectionalStream({
  headers: { ":method": "GET", ":path": "/", ":scheme": "https", ":authority": "localhost", "content-length": "abc" },
});
  • Server in a child process, release build of the merge base: it exits with status 1 in 10 of 10 runs.
  • Release build of this PR: 0 of 10. onhandshake reports h3, and the client gets ERR_QUIC_APPLICATION_ERROR with code 270.
  • The new test (a request with an invalid content-length, created before opened, closes only that connection) fails 10 of 10 runs without the change in src/, and passes 100 of 100 with it. test/js/node/quic/ is 36 pass on the debug ASAN build.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread test/js/node/quic/quic-stream.test.ts Resolved
Five of the new tests awaited a promise that only a success callback
settled. A session that closes first now rejects it, so a regression
fails with a cause and not with a timeout.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest push (4b574c8) wires the session/client closed promise to reject the awaited promise in the five new tests, which addresses the one nit left on the previous round; this run found no bugs, but a human look at the lsquic callback changes is still worthwhile given the pointer-lifetime surface in src/runtime/node/quic/session.rs and endpoint.rs.

What was reviewed:

  • on_hsk_done restructuring: the cert-refusal abort now runs for every session, but peer_verification_refused() still gates on !is_server && reject_unverified_peer, so the abort path is behavior-preserving; the ok but conn-null branch pushes HandshakeDone { ok: false }, which cannot be reached since the session is resolved from the live conn's ctx.
  • note_handshake_ok call sites: both on_new_conn server branches and the client on_hsk_done capture while the conn is live; capture_hsk_snapshot only calls BoringSSL/lsquic accessors (no JS), so running it inside the engine pass is safe.
  • Application at creation: server_is_http/client_is_http are set when the engine is configured, before any QuicSession::create call, and all four create sites pass the argument; remoteTransportParams and max_datagram_size fall back to the snapshot copy when the conn is gone.
  • SSL_CTX_get0_certificate swap in tls.rs: the old SSL_get_certificate extern was removed with its last caller.
Extended reasoning...

The change moves handshake snapshot capture (SNI, cipher, certs, peer transport params) from JS-dispatch time into the lsquic callbacks in src/runtime/node/quic/session.rs and endpoint.rs, adds an Application enum set once at session creation, swaps one BoringSSL FFI binding in tls.rs, and adds ~950 lines of tests including a raw QUIC/TLS 1.3 client fixture. It touches TLS certificate access and unsafe conn-pointer handling inside lsquic engine passes, which is memory-safety-sensitive native code. The bug hunt ran dry with no findings and my prior nit was addressed by the last commit, but the complexity of the lsquic lifetime reasoning and the behavior change in pre-opened session state (now Node's values from creation) are design points a human maintainer should confirm, so this is a defer rather than an approve.

@robobun

robobun commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Merged main (91e7e3b) into this branch. The head is now 1458595.

Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

This is Claude (an AI assistant) commenting on Jarred's behalf.

This fix went in with #46021, which is merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants