Skip to content

node:quic: close() waits only for opened streams, and lsquic sends no GOAWAY before HTTP/3 starts - #44751

Closed
robobun wants to merge 3 commits into
mainfrom
robobun/ede10bad/quic-h3-close-before-handshake
Closed

robobun wants to merge 3 commits into
mainfrom
robobun/ede10bad/quic-h3-close-before-handshake

Conversation

@robobun

@robobun robobun commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • An HTTP/3 node:quic client that calls session.close() before its handshake ends, with one stream created, dies: panic(main thread): Segmentation fault at address 0x8 in lsquic_frab_list_write.
  • apply_graceful_close (session.rs:1917) calls lsquic_conn_going_away(). It writes a GOAWAY through the control stream writer, which a client creates when the handshake ends.
  • It also counts a pending stream as open, so close() can stall 10 s or more.

Fix

  • lsquic patch: lsquic_conn_going_away() has no effect until HTTP is initialized. QuicSession: a pending stream does not hold a graceful close open.
  • Correct because Node does both (BeginShutdown, Session::Close). Node v26.3.0 gives the same result in 7 of 7 cases.
  • Verified: 3 new tests in test/js/node/quic/quic-stream.test.ts. They fail without either half.
  • Self-reviewed: 17 concerns raised, 16 addressed. See the second Downside.

Background

  • HTTP/3 sends GOAWAY on the control stream. lsquic creates it in init_http, after the handshake.
  • A stream is pending until lsquic opens it: before the handshake ends, or over the peer's stream limit.
  • Considered the lsquic patch alone: close() then waits 10 s. Considered a check in apply_graceful_close alone: other lsquic callers still fault.

Downsides

  • Behavior change: close() drops data queued on a pending stream, as Node does. 3 raw streams with a body, peer limit 1: main delivers 3, this PR and Node 1.
  • A pending stream can still open while the close waits for an open stream, so its delivery depends on the peer's stream credit.
  • Cost per HTTP/3 close: 382 to 401 instructions, +187 bytes, 0 new calls. A 12th lsquic patch.
Notes

Reproduction. The peer is a UDP socket that never answers.

import { createSocket } from "node:dgram";
import { connect } from "node:quic";
const silent = createSocket("udp4");
await new Promise(r => silent.bind(0, "127.0.0.1", r));
const session = await connect(
  { address: "127.0.0.1", port: silent.address().port },
  { alpn: "h3", servername: "localhost", verifyPeer: "manual", onerror() {} },
);
session.opened.catch(() => {});
session.closed.catch(() => {});
const stream = await session.createBidirectionalStream({});
stream.closed.catch(() => {});
session.close(); // panic(main thread): Segmentation fault at address 0x8

The same crash comes through session[Symbol.asyncDispose](), with a unidirectional stream, and one endpoint pass later when close() runs inside a callback of another session on the same endpoint (graceful_close stores the close in pending_graceful, and flush_pending_graceful applies it). It ships in 1.4.0 to 1.4.2.

AddressSanitizer: SEGV on unknown address 0x000000000008 (READ)
#0 lsquic_frab_list_write        vendor/lsquic/src/liblsquic/lsquic_frab_list.c:79
#1 hcso_write_number_frame       lsquic_hcso_writer.c:306
#2 lsquic_hcso_write_goaway      lsquic_hcso_writer.c:325
#3 ietf_full_conn_ci_going_away  lsquic_full_conn_ietf.c:3379
#4 lsquic_conn_going_away        lsquic_conn.c:259
#5 Conn::going_away              src/lsquic_sys/lib.rs:396
#6 QuicSession::apply_graceful_close  src/runtime/node/quic/session.rs:1917
#7 QuicSession::graceful_close        src/runtime/node/quic/session.rs:2012

Cause in lsquic. init_http() creates the control stream, and hcso_on_new sets up the list of its writer. A client runs init_http() from handshake_ok(), or at creation when it resumes with stored transport parameters (a session with a valid ticket does not crash). ietf_full_conn_ci_going_away tests IFC_HTTP and not IFC_HTTP_INITED. TAILQ_LAST on the zeroed list head then reads tqh_last->tqh_last with tqh_last == NULL, which is address 0x8. The patch returns before IFC_GOING_AWAY is set, because with the flag set service_streams() drops the streams that wait for the handshake.

Results. Release builds of main (bd599f5af9) and of this PR. Node is v26.3.0 built with QUIC (--experimental-quic).

Case main this PR Node
HTTP/3, one stream (empty, request, body, unidirectional), close() before the handshake, silent peer SIGSEGV, 30 of 30 closed fulfils in 2 to 12 ms, the peer gets the Initial and a CONNECTION_CLOSE closed fulfils in 3 ms
HTTP/3, close() in the onhandshake of another session SIGSEGV, 5 of 5 closed fulfils, 5 of 5 closed fulfils
raw QUIC, stream with a body, close() before the handshake, silent peer closed after 10,000 to 10,009 ms, 7 datagrams 2 to 17 ms, 2 datagrams 3 ms
raw QUIC, live server, connect(), createBidirectionalStream({ body }), close() in one tick the server gets 5 bytes, opened fulfils 0 bytes, opened rejects ERR_INVALID_STATE 0 bytes, opened rejects ERR_INVALID_STATE
HTTP/3, after the handshake, one open request and one over the peer's limit of 1 closed after 16,505 to 16,659 ms 5 to 33 ms 7 ms
HTTP/3, unidirectional stream created before the handshake, close() after opened closed after 16,503 to 16,533 ms 2 to 5 ms not run
raw QUIC, after the handshake, 3 bidirectional streams with a body, peer limit 1, the server ends its side of each stream 3 of 3 bodies 1 of 3 1 of 3
the same with 6 streams, peer limit 2 6 of 6 2 of 6 2 of 6
the same with 120 streams, default limit (100) 120 of 120 100 of 120 100 of 120
3 streams, peer limit 1, the server keeps its side open closed after 16.5 s, 1 of 3 6 to 10 ms, 1 of 3 10 s, 1 of 3
raw QUIC, after the handshake, 6 unidirectional streams with a body, peer limit 3 6 of 6 bodies in 5 ms 3 of 6 in 4 ms no result in 60 s
HTTP/3, resumed session (0-RTT), request, close() in the same tick response 200, closed in 5 ms the same response 200, closed in 8 ms

In every row all stream.closed promises fulfil, in the three runtimes.

Node comparison. The cases of the new tests as one script for both runtimes.

// The cases of the new tests as one script for bun and for node.
//   bun close-pending.mjs [keys dir]
//   node --experimental-quic close-pending.mjs [keys dir]
// The keys dir holds agent1-key.pem and agent1-cert.pem (test/js/node/test/fixtures/keys in the bun repo).
import { createPrivateKey } from "node:crypto";
import { createSocket } from "node:dgram";
import { readFileSync } from "node:fs";
import { connect, listen, QuicEndpoint } from "node:quic";

const keysDir = process.argv[2] ?? "test/js/node/test/fixtures/keys";
const sni = {
  "*": {
    keys: [createPrivateKey(readFileSync(keysDir + "/agent1-key.pem"))],
    certs: [readFileSync(keysDir + "/agent1-cert.pem")],
  },
};
const GET = { ":method": "GET", ":path": "/", ":scheme": "https", ":authority": "localhost" };
const outcome = promise =>
  promise.then(
    () => "fulfilled",
    e => e?.code ?? String(e),
  );
const unlessParked = result =>
  Promise.race([result, new Promise(resolve => setTimeout(resolve, 2000, "still parked"))]);

// Nothing answers on this socket, so a handshake with it never ends.
const silent = createSocket("udp4");
await new Promise(resolve => silent.bind(0, "127.0.0.1", resolve));
const connectToSilentPeer = (options = {}) =>
  connect(
    { address: "127.0.0.1", port: silent.address().port },
    {
      endpoint: new QuicEndpoint(),
      servername: "localhost",
      verifyPeer: "manual",
      handshakeTimeout: 600_000,
      transportParams: { maxIdleTimeout: 0 },
      onerror() {},
      ...options,
    },
  );
const report = async (name, closed, opened, stream) =>
  console.log(
    `${name}: ` +
      (await unlessParked(
        (async () => `closed ${await outcome(closed)}, opened ${await opened}, stream.closed ${await stream}`)(),
      )),
  );

const streams = {
  "an empty stream": session => session.createBidirectionalStream({}),
  "a request": session => session.createBidirectionalStream({ headers: GET }),
  "a stream with a body": session => session.createBidirectionalStream({ body: new TextEncoder().encode("hello") }),
  "a unidirectional stream": session => session.createUnidirectionalStream({}),
};

for (const [alpn, shape] of [
  ["h3", "an empty stream"],
  ["h3", "a request"],
  ["h3", "a stream with a body"],
  ["h3", "a unidirectional stream"],
  ["quic-test", "a stream with a body"],
]) {
  const session = await connectToSilentPeer({ alpn });
  const opened = outcome(session.opened);
  const stream = outcome((await streams[shape](session)).closed);
  await report(`before the handshake, ${alpn}, close(), ${shape}`, session.close(), opened, stream);
}

{
  const session = await connectToSilentPeer();
  const opened = outcome(session.opened);
  const stream = outcome((await streams["a request"](session)).closed);
  await report("before the handshake, h3, Symbol.asyncDispose", session[Symbol.asyncDispose](), opened, stream);
}

{
  const server = await listen(
    serverSession => {
      serverSession.onerror = () => {};
      serverSession.closed.catch(() => {});
    },
    { sni },
  );
  const waiting = await connectToSilentPeer();
  const opened = outcome(waiting.opened);
  const stream = outcome((await streams["a request"](waiting)).closed);
  const closeCalled = Promise.withResolvers();
  const live = await connect(server.address, {
    endpoint: waiting.endpoint,
    servername: "localhost",
    verifyPeer: "manual",
    onerror() {},
    onhandshake() {
      closeCalled.resolve({ closed: waiting.close() });
    },
  });
  live.closed.catch(() => {});
  await report(
    "before the handshake, h3, close() in a callback of another session",
    (await closeCalled.promise).closed,
    opened,
    stream,
  );
}

{
  const paths = [];
  const firstOnServer = Promise.withResolvers();
  const server = await listen(
    serverSession => {
      serverSession.onstream = stream => stream.closed.catch(() => {});
      serverSession.closed.catch(() => {});
    },
    {
      sni,
      transportParams: { initialMaxStreamsBidi: 2, maxIdleTimeout: 0 },
      async onheaders(headers) {
        const path = headers[":path"];
        paths.push(path);
        this.sendHeaders({ ":status": "200" });
        if (path === "/first") return firstOnServer.resolve(this);
        if (path === "/upload") {
          try {
            for await (const _ of this);
          } catch {}
          this.writer.writeSync(new TextEncoder().encode("late"));
        }
        this.writer.endSync();
      },
    },
  );
  const client = await connect(server.address, {
    servername: "localhost",
    verifyPeer: "manual",
    transportParams: { maxIdleTimeout: 0 },
    onerror() {},
  });
  await client.opened;
  const firstAnswered = Promise.withResolvers();
  const uploadAnswered = Promise.withResolvers();
  const first = await client.createBidirectionalStream({
    headers: { ...GET, ":path": "/first" },
    onheaders: () => firstAnswered.resolve(),
  });
  const upload = await client.createBidirectionalStream({ onheaders: () => uploadAnswered.resolve() });
  upload.sendHeaders({ ...GET, ":method": "POST", ":path": "/upload" });
  const third = await client.createBidirectionalStream({ headers: { ...GET, ":path": "/third" } });
  const pending = [first.pending, upload.pending, third.pending];
  const thirdClosed = outcome(third.closed);
  await Promise.all([firstAnswered.promise, uploadAnswered.promise]);

  const closed = client.close();
  const result = await unlessParked(
    (async () => {
      (await firstOnServer.promise).writer.endSync();
      await outcome(first.closed);
      upload.writer.endSync();
      let body = "";
      try {
        for await (const batch of upload) for (const chunk of batch) body += Buffer.from(chunk).toString("latin1");
      } catch {}
      return `body ${JSON.stringify(body)}, closed ${await outcome(closed)}, third stream.closed ${await thirdClosed}`;
    })(),
  );
  console.log(
    `after the handshake, h3, two open requests and a third over the limit: pending ${JSON.stringify(pending)}, ${result}, server saw ${JSON.stringify(paths)}`,
  );
}

process.exit(0);

Node v26.3.0:

before the handshake, h3, close(), an empty stream: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a request: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a stream with a body: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a unidirectional stream: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, quic-test, close(), a stream with a body: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, Symbol.asyncDispose: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close() in a callback of another session: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
after the handshake, h3, two open requests and a third over the limit: pending [false,false,true], body "", closed fulfilled, third stream.closed fulfilled, server saw ["/first","/upload"]

This PR (release build):

before the handshake, h3, close(), an empty stream: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a request: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a stream with a body: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close(), a unidirectional stream: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, quic-test, close(), a stream with a body: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, Symbol.asyncDispose: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
before the handshake, h3, close() in a callback of another session: closed fulfilled, opened ERR_INVALID_STATE, stream.closed fulfilled
after the handshake, h3, two open requests and a third over the limit: pending [false,false,true], body "late", closed fulfilled, third stream.closed fulfilled, server saw ["/first","/upload"]

The first 7 lines are equal. The last line differs in body. Node loses the answer to the second open request when two requests are open at close(), with or without the third stream. With one open request Node, main and this PR all deliver it. main and this PR deliver it with two, which is what the documentation of session.close() says ("existing streams will be allowed to complete"). This PR does not change that. main crashes on the first line. The tests use handshakeTimeout: 600_000 and not 0, because Node aborts in connect() on 0.

Measurements.

  • ietf_full_conn_ci_going_away: +9 bytes (421 to 430), +1 instruction (105 to 106), 0 new calls (llvm-nm, llvm-objdump, main and PR).
  • apply_graceful_close: +114 bytes (762 to 876), +27 instructions (197 to 224), the same calls (3 indirect, 2 mi_free). QuicEndpoint::process: +64 bytes (21,082 to 21,146), +12 instructions, 210 calls in both. No other function changed size (87,868 symbols compared). size reports +866 bytes of text. The stripped bun file has the same size (88,938,056 bytes).
  • Instructions per HTTP/3 close: 382 to 401, with 1 and with 16 open streams (gdb single-step from the entry of apply_graceful_close to its return, 3 of 3 runs equal). The check of a waiting close in process(): 24 to 27 instructions per pass before, 26 to 42 after, 2 or 3 such passes per close in the probe.
  • lsquic: 12th carried patch. One refetch and 68 C files recompiled per build cache.
  • Suites on release builds, main to PR: the 235 vendored test-quic-*.mjs 233 to 233 (the same 2 fail on main: node:stream/iter does not resolve), test/js/node/quic 20 of 20 to 23 of 23, serve-http3.test.ts 72 of 72 to 72 of 72.

What pins each part (debug build with ASAN, --timeout=90000 as the CI runner passes). A close that waits reports still parked after a deadline: 3 s locally, 15 s in CI.

Change removed Result
all of src/ (the patch stays) the 3 new tests fail, each with still parked
the lsquic patch the fixture test fails: the child exits with the ASan report for lsquic_frab_list_write
is_pending() in any_stream_undelivered 2 fail: raw QUIC, and the fixture line "a stream with a body"
the has_opened_stream() branch in apply_graceful_close the test after the handshake fails: body "" and not "late"
has_opened_stream() in maybe_finish_deferred_close the test after the handshake fails: still parked
the guard refuses every client connection (no GOAWAY) the test after the handshake fails: the server sees /third

Not pinned: a guard keyed on "handshake done" and not on IFC_HTTP_INITED. They differ only for a resumed client, which has HTTP before the handshake ends. The test file ran 10 of 10 times clean with the LeakSanitizer settings of the ASAN lane. The fixture closes its server before its client endpoints, so that the stateless reset leak that #41337 fixes does not show.

Left open.

  • node:quic: a unidirectional stream created before the handshake never opens (raw QUIC) #44749: a raw QUIC unidirectional stream created before the handshake never opens (Node opens it). Before this PR close() waited 10 to 16 s for it. Now close() returns at once and drops it.
  • Streams that are pending at close() can still open while the close waits for an open stream (second Downside). In the Node runs here they never opened. The smallest fixed rule is to clear the pending queues when the close is applied. That needs a decision first, because main delivers these streams today. The other direction keeps the result of main after the handshake: any_stream_undelivered counts a pending stream again when the handshake is complete and the close sent no GOAWAY. Node does not do that (rows above).
  • close({ code }) and close({ reason }) before the handshake close the session but send no CONNECTION_CLOSE (1 datagram at the peer, Node sends 2). Not changed here.
  • A connect option such as handshakeTimeout applies only to the first connect() of an endpoint (node:quic: key shared-client-endpoint reuse on engine-baked connect() options #35765).

Other open PRs on these lines. #40220 and #37566 rewrite parts of apply_graceful_close and will conflict in text. Neither changes this behavior. #44533 does not touch the close path.

Upstream. litespeedtech/lsquic has this code since 0ee6e64 (v4.4.0). v4.9.4 and master d5929af crash the same way without bun: run bin/http_client -H localhost -s 127.0.0.1:PORT -p / against a UDP port that never answers, then send SIGUSR2 (lsquic_engine_cooldown) during the handshake. No upstream issue exists yet.


[policy-decision:dep] gate passed · iteration 0 · 6 files touched

fails on main (without fix)
ASAN without fix: 3 FAILED
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/quic/quic-stream.test.ts
bun test v1.4.3 (367d939d9)

test/js/node/quic/quic-stream.test.ts:
(node:9638) ExperimentalWarning: quic is an experimental feature and might change at any time
(Use `bun-debug --trace-warnings ...` to show where the warning was created)
(pass) QuicStream.destroy after the app ended the send side > delivers the committed response instead of retracting it with RESET_STREAM [1145.66ms]
(pass) HTTP/3 header encoding > round-trips non-ASCII header values byte-for-byte [156.76ms]
(pass) HTTP/3 header encoding > rejects a value whose latin1 encoding splices in an extra header [1210.32ms]
(pass) HTTP/3 header blocks that follow another header block > a client gets two interim responses and the final response in order [259.11ms]
(pass) HTTP/3 header blocks that follow another header block > a server gets the trailers that follow the request headers [249.09ms]
(pass) verifyClient > a server requiring a client certificate never surfaces streams from a client that presented none [167.62ms]
(pass) headers queu
... (truncated)

release without fix: 3 FAILED
bun test v1.4.3-canary.1 (367d939d9)

test/js/node/quic/quic-stream.test.ts:
(node:9686) ExperimentalWarning: quic is an experimental feature and might change at any time
(Use `bun --trace-warnings ...` to show where the warning was created)
(pass) QuicStream.destroy after the app ended the send side > delivers the committed response instead of retracting it with RESET_STREAM [115.91ms]
(pass) HTTP/3 header encoding > round-trips non-ASCII header values byte-for-byte [13.76ms]
(pass) HTTP/3 header encoding > rejects a value whose latin1 encoding splices in an extra header [1013.36ms]
(pass) HTTP/3 header blocks that follow another header block > a client gets two interim responses and the final response in order [13.04ms]
(pass) HTTP/3 header blocks that follow another header block > a server gets the trailers that follow the request headers [11.99ms]
(pass) verifyClient > a server requiring a client certificate never surfaces streams from a client that presented none [10.85ms]
(pass) headers queued before the handshake > reach the server without a write to the stream [1029.81ms]
455 |       const pending = stream.pending;
456 |       const result = await unlessPark
... (truncated)
passes on PR (with fix)
ASAN with fix: all passed
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/quic/quic-stream.test.ts
bun test v1.4.3 (367d939d9)

test/js/node/quic/quic-stream.test.ts:
(node:14368) ExperimentalWarning: quic is an experimental feature and might change at any time
(Use `bun-debug --trace-warnings ...` to show where the warning was created)
(pass) QuicStream.destroy after the app ended the send side > delivers the committed response instead of retracting it with RESET_STREAM [941.29ms]
(pass) HTTP/3 header encoding > round-trips non-ASCII header values byte-for-byte [134.65ms]
(pass) HTTP/3 header encoding > rejects a value whose latin1 encoding splices in an extra header [1200.07ms]
(pass) HTTP/3 header blocks that follow another header block > a client gets two interim responses and the final response in order [247.38ms]
(pass) HTTP/3 header blocks that follow another header block > a server gets the trailers that follow the request headers [124.22ms]
(pass) verifyClient > a server requiring a client certificate never surfaces streams from a client that presented none [177.47ms]
(pass) headers queu
... (truncated)

release with fix: all passed
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped) in 2458ms (unchanged)
ninja: Entering directory `/workspace/bun/build/release'
[1/209] gen generated_host_exports.rs
generated_host_exports.rs: 120 exports (host=5, lazy=10, generic=105, rust=0); 248 extern-C blocks audited
[2/208] build.rs build_script_build
[3/208] rustc bun_platform 
[4/208] rustc bun_core 
[5/208] rustc bun_errno 
[6/208] rustc bun_ptr 
[7/208] rustc bun_paths 
[8/208] rustc bun_collections 
[9/208] rustc bun_url 
[10/208] cxx obj/unified/UnifiedSource-packages_bun_usockets_src_crypto-0.cpp.o
[11/208] rustc bun_sys 
[12/208] rustc bun_perf 
[13/208] rustc bun_cares_sys 
[14/208] cxx obj/unified/UnifiedSource-src_jsc_bindings_node_http-0.cpp.o
[15/208] rustc bun_http_types 
[16/208] rustc bun_boringssl_sys 
[17/208] rustc bun_semver 
[18/208] rustc bun_uws_sys 
[19/208] rustc bun_boringssl 
[20/208] rustc bun_sha_hmac 
[21/208] rustc bun_analytics 
[22/208] rustc bun_safety 
[23/208] rustc bun_md 
[24/208] rustc bun_sql 
[25/208] rustc bun_spawn_sys 
[26/208] rustc bun_base64 
[27/208] rustc bun_threading 
[28/208] rustc bun_picohttp 
[29/208] rustc bun_ast 
[30/
... (truncated)
diff hotspot
patches/lsquic/going-away-http-inited.patch        |  39 ++++
 scripts/build/deps/lsquic.ts                       |   6 +
 src/runtime/node/quic/session.rs                   |  26 ++-
 src/runtime/node/quic/stream.rs                    |   4 +
 .../quic/quic-close-before-handshake-fixture.ts    | 116 ++++++++++++
 test/js/node/quic/quic-stream.test.ts              | 198 ++++++++++++++++++++-
 6 files changed, 380 insertions(+), 9 deletions(-)

gate history · 1 passed · 0 rejected · iteration 0

evidence per changed file
file                                                      reads  edits  tests
patches/lsquic/going-away-http-inited.patch                   0      0     48
scripts/build/deps/lsquic.ts                                  1      1     50
src/runtime/node/quic/session.rs                              1      1     50
src/runtime/node/quic/stream.rs                               1      1     49
test/js/node/quic/quic-close-before-handshake-fixture.ts      0      3     52
test/js/node/quic/quic-stream.test.ts                         3      1     48

A graceful close of an HTTP/3 client session before the handshake ended,
with one stream created, crashed the process: lsquic_conn_going_away()
wrote the GOAWAY through the control stream writer, which a client sets
up only when the handshake gives it the peer's transport parameters.

lsquic: lsquic_conn_going_away() has no effect until HTTP is initialized
(patches/lsquic/going-away-http-inited.patch).

QuicSession: a graceful close waits only for the streams that lsquic
opened. A stream that is still pending (no handshake yet, or over the
peer's stream limit) does not hold the close open.
@robobun

robobun commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

Status. How the crash was reproduced:

  • The script in the Notes of this PR (an HTTP/3 client, a UDP peer that never answers, one stream, session.close()) on 1.4.2, on 1.4.3-canary (367d939d9) and on a release build of main (bd599f5af9): panic(main thread): Segmentation fault at address 0x8. The three HTTP/3 cases with a stream crash in 30 of 30 runs on main and in 0 of 30 with this PR.
  • A debug build of main with ASAN: SEGV on unknown address 0x000000000008 in lsquic_frab_list_write (lsquic_frab_list.c:79), called from QuicSession::apply_graceful_close (session.rs:1917).
  • USE_SYSTEM_BUN=1 bun test test/js/node/quic/quic-stream.test.ts: the 3 new tests fail (SIGSEGV in the fixture, still parked in the other two). bun bd test on this branch: 10 of 10 pass.

PR: #44751

@robobun

robobun commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 2:23 AM PT - Oct 8th, 2026

❌ @robobun, your commit 6546653 has 2 failures in Build #123873 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 44751

That installs a local version of the PR into your bun-44751 executable, so you can run:

bun-44751 --bun

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: oven-sh/bun/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 6583d7af-5eaa-4031-ad22-6152c312fd33
📥 Commits

Reviewing files that changed from the base of the PR and between 6838bd2 and 5a816d2.

📒 Files selected for processing (2)
  • test/js/node/quic/quic-close-before-handshake-fixture.ts
  • test/js/node/quic/quic-stream.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


Walkthrough

The change prevents LSQUIC from writing GOAWAY before HTTP initialization. QUIC graceful close now distinguishes pending streams from opened streams. Tests cover close behavior before handshake completion and while streams are pending.

Changes

QUIC graceful close

Layer / File(s) Summary
Guard pre-initialization GOAWAY writes
patches/lsquic/going-away-http-inited.patch, scripts/build/deps/lsquic.ts
lsquic_conn_going_away() now returns when HTTP is not initialized. The LSQUIC dependency applies this patch.
Close based on opened streams
src/runtime/node/quic/stream.rs, src/runtime/node/quic/session.rs
QuicStream::is_pending() exposes stream pending state. Graceful close defers for opened streams, and undelivered-outbound checks exclude pending streams.
Test close behavior with pending streams
test/js/node/quic/quic-close-before-handshake-fixture.ts, test/js/node/quic/quic-stream.test.ts
Tests cover pre-handshake close and disposal cases, raw QUIC close, and an established session with two opened streams and a third pending stream.

Priority: ⬆️ High

Merge Risk: ⚪ Minimal · up to 5a816

Close behavior distinguishes pending from opened streams, and GOAWAY remains available after HTTP initialization. No actionable merge risk remains; normal checks are appropriate.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies both primary changes: graceful close waits only for opened streams, and lsquic avoids sending GOAWAY before HTTP/3 initialization.
Description check ✅ Passed The description provides detailed problem, fix, rationale, verification results, test coverage, behavior changes, and known limitations. It does not use the template headings exactly, but it fully cov…
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I also checked the lsquic patch itself: the early return sits before IFC_GOING_AWAY is set, so service_streams() keeps handshake-waiting streams, and an HTTP/3 session whose streams are all pending now falls through to the same immediate-close path as the raw-QUIC branch (GOAWAY and CONNECTION_CLOSE in one pass, where the base crashed or stalled). The stream-limit test's reliance on lsquic discarding the delayed third bidi stream after GOAWAY was also examined and holds for bidi streams.

Extended reasoning...

The change touches the vendored lsquic going-away path (new C patch registered in scripts/build/deps/lsquic.ts), the node:quic graceful-close logic in session.rs, a small is_pending accessor in stream.rs, and new tests plus a spawned fixture; no auth, crypto, or injection surface is involved. Inline findings already flag the behavior change for pending unidirectional streams and a timing risk in the fixture, so a human look is warranted regardless of this note.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread src/runtime/node/quic/session.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
Comment thread src/runtime/node/quic/session.rs Resolved
…ounts as parked

The deadline was 2 s everywhere. CI runs many test files at once, so a
correct close can be slow there. The test passes the deadline to the
fixture, so both use the same value.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no new issues

No new issues were found in this update; 1 finding from earlier reviews is still open above.

Still open from earlier reviews (1):

If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@robobun

robobun commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: #46021 landed this behavior on main.

  • QuicStream::is_pending, has_opened_stream, and the narrowed any_stream_undelivered and maybe_finish_deferred_close are on main since 9b4284f. apply_graceful_close now sends the GOAWAY only when an opened stream exists, so close() before the handshake no longer reaches lsquic_conn_going_away().
  • I put the tests of this PR on main at 5c6d4e2 (3 cases, one of them runs the 6 crash cases in a spawned fixture) and ran bun bd test test/js/node/quic/quic-stream.test.ts (debug build with ASAN): 16 of 16 pass.
  • Not on main: patches/lsquic/going-away-http-inited.patch. With the check in apply_graceful_close, no caller in bun reaches lsquic_conn_going_away() before HTTP is initialized, so the patch changes nothing that a user can see. The upstream lsquic bug is still there (the repro is in the Notes above).
  • One difference that a peer can see: when HTTP/3 has started and every stream is still pending, main closes without a GOAWAY. This PR sent one first, as Node does.

The two tests of this PR for raw QUIC and for a close after the handshake are not on main. In this PR they were the tests that failed when the is_pending() checks in any_stream_undelivered and maybe_finish_deferred_close were removed. Reopen this PR if the lsquic patch or those tests are wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants